@brecht: TL,DR: This PR contains two fixes to actual issues (64-bit pointer deltas being cast to 32-bit ints)
Which ones they are should be obvious after I push my update later today.…
@ideasman42, I agree that only a small number of these are actual bugs. In this set of 149 fixes, 2 involved issues casting (often 64 bit) pointers to (usually 32 bit) ints, which I would consider…
From #blender-coders:
@linux_dr (2023-08-25 9:31 PM) [... I] Just hate thinking of other developers wasting time getting bitten by this too… but as you said, no point throwing good time…
From #blender-coders:
@linux_dr (2023-08-25 9:31 PM) [... I] Just hate thinking of other developers wasting time getting bitten by this too… but as you said, no point throwing good time…
From #blender-coders:
@linux_dr (2023-08-25 9:31 PM) [... I] Just hate thinking of other developers wasting time getting bitten by this too… but as you said, no point throwing good time…
I’ve started work on a fix for this. One main annoyance is that svn refuses to return non-zero exit codes, almost ever. I’m confident I can detect non-clean working directories, and produce,…
@LazyDodo , Much thanks as always. FYI, ../lib/tests would have been more helpful than r63469 but I found what you meant:
Here's what I did find:
- Relevant output from
make update…
… it might be better to talk in the blender chat instead, where more people who are familiar with cmake and svn can chime in and help.
@Sergey, Where is the blender developer chat now? I…
@Sergey, I'm really liking the idea of these tests, but I'm finding on my environment, I'm not getting the tests to pull the test data from the lib directory, (or pull the updated data down from…
If you can provide answers to my questions, I’ll know if I should revise or abandon this PR.
Thank you,
-Loren
Just to be clear, I consider these warnings as “valid” low-priority issues that should eventually be addressed for code hygiene and to facilitate the use of automated tools in code analysis,…
- We have a convention to prefer signed types of unsigned types, as unsigned types can lead to bugs when intermediate values are negative.
size_tmay be fine for e.g. measuring memory sizes,…
For fixing the integer conversion warnings, some buy-in from @ideasman42 @HooglyBoogly @JacquesLucke would be good. I think they have been most involved in cleanups and/or defining guidelines…
- extern are copies of other projects. In stead of fixing them locally I think it is better to fix them upstream.
Yes, I actually noticed this after posting the PR. Let me detail the plan of…
We should try to align compiler flags between Xcode and the command line and other platforms. Keeping the warnings fixed is not practical if few developers use Xcode.
Definitely! Having…
It might be appropriate to attach this to https://projects.blender.org/blender/blender/projects/11