Ideally, it would be nice if the reports wouldn't be limited to printing to the console when running the exporter in the foreground, but this might be an acceptable limitation.
I will do a quick local build and test for due diligence, but the change looks good to me! Thank you for the fix!
LGTM, thanks. Can even likely be backported to our LTS releases (3.6 and 3.3 maybe)?
Thanks for the review! I will go ahead and create pull requests into 3.6 and 3.3 LTS.
@Omar-Mokhtar…
I created pull request blender/blender#113524 to address this issue.
I have a local fix to the issue. Will create a pull request for this next. Thanks for reporting this, @Omar-Mokhtar.
I'm taking a look at the issue.
@makowalski About taking evaluation mode into account for viewport vs render, that is a good catch, thanks, and thanks for the suggested code snippet. I think I just need a small change on…
I think we may want to fetch the subdiv modifier only if it's the last modifer AND is enabled for the current depsgraph evaluation mode (viewport
or render
).
Maybe the logic can be wrapped…
I think SubsurfModifierData* subsurfData
can be const.
I wonder whether exporting normals should be skipped if the subdivision scheme is not set to "none". The USD docs seem to suggest this, if I'm reading them correctly:
You're very welcome! As for a PR, we need to keep in mind that this implementation requires changes in Kevin's branch
https://projects.blender.org/kevindietrich/blender/src/branch/abc_usd_geome…