Michael Kowalski makowalski
  • Joined on 2020-09-17
Michael Kowalski commented on pull request blender/blender#113548 2023-10-12 03:10:20 +02:00
Make wmJob worker thread use their own reports list instead of WM one.

Ideally, it would be nice if the reports wouldn't be limited to printing to the console when running the exporter in the foreground, but this might be an acceptable limitation.

Michael Kowalski commented on pull request blender/blender#113537 2023-10-11 17:31:34 +02:00
Fix USD Export crash with complex scenes, due to race condition during depsgraph building.

I will do a quick local build and test for due diligence, but the change looks good to me! Thank you for the fix!

Michael Kowalski commented on pull request blender/blender#113524 2023-10-11 16:59:44 +02:00
Fix #113400: USD transform cache crash on invalid prim.

LGTM, thanks. Can even likely be backported to our LTS releases (3.6 and 3.3 maybe)?

Thanks for the review! I will go ahead and create pull requests into 3.6 and 3.3 LTS.

@Omar-Mokhtar…

Michael Kowalski deleted branch usd_xf_anim_crash_113400 from makowalski/blender 2023-10-11 16:21:33 +02:00
Michael Kowalski closed issue blender/blender#113400 2023-10-11 16:21:31 +02:00
Opening a blend file that has objects with animation transform cache previously imported from a USD will crash if the animation in the USD is missing afterwards
Michael Kowalski merged pull request blender/blender#113524 2023-10-11 16:21:28 +02:00
Fix #113400: USD transform cache crash on invalid prim.
Michael Kowalski pushed to blender-v4.0-release at blender/blender 2023-10-11 16:21:28 +02:00
f4124b4e20 Fix #113400: USD transform cache crash on invalid prim.
Michael Kowalski created pull request blender/blender#113524 2023-10-11 03:09:18 +02:00
Fix #113400: USD transform cache crash on invalid prim.
Michael Kowalski pushed to usd_xf_anim_crash_113400 at makowalski/blender 2023-10-11 03:03:22 +02:00
7d1054b6f0 Fix #113400: USD transform cache crash on invalid prim.
b0515e34f9 UI: Input Placeholders
c006c1809d BLI_fileops: set the errno if read returns an invalid value
ab2618e186 Fix compile error due to conversion to 'long unsigned int' from 'int'
a238ab737b Fix (unreported) liboverride: Hierarchy corruption when making some override local.
Compare 10 commits »
Michael Kowalski created branch usd_xf_anim_crash_113400 in makowalski/blender 2023-10-11 03:03:22 +02:00
Michael Kowalski commented on issue blender/blender#113400 2023-10-10 23:34:08 +02:00
Opening a blend file that has objects with animation transform cache previously imported from a USD will crash if the animation in the USD is missing afterwards

I have a local fix to the issue. Will create a pull request for this next. Thanks for reporting this, @Omar-Mokhtar.

Michael Kowalski commented on pull request blender/blender#113267 2023-10-06 02:04:10 +02:00
USD: optionally author subdivision schema on export

@makowalski About taking evaluation mode into account for viewport vs render, that is a good catch, thanks, and thanks for the suggested code snippet. I think I just need a small change on…

Michael Kowalski commented on pull request blender/blender#113267 2023-10-06 00:02:40 +02:00
USD: optionally author subdivision schema on export

I think we may want to fetch the subdiv modifier only if it's the last modifer AND is enabled for the current depsgraph evaluation mode (viewport or render).

Maybe the logic can be wrapped…

Michael Kowalski commented on pull request blender/blender#113267 2023-10-05 23:40:42 +02:00
USD: optionally author subdivision schema on export

I think SubsurfModifierData* subsurfData can be const.

Michael Kowalski commented on pull request blender/blender#113267 2023-10-05 20:03:17 +02:00
USD: optionally author subdivision schema on export

I wonder whether exporting normals should be skipped if the subdivision scheme is not set to "none". The USD docs seem to suggest this, if I'm reading them correctly:

Michael Kowalski commented on issue blender/blender#106398 2023-10-05 15:53:18 +02:00
UsdGeomPoints import support

You're very welcome! As for a PR, we need to keep in mind that this implementation requires changes in Kevin's branch

https://projects.blender.org/kevindietrich/blender/src/branch/abc_usd_geome