blender
/
blender
129
398
Fork 572
Code Issues 6.2k Pull Requests 747 Projects 19 Wiki Activity

UsdGeomPoints import support #106398

New Issue
Open
opened 2023-03-31 18:43:41 +02:00 by devin-bayly · 78 comments
devin-bayly commented 2023-03-31 18:43:41 +02:00
Copy Link

This issue aims to describe a task that will support the import of colorized point clouds to blender via the USD type UsdGeomPoints. It's also the goal of this design task to support the .timeSampled extension of both the points3f[] and color3f[] attributes in a UsdGeomPoints prim. This contribution would also aim to directly create blender point types, instead of making vertices that need to be converted via a geometry node Mesh to points kind of step.

Related tasks that this will be separate from

  • particle systems: This task doesn't aim to support attributes like velocity, or make use of the UsdGeomPointInstancer. Such an importer is interesting and useful, but likely outside of my ability to implement whereas this task is less complex.
  • leveraging the csv importer: Some user's model data could be converted into a json or csv notation, and with geometry nodes to convert the per vertex attributes into things like position <x,y,z> and color <r,g,b> for display.
  • leveraging an alembic or openvdb: It's actually unclear to me whether these approaches are currently possible although it seems unlikely. One user's experience suggests the alembic route isn't either direct or possible 3. Openvdb is really meant to represent an entirely different type of 3d compound so I believe this is also likely to be a dead end.
  • python addons: In the past I've leveraged python scripting to make vertex layers with the data that doesn't get correctly parsed when importing either .ply or .usd files. This is also ok when using just a single point cloud, but becomes problematic when dealing with a sequence of point clouds who's points position and color change over time.
  • modifying existing mesh usd reader: Although it was my first thought this isn't a reasonable approach for a couple of reasons 4. This would require specifying that the mesh faces and indices are empty lists. This technically would be a faceless mesh. If something like UsdGeomPoints didn't exist perhaps this abstraction of the mesh type would be valid, but there's already a much more accurate USD representation available.

This feature would support many users over the last few years who've posted about not being able to bring in colored point clouds. Some of these posts go back to pre blender 3, but this feature is still something that more recent users have needed also. Some issues relate to a different format .ply which is common when representing point clouds, but suffers when it comes to representing sequences of point clouds 1 2. It's for this reason that USD is such an appealing format with it's explicit .timeSampled attribute options.

I'm looking forward to spending time on this, but will probably need a certain degree of support from other members of the USD format team. Thanks for all your incredible work!

This issue aims to describe a task that will support the import of colorized point clouds to blender via the USD type UsdGeomPoints. It's also the goal of this design task to support the `.timeSampled` extension of both the `points3f[]` and `color3f[]` attributes in a UsdGeomPoints prim. This contribution would also aim to directly create blender point types, instead of making vertices that need to be converted via a geometry node `Mesh to points` kind of step. Related tasks that this will be separate from * particle systems: This task doesn't aim to support attributes like velocity, or make use of the UsdGeomPointInstancer. Such an importer is interesting and useful, but likely outside of my ability to implement whereas this task is less complex. * leveraging the csv importer: Some user's model data could be converted into a json or csv notation, and with geometry nodes to convert the per vertex attributes into things like position <x,y,z> and color <r,g,b> for display. * leveraging an alembic or openvdb: It's actually unclear to me whether these approaches are currently possible although it seems unlikely. One user's experience suggests the alembic route isn't either direct or possible [3]. Openvdb is really meant to represent an entirely different type of 3d compound so I believe this is also likely to be a dead end. * python addons: In the past I've leveraged python scripting to make vertex layers with the data that doesn't get correctly parsed when importing either .ply or .usd files. This is also ok when using just a single point cloud, but becomes problematic when dealing with a sequence of point clouds who's points position and color change over time. * modifying existing mesh usd reader: Although it was my first thought this isn't a reasonable approach for a couple of reasons [4]. This would require specifying that the mesh faces and indices are empty lists. This technically would be a faceless mesh. If something like UsdGeomPoints didn't exist perhaps this abstraction of the mesh type would be valid, but there's already a much more accurate USD representation available. This feature would support many users over the last few years who've posted about not being able to bring in colored point clouds. Some of these posts go back to pre blender 3, but this feature is still something that more recent users have needed also. Some issues relate to a different format .ply which is common when representing point clouds, but suffers when it comes to representing sequences of point clouds [1] [2]. It's for this reason that USD is such an appealing format with it's explicit `.timeSampled` attribute options. I'm looking forward to spending time on this, but will probably need a certain degree of support from other members of the USD format team. Thanks for all your incredible work! [1]: https://blender.stackexchange.com/questions/158052/blender-2-81-doesnt-seem-to-be-importing-vertex-color-for-ply "ply import probs" [2]: https://blender.stackexchange.com/questions/227744/import-ply-with-vertex-colors-into-blender "ply import probs2" [3]: https://blender.stackexchange.com/questions/268751/getting-colored-point-cloud-sequence-into-blender "User struggling with alembic colored point sequence import" [4]: https://blender.stackexchange.com/questions/289545/blender-isnt-reading-color-attributes-from-usd "can't use existing mesh importer"
devin-bayly added the
Type
Design
 label 2023-03-31 18:43:42 +02:00
Michael Kowalski added reference blender-v3.5-release 2023-03-31 18:53:01 +02:00
Michael Kowalski added the
Interest
USD
Interest
Pipeline, Assets & IO
 labels 2023-03-31 18:53:32 +02:00
Hans Goudey commented 2023-04-01 16:48:36 +02:00
Member
Copy Link

To me it looks like this boils down to two features in the end:

  • Point cloud support: UsdGeomPoints should end up as a Blender PointCloud data-block.
  • Generic attribute support: Generic attributes should be imported and added to geometry, including colors, floats, integers, etc. This would cover the colored point clouds use case you mentioned (and much more).

Do you think it's reasonable to break up the work this way?

To me it looks like this boils down to two features in the end: - Point cloud support: `UsdGeomPoints` should end up as a Blender `PointCloud` data-block. - Generic attribute support: Generic attributes should be imported and added to geometry, including colors, floats, integers, etc. This would cover the colored point clouds use case you mentioned (and much more). Do you think it's reasonable to break up the work this way?
devin-bayly commented 2023-04-03 18:38:19 +02:00
Author
Copy Link

@HooglyBoogly thanks for the the information. It sounds like exactly the approach I should be taking. if the UsdGeomPoint type is converted into a blender point cloud data block that would save the user from doing any manual conversions on their own. And I also agree that support for generic custom attribute information attached to each point would be a real game changer!

my plan is to first review how the mesh reader already written is parsing USD files and creating blender specific information. I've been hoped to start writing some code of my own now that I have completed my first blender compilation build. I believe in the USD mesh reader there is already some code (provided by @makowalski ? ) demonstrates how to handle generic attribute information which all study up on.

@HooglyBoogly thanks for the the information. It sounds like exactly the approach I should be taking. if the UsdGeomPoint type is converted into a blender point cloud data block that would save the user from doing any manual conversions on their own. And I also agree that support for generic custom attribute information attached to each point would be a real game changer! my plan is to first review how the mesh reader already written is parsing USD files and creating blender specific information. I've been hoped to start writing some code of my own now that I have completed my first blender compilation build. I believe in the USD mesh reader there is already some code (provided by @makowalski ? ) demonstrates how to handle generic attribute information which all study up on.
Michael Kowalski commented 2023-04-03 19:48:04 +02:00
Member
Copy Link

@devin-bayly There is a work in progress adding support for generic attributes for meshes here:

#105347

I would suggest waiting until this patch is done before you start this task. That task will hopefully be committed soon. @CharlesWardlaw implemented that pull request and could answer questions about that feature. I would also suggest that we discuss your proposed design and implementation (most likely a new USDPointsReaderclass, or something similar) before you begin.

@devin-bayly There is a work in progress adding support for generic attributes for meshes here: https://projects.blender.org/blender/blender/pulls/105347 I would suggest waiting until this patch is done before you start this task. That task will hopefully be committed soon. @CharlesWardlaw implemented that pull request and could answer questions about that feature. I would also suggest that we discuss your proposed design and implementation (most likely a new `USDPointsReader`class, or something similar) before you begin.
devin-bayly commented 2023-04-08 19:27:16 +02:00
Author
Copy Link

I would suggest waiting until this patch is done before you start this task.

Sounds great @makowalski. I'm new to blender contribution so I'll take the time to explore topics related to data-blocks and some of the other existing code written for parsing USD files.

That task will hopefully be committed soon. @CharlesWardlaw implemented that pull request and could answer questions about that feature.

Ok I look forward to chatting with Charles when the time comes. Is it best to use the #blender-chat USD channel for that?

I would also suggest that we discuss your proposed design and implementation (most likely a new USDPointsReaderclass, or something similar) before you begin.

Sure I like this plan. I don't have too many existing ideas to propose but after I have a chance to look through the patch and the blender data-block C code I hope I'll have more on this to propose.

> I would suggest waiting until this patch is done before you start this task. Sounds great @makowalski. I'm new to blender contribution so I'll take the time to explore topics related to data-blocks and some of the other existing code written for parsing USD files. > That task will hopefully be committed soon. @CharlesWardlaw implemented that pull request and could answer questions about that feature. Ok I look forward to chatting with Charles when the time comes. Is it best to use the #blender-chat USD channel for that? > I would also suggest that we discuss your proposed design and implementation (most likely a new USDPointsReaderclass, or something similar) before you begin. Sure I like this plan. I don't have too many existing ideas to propose but after I have a chance to look through the patch and the blender data-block C code I hope I'll have more on this to propose.
devin-bayly commented 2023-04-25 21:02:55 +02:00
Author
Copy Link

I was just looking at the issue conversation over at #105347 and I see a merged icon at the bottom, does this mean that the patch supporting generic mesh attributes is done?

I'm having a good time going through the orielly book about blender development. I'm focusing on the section about the RNA and Data api since I imagine that's what I'll be needing to interface with after reading the geom usd files. If there's other relevant material I should be studying let me know. Thanks so much!

I was just looking at the issue conversation over at https://projects.blender.org/blender/blender/pulls/105347 and I see a merged icon at the bottom, does this mean that the patch supporting generic mesh attributes is done? I'm having a good time going through the orielly book about blender development. I'm focusing on the section about the RNA and Data api since I imagine that's what I'll be needing to interface with after reading the geom usd files. If there's other relevant material I should be studying let me know. Thanks so much!
Michael Kowalski commented 2023-04-27 04:19:39 +02:00
Member
Copy Link

I was just looking at the issue conversation over at #105347 and I see a merged icon at the bottom, does this mean that the patch supporting generic mesh attributes is done?

@CharlesWardlaw for visibility.

I believe that patch covers color conversion only, but it's a good example of working with attributes.

If you haven't done so already, I would take a look at how the various USD and Alembic "reader" classes are implemented. BTW, the Alembic importer implements a mesh-based points reader that might be of interest:

https://projects.blender.org/blender/blender/src/branch/main/source/blender/io/alembic/intern/abc_reader_points.h
https://projects.blender.org/blender/blender/src/branch/main/source/blender/io/alembic/intern/abc_reader_points.cc

> I was just looking at the issue conversation over at https://projects.blender.org/blender/blender/pulls/105347 and I see a merged icon at the bottom, does this mean that the patch supporting generic mesh attributes is done? @CharlesWardlaw for visibility. I believe that patch covers color conversion only, but it's a good example of working with attributes. If you haven't done so already, I would take a look at how the various USD and Alembic "reader" classes are implemented. BTW, the Alembic importer implements a mesh-based points reader that might be of interest: https://projects.blender.org/blender/blender/src/branch/main/source/blender/io/alembic/intern/abc_reader_points.h https://projects.blender.org/blender/blender/src/branch/main/source/blender/io/alembic/intern/abc_reader_points.cc
Charles Wardlaw commented 2023-05-01 16:02:53 +02:00
Member
Copy Link

Ok I look forward to chatting with Charles when the time comes. Is it best to use the #blender-chat USD channel for that?

Yes, please @kattkieru me in the chat and I'll appear, as if Final Fantasy summoned. 😆

I was just looking at the issue conversation over at #105347 and I see a merged icon at the bottom, does this mean that the patch supporting generic mesh attributes is done?

Yes, it was merged. It's a good example of how to handle the colors, and how USD and Blender each deal with them differently. If you look at the import and export sides, you'll see some conversion going on. There's also the interesting wrinkle that USD can specify a constant single color as applying to a whole prim's points, which on the Blender side needs to be expanded into the full generic attribute array.

I'm having a good time going through the orielly book about blender development. I'm focusing on the section about the RNA and Data api since I imagine that's what I'll be needing to interface with after reading the geom usd files. If there's other relevant material I should be studying let me know. Thanks so much!

For this particular task I think you wouldn't be touching DNA/RNA (and honestly if you can avoid doing so I recommend it). If the APIs for generic attributes are already available for Point Cloud objects, then all you need is to add new classes to handle Point Cloud import and export. If you look at usd_hierarchy_iterator.cc, you'll see a spot where an instance of a writer class could be returned (right now OB_POINTCLOUD type objects are set to return nullptr, meaning they are unhandled). The import side would be handled in usd_reader_stage.cc, looking at methods create_reader and create_reader_if_allowed.

If you can get it to the point where you're able to comfortably round-trip even just static point positions, then you'll be about half of the way there and the rest of the bits should fall into place. There's already code for adding Mesh Cache modifiers for animated points, so the "hardest" part will be making sure that the data translates correctly and looks the same on both sides.

The only other thing I'd add is that once you've got it working and you like the numbers you're seeing, I highly recommend also adding to the Python test suite. (I'd avoid doing the tests in C++ now that we have the Python API unless you really, really enjoy pain.) That said, I think following Hans' suggestion above is good, meaning you'd have three patches:

  • Point cloud support
  • Generic attribute support
  • Python USD API test suite

Ping me if you have any questions, and thanks for volunteering to help!

> Ok I look forward to chatting with Charles when the time comes. Is it best to use the #blender-chat USD channel for that? Yes, please @kattkieru me in the chat and I'll appear, as if Final Fantasy summoned. 😆 > I was just looking at the issue conversation over at https://projects.blender.org/blender/blender/pulls/105347 and I see a merged icon at the bottom, does this mean that the patch supporting generic mesh attributes is done? Yes, it was merged. It's a good example of how to handle the colors, and how USD and Blender each deal with them differently. If you look at the import and export sides, you'll see some conversion going on. There's also the interesting wrinkle that USD can specify a constant single color as applying to a whole prim's points, which on the Blender side needs to be expanded into the full generic attribute array. > I'm having a good time going through the orielly book about blender development. I'm focusing on the section about the RNA and Data api since I imagine that's what I'll be needing to interface with after reading the geom usd files. If there's other relevant material I should be studying let me know. Thanks so much! For this particular task I think you wouldn't be touching DNA/RNA (and honestly if you can avoid doing so I recommend it). If the APIs for generic attributes are already available for Point Cloud objects, then all you need is to add new classes to handle Point Cloud import and export. If you look at usd_hierarchy_iterator.cc, you'll see a spot where an instance of a writer class could be returned (right now `OB_POINTCLOUD` type objects are set to return nullptr, meaning they are unhandled). The import side would be handled in usd_reader_stage.cc, looking at methods `create_reader` and `create_reader_if_allowed`. If you can get it to the point where you're able to comfortably round-trip even just static point positions, then you'll be about half of the way there and the rest of the bits should fall into place. There's already code for adding Mesh Cache modifiers for animated points, so the "hardest" part will be making sure that the data translates correctly and looks the same on both sides. The only other thing I'd add is that once you've got it working and you like the numbers you're seeing, I highly recommend also adding to the Python test suite. (I'd avoid doing the tests in C++ now that we have the Python API unless you really, really enjoy pain.) That said, I think following Hans' suggestion above is good, meaning you'd have three patches: - Point cloud support - Generic attribute support - Python USD API test suite Ping me if you have any questions, and thanks for volunteering to help!
👍 2
devin-bayly commented 2023-05-06 18:39:20 +02:00
Author
Copy Link

@CharlesWardlaw This is wonderful! Thanks for saving me the time from trying to fully understand the RNA DNA side. Perhaps one day, but not for this contribution. It's funny, with each week that passes I come up with other projects that this will really help out =D. I'll make sure to reach out to you over the chat when I get stuck.

Good to know that #105347 is about some but not all the same things.

Great reading suggestions, and I'll step through an execution with an existing USD to see how their contents are used.

  • usd_hierarchy_iterator.cc
  • usd_reader_stage.cc

If you can get it to the point where you're able to comfortably round-trip even just static point positions, then you'll be about half of the way there and the rest of the bits should fall into place. There's already code for adding Mesh Cache modifiers for animated points, so the "hardest" part will be making sure that the data translates correctly and looks the same on both sides.

Yea, I hope to figure out the animated stuff after. It is really appealing to have that one day, but static point clouds is enough to work out first. Is the Mesh Cache Modifier how other USD time.sampled mesh properties change from one frame to another in Blender?

The only other thing I'd add is that once you've got it working and you like the numbers you're seeing, I highly recommend also adding to the Python test suite. (I'd avoid doing the tests in C++ now that we have the Python API unless you really, really enjoy pain.) That said, I think following Hans' suggestion above is good, meaning you'd have three patches:

I like that breakdown. The first patch would then require the class that @makowalski mentioned a number of posts back. #106398 (comment)

@CharlesWardlaw This is wonderful! Thanks for saving me the time from trying to fully understand the RNA DNA side. Perhaps one day, but not for this contribution. It's funny, with each week that passes I come up with other projects that this will really help out =D. I'll make sure to reach out to you over the chat when I get stuck. Good to know that https://projects.blender.org/blender/blender/pulls/105347 is about some but not all the same things. Great reading suggestions, and I'll step through an execution with an existing USD to see how their contents are used. * usd_hierarchy_iterator.cc * usd_reader_stage.cc > If you can get it to the point where you're able to comfortably round-trip even just static point positions, then you'll be about half of the way there and the rest of the bits should fall into place. There's already code for adding Mesh Cache modifiers for animated points, so the "hardest" part will be making sure that the data translates correctly and looks the same on both sides. Yea, I hope to figure out the animated stuff after. It is really appealing to have that one day, but static point clouds is enough to work out first. Is the Mesh Cache Modifier how other USD `time.sampled` mesh properties change from one frame to another in Blender? >The only other thing I'd add is that once you've got it working and you like the numbers you're seeing, I highly recommend also adding to the Python test suite. (I'd avoid doing the tests in C++ now that we have the Python API unless you really, really enjoy pain.) That said, I think following Hans' suggestion above is good, meaning you'd have three patches: I like that breakdown. The first patch would then require the class that @makowalski mentioned a number of posts back. https://projects.blender.org/blender/blender/issues/106398#issuecomment-914036
Hans Goudey commented 2023-05-07 00:43:16 +02:00
Member
Copy Link

By the way, the mesh cache modifier won't work for the point cloud object type. That part will probably have to wait for a geometry nodes solution. That's a fine limitation for now though IMO.

By the way, the mesh cache modifier won't work for the point cloud object type. That part will probably have to wait for a geometry nodes solution. That's a fine limitation for now though IMO.
devin-bayly commented 2023-05-08 03:25:49 +02:00
Author
Copy Link

ah good to know. Would that mean that it is going to be a significant undertaking to play back point clouds that change over time? Or just via that specific mesh cache modifier?

ah good to know. Would that mean that it is going to be a significant undertaking to play back point clouds that change over time? Or just via that specific mesh cache modifier?
Hans Goudey commented 2023-05-08 03:30:58 +02:00
Member
Copy Link

Would that mean that it is going to be a significant undertaking to play back point clouds that change over time?

Right, I suppose that might not be possible for now, using the point cloud object type.

>Would that mean that it is going to be a significant undertaking to play back point clouds that change over time? Right, I suppose that might not be possible for now, using the point cloud object type.
devin-bayly commented 2023-05-08 03:40:51 +02:00
Author
Copy Link

@makowalski With regards to understanding the alembic reader, do you have an example alembic file that I can use to explore this reader with? I'm having trouble getting pyalembic built to make one with, and I'm concerned that exporting a particle system from blender might give me one that is too complex ti understand on my own.

@makowalski With regards to understanding the alembic reader, do you have an example alembic file that I can use to explore this reader with? I'm having trouble getting pyalembic built to make one with, and I'm concerned that exporting a particle system from blender might give me one that is too complex ti understand on my own.
devin-bayly commented 2023-05-08 18:28:16 +02:00
Author
Copy Link

Would that mean that it is going to be a significant undertaking to play back point clouds that change over time?

Right, I suppose that might not be possible for now, using the point cloud object type.

@HooglyBoogly oh shoot, ok.

A big part of the contribution motivation for me that I'm supporting a researcher who has timeseries lidar data, and I'm hoping to enable her to be self sufficient in blender for her rendering needs. For that should I rely on an alembic workflow instead? Perhaps we can continue this topic of conversation in the blender chat since this issue might not be the best place for a length discussion of my options.

> >Would that mean that it is going to be a significant undertaking to play back point clouds that change over time? > > Right, I suppose that might not be possible for now, using the point cloud object type. @HooglyBoogly oh shoot, ok. A big part of the contribution motivation for me that I'm supporting a researcher who has timeseries lidar data, and I'm hoping to enable her to be self sufficient in blender for her rendering needs. For that should I rely on an alembic workflow instead? Perhaps we can continue this topic of conversation in the blender chat since this issue might not be the best place for a length discussion of my options.
👍 1
Michael Kowalski commented 2023-05-08 20:47:43 +02:00
Member
Copy Link

@devin-bayly I'm not an expert on exporting to the alembic format, but I'm attaching two trivially simple .abc files, one static and one animating, that are loaded in Blender as meshes by the AbcPointsReader class. The animation is currently possible because the points are represented as meshes that can be loaded by the mesh cache modifier.

If you were to load USD points as meshes, you would take a similar approach in implementing a USD points reader class. But the reader implementation would be somewhat different if you were to translate the USD points to Blender point clouds, as is being suggested.

@kevindietrich supports the Alembic IO code. He might have better examples of Alembic point clouds and could provide more information about the Alembic workflow in Blender.

@devin-bayly I'm not an expert on exporting to the alembic format, but I'm attaching two trivially simple .abc files, one static and one animating, that are loaded in Blender as meshes by the `AbcPointsReader` class. The animation is currently possible because the points are represented as meshes that can be loaded by the mesh cache modifier. If you were to load USD points as meshes, you would take a similar approach in implementing a USD points reader class. But the reader implementation would be somewhat different if you were to translate the USD points to Blender point clouds, as is being suggested. @kevindietrich supports the Alembic IO code. He might have better examples of Alembic point clouds and could provide more information about the Alembic workflow in Blender.
sphere_point_scatter_animated.abc
365 KiB
sphere_point_scatter.abc
33 KiB
Kévin Dietrich commented 2023-05-08 21:26:43 +02:00
Member
Copy Link

Alembic point cloud import support was supposed to be handled by https://archive.blender.org/developer/D11592 which I recently updated, and will be the subject of a pull request in the very short term I guess. USD point cloud import is missing from the patch, as there is currently no support for point clouds in USD.

Would that mean that it is going to be a significant undertaking to play back point clouds that change over time?

Right, I suppose that might not be possible for now, using the point cloud object type.

There is no reason whatsoever (other than purely ideological ones) for the mesh sequence cache modifier to not support point clouds, and therefore point clouds animation. The name "mesh sequence" can change, it is just historical.

Alembic point cloud import support was supposed to be handled by https://archive.blender.org/developer/D11592 which I recently updated, and will be the subject of a pull request in the very short term I guess. USD point cloud import is missing from the patch, as there is currently no support for point clouds in USD. > >Would that mean that it is going to be a significant undertaking to play back point clouds that change over time? > > Right, I suppose that might not be possible for now, using the point cloud object type. There is no reason whatsoever (other than purely ideological ones) for the mesh sequence cache modifier to not support point clouds, and therefore point clouds animation. The name "mesh sequence" can change, it is just historical.
👍 1
Michael Kowalski commented 2023-05-08 23:11:31 +02:00
Member
Copy Link

USD point cloud import is missing from the patch, as there is currently no support for point clouds in USD.

@kevindietrich I wonder if UsdGeomPoints can be considered analogous to point clouds for USD. But perhaps there's a distinction I'm not seeing.

https://openusd.org/release/api/class_usd_geom_points.html

> USD point cloud import is missing from the patch, as there is currently no support for point clouds in USD. @kevindietrich I wonder if `UsdGeomPoints` can be considered analogous to point clouds for USD. But perhaps there's a distinction I'm not seeing. https://openusd.org/release/api/class_usd_geom_points.html
devin-bayly commented 2023-05-14 22:08:48 +02:00
Author
Copy Link

It's been a minute so I'm trying to get a clear picture of what's changed and what's the same in the USD point cloud import via USDGeomPoint implementation since about 2 months ago. If anything in my attempt to summarize is off, please help correct me since all of this is rather new to me.

The initial direction and goals were

  • USDGeomPoint type support in the blender USD importer instead of attempting to bring in faceless/edgeless vertices via the USDmesh importer
  • handling of arbitrary attributes for each point
  • eventual extension to handling time.sampled point clouds

I feel like the additions to this thread lately have been specifically about the support for point clouds that change over time, and I'm unsure whether I understand @kevindietrich when you say

There is no reason whatsoever (other than purely ideological ones) for the mesh sequence cache modifier to not support point clouds, and therefore point clouds animation. The name "mesh sequence" can change, it is just historical.

Does this means that we can make this work without the geometry node workflow that @HooglyBoogly is talking about here #106398 (comment).

It seems we also have the question of whether the USDGeomPoints is the right direction to be going in for the point clouds for USD as @makowalski describes in the entry above. Perhaps the question here is whether we should be wrapping an existing alembic point cloud importer inside a USD file (perhaps I'm way off).

I'm still excited to partake in a contribution, but you may understand my hesitation to start working on anything until it seems clear how we would answer some of these questions.

It's been a minute so I'm trying to get a clear picture of what's changed and what's the same in the USD point cloud import via USDGeomPoint implementation since about 2 months ago. If anything in my attempt to summarize is off, please help correct me since all of this is rather new to me. The initial direction and goals were * USDGeomPoint type support in the blender USD importer instead of attempting to bring in faceless/edgeless vertices via the USDmesh importer * handling of arbitrary attributes for each point * eventual extension to handling time.sampled point clouds I feel like the additions to this thread lately have been specifically about the support for point clouds that change over time, and I'm unsure whether I understand @kevindietrich when you say > There is no reason whatsoever (other than purely ideological ones) for the mesh sequence cache modifier to not support point clouds, and therefore point clouds animation. The name "mesh sequence" can change, it is just historical. Does this means that we can make this work without the geometry node workflow that @HooglyBoogly is talking about here https://projects.blender.org/blender/blender/issues/106398#issuecomment-935876. It seems we also have the question of whether the USDGeomPoints is the right direction to be going in for the `point clouds for USD` as @makowalski describes in the entry above. Perhaps the question here is whether we should be wrapping an existing alembic point cloud importer inside a USD file (perhaps I'm way off). I'm still excited to partake in a contribution, but you may understand my hesitation to start working on anything until it seems clear how we would answer some of these questions.
Kévin Dietrich commented 2023-05-14 23:17:55 +02:00
Member
Copy Link

I just published a branch which updates the patch that I mentioned in my previous post which allows the modifier to output Point Clouds (both for Alembic and USD).

The branch ("abc_usd_geometry_sets") is here https://projects.blender.org/kevindietrich/blender/src/branch/abc_usd_geometry_sets

You can use this branch as a starter. All you have to do is add support for reading a usdGeomPoint as a Blender PointCloud in the USD importer (+ attributes). Animation support is already there, you can simply look up data based on the current time.

usdGeomPoints should be the right object type; my previous comment was a bit cryptic, I meant that our USD implementation does not support point clouds, not USD per se.

Does this means that we can make this work without the geometry node workflow that @HooglyBoogly is talking about here #106398 (comment).

Yes. The only thing preventing a modifier to be added to a point cloud object other than a geometry nodes modifier is this condition : https://projects.blender.org/blender/blender/src/branch/main/source/blender/blenkernel/intern/object.cc#L1456
(which is modified in my branch).

I just published a branch which updates the patch that I mentioned in my previous post which allows the modifier to output Point Clouds (both for Alembic and USD). The branch ("abc_usd_geometry_sets") is here https://projects.blender.org/kevindietrich/blender/src/branch/abc_usd_geometry_sets You can use this branch as a starter. All you have to do is add support for reading a **usdGeomPoint** as a Blender PointCloud in the USD importer (+ attributes). Animation support is already there, you can simply look up data based on the current time. **usdGeomPoints** should be the right object type; my previous comment was a bit cryptic, I meant that our USD implementation does not support point clouds, not USD per se. > Does this means that we can make this work without the geometry node workflow that @HooglyBoogly is talking about here https://projects.blender.org/blender/blender/issues/106398#issuecomment-935876. Yes. The only thing preventing a modifier to be added to a point cloud object other than a geometry nodes modifier is this condition : https://projects.blender.org/blender/blender/src/branch/main/source/blender/blenkernel/intern/object.cc#L1456 (which is modified in my branch).
devin-bayly commented 2023-05-15 18:50:26 +02:00
Author
Copy Link

Fantastic, thank you so much @kevindietrich !

I feel invigorated to begin with this work. I think I'll start looking through this branch and make sure I come back with questions.

Fantastic, thank you so much @kevindietrich ! I feel invigorated to begin with this work. I think I'll start looking through this branch and make sure I come back with questions.
devin-bayly commented 2023-05-27 00:43:21 +02:00
Author
Copy Link

@kevindietrich hi again. I went ahead and tried to get my hands on your branch at https://projects.blender.org/kevindietrich/blender/src/branch/abc_usd_geometry_sets, but my build seems to be failing and I"m not entirely sure if I'm missing a dependency or something.

I'm attaching the build log I created from my screen session here. Unfortunately it missed some of the output from git pull kev abc_usd_geometry_sets but you can see the steps I took after that.

https://gist.github.com/DevinBayly/73c0f64de0e9bd17ecda8db6a1daa95f

@kevindietrich hi again. I went ahead and tried to get my hands on your branch at https://projects.blender.org/kevindietrich/blender/src/branch/abc_usd_geometry_sets, but my build seems to be failing and I"m not entirely sure if I'm missing a dependency or something. I'm attaching the build log I created from my screen session here. Unfortunately it missed some of the output from `git pull kev abc_usd_geometry_sets` but you can see the steps I took after that. https://gist.github.com/DevinBayly/73c0f64de0e9bd17ecda8db6a1daa95f
devin-bayly commented 2023-06-02 19:37:42 +02:00
Author
Copy Link

It seems like the above build error stems from adding one too many arguments to the function BKE_pointcloud_nomain_to_pointcloud in the file source/blender/io/alembic/intern/abc_reader_points.cc. I'm going to remove the true from d028f856a4/source/blender/io/alembic/intern/abc_reader_points.cc (L78) and see what happens.

It seems like the above build error stems from adding one too many arguments to the function `BKE_pointcloud_nomain_to_pointcloud` in the file `source/blender/io/alembic/intern/abc_reader_points.cc`. I'm going to remove the `true` from https://projects.blender.org/kevindietrich/blender/src/commit/d028f856a4f12436a3e64f64090eaeeb7b5c6891/source/blender/io/alembic/intern/abc_reader_points.cc#L78 and see what happens.
devin-bayly commented 2023-06-02 19:46:45 +02:00
Author
Copy Link

I'll just update here that @HooglyBoogly helped me understand in blender chat that the third argument is not necessary.

Yes, just remove the third argument 🙂 It became unnecessary after implicit sharing was added for attributes, so I removed it

Onward with the process!

I'll just update here that @HooglyBoogly helped me understand in blender chat that the third argument is not necessary. > Yes, just remove the third argument 🙂 It became unnecessary after implicit sharing was added for attributes, so I removed it Onward with the process!
devin-bayly commented 2023-08-14 20:32:13 +02:00
Author
Copy Link

I have been so infrequent in attending to this issue, apologies! I'm interested in picking things back up at this point, has any of the USD Import landscape changed significantly from back a couple months ago? Do I need to refactor my plans at all? Thanks for the info y'all

I have been so infrequent in attending to this issue, apologies! I'm interested in picking things back up at this point, has any of the USD Import landscape changed significantly from back a couple months ago? Do I need to refactor my plans at all? Thanks for the info y'all
Kévin Dietrich commented 2023-08-14 20:53:32 +02:00
Member
Copy Link

@devin-bayly There were some minor conflicting changes recently with the branch I shared with you for the starting code but nothing drastic. I updated the branch with the latest changes from main just in case you might need it as a reference again.

@devin-bayly There were some minor conflicting changes recently with the branch I shared with you for the starting code but nothing drastic. I updated the branch with the latest changes from main just in case you might need it as a reference again.
devin-bayly commented 2023-08-14 20:55:57 +02:00
Author
Copy Link

@kevindietrich Thanks so much! I recently figured out how to walk the USD stage with a geompoint type in vanilla C++ USD so I feel like the time is ripe to see what happens when I try to incorporate some of that code in Blender following the mechanism laid out in your Alembic importer.

@kevindietrich Thanks so much! I recently figured out how to walk the USD stage with a geompoint type in vanilla C++ USD so I feel like the time is ripe to see what happens when I try to incorporate some of that code in Blender following the mechanism laid out in your Alembic importer.
Michael Kowalski commented 2023-08-14 21:05:48 +02:00
Member
Copy Link

I feel like the time is ripe to see what happens when I try to incorporate some of that code in Blender following the mechanism laid out in your Alembic importer.

@devin-bayly You shouldn't need to do any of your own stage traversal, as far as I know. That's all taken care of in the framework that's already in place for instantiating USD "readers" in the USD import code. I can help answer any questions you might have about implementing a new USD reader class and could even help prototype the basics of a reader class that would be a starting point for you to add your code, to save you some time. Please let me know if you'd like me to do that.

> I feel like the time is ripe to see what happens when I try to incorporate some of that code in Blender following the mechanism laid out in your Alembic importer. @devin-bayly You shouldn't need to do any of your own stage traversal, as far as I know. That's all taken care of in the framework that's already in place for instantiating USD "readers" in the USD import code. I can help answer any questions you might have about implementing a new USD reader class and could even help prototype the basics of a reader class that would be a starting point for you to add your code, to save you some time. Please let me know if you'd like me to do that.
devin-bayly commented 2023-08-14 21:14:41 +02:00
Author
Copy Link

@makowalski
oh, right! I think we had discussed that before. I think your previous suggestion #106398 (comment) is what I'll do first "checking into some of the other readers". Because then I'll have a better sense of what gets included in reader classes, and how they make use of the code in place for things like traversal.

Definitely will take you up on both of those things probably in about a week, but I want to make sure I have done some self-guided reading so I can use your time more efficiently first.

@makowalski oh, right! I think we had discussed that before. I think your previous suggestion https://projects.blender.org/blender/blender/issues/106398#issuecomment-930433 is what I'll do first "checking into some of the other readers". Because then I'll have a better sense of what gets included in reader classes, and how they make use of the code in place for things like traversal. Definitely will take you up on both of those things probably in about a week, but I want to make sure I have done some self-guided reading so I can use your time more efficiently first.
👍 1
devin-bayly commented 2023-08-23 23:52:32 +02:00
Author
Copy Link

In the spirit of providing a record of useful information in here I wanted to reflect some information in this issue from @makowalski . I was trying to wrap my head around where the reader classes get instantiated, and the information was provided.

The USDReaderStage class creates the readers in this function:

https://projects.blender.org/blender/blender/src/branch/main/source/blender/io/usd/intern/usd_reader_stage.cc#L78

The stage reader itself is instantiated here:

https://projects.blender.org/blender/blender/src/branch/main/source/blender/io/usd/intern/usd_capi_import.cc#L242
👀
1
In the spirit of providing a record of useful information in here I wanted to reflect some information in this issue from @makowalski . I was trying to wrap my head around where the reader classes get instantiated, and the information was provided. ``` The USDReaderStage class creates the readers in this function: https://projects.blender.org/blender/blender/src/branch/main/source/blender/io/usd/intern/usd_reader_stage.cc#L78 The stage reader itself is instantiated here: https://projects.blender.org/blender/blender/src/branch/main/source/blender/io/usd/intern/usd_capi_import.cc#L242 👀 1 ```
devin-bayly commented 2023-08-23 23:54:19 +02:00
Author
Copy Link

So if I'm following some of the code correctly it looks like perhaps we will be adding a section also to the 7c2dc5183d/source/blender/io/usd/intern/usd_reader_stage.cc (L78) create_reader_if_allowed for the USDGeomPoint type, and then this will call the constructor of the reader class?

So if I'm following some of the code correctly it looks like perhaps we will be adding a section also to the https://projects.blender.org/blender/blender/src/commit/7c2dc5183d03d867c100b29059fca83ba9dd8451/source/blender/io/usd/intern/usd_reader_stage.cc#L78 `create_reader_if_allowed` for the USDGeomPoint type, and then this will call the constructor of the reader class?
Michael Kowalski commented 2023-08-24 00:10:11 +02:00
Member
Copy Link

So if I'm following some of the code correctly it looks like perhaps we will be adding a section also to the 7c2dc5183d/source/blender/io/usd/intern/usd_reader_stage.cc (L78) create_reader_if_allowed for the USDGeomPoint type, and then this will call the constructor of the reader class?

Yes, that's exactly right! (I can provide a shell implementation of this so you can fill out the rest of the code, as we discussed.)

> So if I'm following some of the code correctly it looks like perhaps we will be adding a section also to the https://projects.blender.org/blender/blender/src/commit/7c2dc5183d03d867c100b29059fca83ba9dd8451/source/blender/io/usd/intern/usd_reader_stage.cc#L78 `create_reader_if_allowed` for the USDGeomPoint type, and then this will call the constructor of the reader class? Yes, that's exactly right! (I can provide a shell implementation of this so you can fill out the rest of the code, as we discussed.)
devin-bayly commented 2023-08-24 00:11:42 +02:00
Author
Copy Link

Great, thanks for the feedback! ok, just slowly unpacking more of the code on my own time. No rush!

Great, thanks for the feedback! ok, just slowly unpacking more of the code on my own time. No rush!
Michael Kowalski commented 2023-08-25 01:23:15 +02:00
Member
Copy Link

Hi @devin-bayly. Starting from Kevin's abc_usd_geometry_sets branch, I added a placeholder implementation of a USDPointsReader class here:

https://projects.blender.org/makowalski/blender/src/branch/abc_usd_geometry_sets

Please see the description for this commit:

84c72a8383

The reader only allocates the point cloud without setting any attributes, but hopefully this will be a reasonable
starting point for your development. You'll mostly need to fill out functionality In USDPointsReader::read_geometry().
Please see Kevin's implementation of AbcPointsReader for an example of creating the point cloud.

I'm also attaching two USDs containing point clouds, one static and one animated, derived from Kevin's ABC point
cloud example.

@kevindietrich for visibility.

Hi @devin-bayly. Starting from Kevin's `abc_usd_geometry_sets` branch, I added a placeholder implementation of a `USDPointsReader` class here: https://projects.blender.org/makowalski/blender/src/branch/abc_usd_geometry_sets Please see the description for this commit: https://projects.blender.org/makowalski/blender/commit/84c72a83836200069343f6b6dbf43849e8e13514 The reader only allocates the point cloud without setting any attributes, but hopefully this will be a reasonable starting point for your development. You'll mostly need to fill out functionality In `USDPointsReader::read_geometry()`. Please see Kevin's implementation of `AbcPointsReader` for an example of creating the point cloud. I'm also attaching two USDs containing point clouds, one static and one animated, derived from Kevin's ABC point cloud example. @kevindietrich for visibility.
pointsTestStatic.usda
17 KiB
pointsTest.usda
459 KiB
devin-bayly commented 2023-08-25 16:34:02 +02:00
Author
Copy Link

Incredible! @makowalski , this is going to launch me forward on this task. Thanks so much for the support.

Incredible! @makowalski , this is going to launch me forward on this task. Thanks so much for the support.
Michael Kowalski commented 2023-08-25 18:03:53 +02:00
Member
Copy Link

Incredible! @makowalski , this is going to launch me forward on this task. Thanks so much for the support.

You're very welcome. And thank you for the initiative you've taken to contribute this new feature. Please let me know if you have questions.

> Incredible! @makowalski , this is going to launch me forward on this task. Thanks so much for the support. You're very welcome. And thank you for the initiative you've taken to contribute this new feature. Please let me know if you have questions.
devin-bayly commented 2023-09-01 18:29:07 +02:00
Author
Copy Link

Wow you're outline was like 90% of the code needed. I just got the static usda file to load!

I'm going to try another example from a lidar scan I took. Then I'll try to get the timesampling going which no doubt will have some subtle problems.

Then I'll figure out how to share the code (super small actual contribution at this point haha).

Wow you're outline was like 90% of the code needed. I just got the static usda file to load! I'm going to try another example from a lidar scan I took. Then I'll try to get the timesampling going which no doubt will have some subtle problems. Then I'll figure out how to share the code (super small actual contribution at this point haha).
devin-bayly commented 2023-09-01 18:49:44 +02:00
Author
Copy Link

Incredible! Zero other changes and the point cloud updates correctly to whatever time in the animation I'm trying to view!

Incredible! Zero other changes and the point cloud updates correctly to whatever time in the animation I'm trying to view!
devin-bayly commented 2023-09-01 19:22:02 +02:00
Author
Copy Link

I guess the next step would be trying to bring in custom attributes like color and such now right?

I guess the next step would be trying to bring in custom attributes like color and such now right?
Screenshot from 2023-09-01 10-20-59.png
1.7 MiB
Screencast from 09-01-2023 10:10:21 AM.webm
6.5 MiB
Screenshot from 2023-09-01 10-20-59.png
devin-bayly commented 2023-09-01 19:24:55 +02:00
Author
Copy Link

I should note that the clunkiness of the performance in that video rests squarely with the remote desktop connection I have, and also that I'm using 16 cores on a pretty old HPC node where I've been developing stuff.

I should note that the clunkiness of the performance in that video rests squarely with the remote desktop connection I have, and also that I'm using 16 cores on a pretty old HPC node where I've been developing stuff.
Michael Kowalski commented 2023-09-02 00:22:45 +02:00
Member
Copy Link

@devin-bayly Awesome progress! Nice work! You should share these results on the USD Blender chat channel.

As far as reviewing, I would create a pull request for this, when you feel the time is right. Here are a couple of pages with instructions:

https://wiki.blender.org/wiki/Process/Contributing_Code
https://wiki.blender.org/wiki/Tools/Pull_Requests

Yes, the next step would be supporting attributes. For that, you could take a look at what the USD mesh reader code does. It might make sense to move some of the attribute conversion code out of the mesh reader implementation into shared functions that can be used by the points reader as well, but I haven't thought about this design yet. Initially, as you're experimenting and learning the attributes API, I think it would be fine for you to duplicate the code for the points reader as needed and we can think about consolidating later.

@devin-bayly Awesome progress! Nice work! You should share these results on the USD Blender chat channel. As far as reviewing, I would create a pull request for this, when you feel the time is right. Here are a couple of pages with instructions: https://wiki.blender.org/wiki/Process/Contributing_Code https://wiki.blender.org/wiki/Tools/Pull_Requests Yes, the next step would be supporting attributes. For that, you could take a look at what the USD mesh reader code does. It might make sense to move some of the attribute conversion code out of the mesh reader implementation into shared functions that can be used by the points reader as well, but I haven't thought about this design yet. Initially, as you're experimenting and learning the attributes API, I think it would be fine for you to duplicate the code for the points reader as needed and we can think about consolidating later.
devin-bayly commented 2023-09-02 00:26:34 +02:00
Author
Copy Link

Haha thanks for the praise, it's really all you! I'll definitely follow up on that suggestion to read what the mesh reader is doing for the attributes. I'll also wait on the PR until I've don't a similar thing that you did where you share a link for me to look at your fork of Kevin's work. That way I can get some feedback from you about what I've got written before using anyone's time to review a PR.

Haha thanks for the praise, it's really all you! I'll definitely follow up on that suggestion to read what the mesh reader is doing for the attributes. I'll also wait on the PR until I've don't a similar thing that you did where you share a link for me to look at your fork of Kevin's work. That way I can get some feedback from you about what I've got written before using anyone's time to review a PR.
👍 1
Bastien Montagne added this to the USD project 2023-09-14 23:18:58 +02:00
Bastien Montagne removed reference blender-v3.5-release 2023-09-14 23:19:06 +02:00
devin-bayly commented 2023-09-27 01:53:20 +02:00
Author
Copy Link

I'm going to paste some of the conversations I've been having in the blender chat here

September 21, 2023
devin-bayly17:47
makowalski I'm planning to add in my custom attribute code tomorrow, but I was wondering whether I could quickly check something. I'm looking to other parts of the io system to give me hints, but it looks like the only example from the alembic importer was for point radius values. https://projects.blender.org/makowalski/blender/src/commit/84c72a83836200069343f6b6dbf43849e8e13514/source/blender/io/alembic/intern/abc_reader_points.cc#L189

Am I right in understanding that if I can find a way to have usd tell me what attributes are stored then I should make a bke::SpanAttributeWriter for each of them, selecting the right type of the attribute writer for each (like points would be bke::SpanAttributeWriter<float3> and floats are bke::SpanAttributeWriter<float>?
September 25, 2023
makowalski09:34
devin-bayly Sorry for the late reply! I have a deadline this week and haven't been keeping up with the threads as much as I'd like to.

Yes, you are correct. There are many examples of this in usd_reader_mesh.cc. For instance:

https://projects.blender.org/blender/blender/src/branch/main/source/blender/io/usd/intern/usd_reader_mesh.cc#L727

The code in that file may be hard to follow, because much of it is templated and abstracted away. If you have specific question, please let me know.

Charles Wardlaw is a good source of information, too, as he wrote most of the USD mesh attribute conversion code.
devin-bayly10:22
not to worry! I'm not racing through this stuff very quickly. Perhaps I can ask either of you a followup. Is there a prewritten method on the usd wrapper that allows me to query for all attributes on a particular primitive? I'm asking mainly because I tried to use https://openusd.org/release/api/class_usd_geom_primvars_a_p_i.html#a2336d8d750d52f1a8950abe5cfafb75a and https://openusd.org/release/api/class_usd_geom_points.html#a7c62fe4bca24edb5beae756618bf602f to no avail for an attribute that I created by adding some information in a text editor to a .usda

In https://projects.blender.org/blender/blender/src/branch/main/source/blender/io/usd/intern/usd_reader_mesh.cc#L727 that you (@makowalski) shared, it appears that the querying for attributes is performed on a blender mesh object, not a USD representation of the mesh right? I guess what I'm trying to figure out is whether there's a method like attributes_for_write() or not for me to use when reading in a USDGeomPoint type that will get me all the attributes to add via bke::SpanAttributeWriter

I'll also copy these messages over to the official feature issue too when I have a moment
makowalski14:03
devin-bayly Calling UsdGeomPrimvarsAPI::GetPrimvars() or the equivalent on a geom points prim should work, I believe.

https://openusd.org/release/api/class_usd_geom_primvars_a_p_i.html#a2336d8d750d52f1a8950abe5cfafb75a

Can you provide a code snippet of how you're calling this (maybe on the issue page)?

Charles Wardlaw for visibility.
:roll_safe:
1
devin-bayly17:22
will do!

This section can be summarized as my attempts to understand how to access custom primitive information in a usdgeom file.

I wrote the following code to experiment with loading up the custom primitives that I added to a file, but in the text that is printed to the screen for debugging I don't see the custom variables that I've added by hand.

here's the output from running import usd


attr: visibility
attr: purpose
attr: xformOpOrder
attr: extent
attr: primvars:displayColor
attr: primvars:displayOpacity
attr: doubleSided
attr: orientation
attr: points
attr: velocities
attr: accelerationsfile:///home/yara/Downloads/test.usda

attr: normals
attr: widths
attr: ids
Custom Attributes:
primvars:displayColor (color3f[])
primvars:displayOpacity (float[])
USD import of '/home/u4/baylyd/xdisk/blender_usd_experiments/blender_building/test.usda' took 303.6 ms

with this usd file below that I added a double customvar line to. Here's my contribution fork, and the most recent commits are the modifications that show my attempts https://projects.blender.org/devin-bayly/blender/commits/branch/abc_usd_geometry_sets

Is there a different way to iterate over the custom attributes that are present in a USDGeomType ?

I'm going to paste some of the conversations I've been having in the blender chat here ``` September 21, 2023 devin-bayly17:47 makowalski I'm planning to add in my custom attribute code tomorrow, but I was wondering whether I could quickly check something. I'm looking to other parts of the io system to give me hints, but it looks like the only example from the alembic importer was for point radius values. https://projects.blender.org/makowalski/blender/src/commit/84c72a83836200069343f6b6dbf43849e8e13514/source/blender/io/alembic/intern/abc_reader_points.cc#L189 Am I right in understanding that if I can find a way to have usd tell me what attributes are stored then I should make a bke::SpanAttributeWriter for each of them, selecting the right type of the attribute writer for each (like points would be bke::SpanAttributeWriter<float3> and floats are bke::SpanAttributeWriter<float>? September 25, 2023 makowalski09:34 devin-bayly Sorry for the late reply! I have a deadline this week and haven't been keeping up with the threads as much as I'd like to. Yes, you are correct. There are many examples of this in usd_reader_mesh.cc. For instance: https://projects.blender.org/blender/blender/src/branch/main/source/blender/io/usd/intern/usd_reader_mesh.cc#L727 The code in that file may be hard to follow, because much of it is templated and abstracted away. If you have specific question, please let me know. Charles Wardlaw is a good source of information, too, as he wrote most of the USD mesh attribute conversion code. devin-bayly10:22 not to worry! I'm not racing through this stuff very quickly. Perhaps I can ask either of you a followup. Is there a prewritten method on the usd wrapper that allows me to query for all attributes on a particular primitive? I'm asking mainly because I tried to use https://openusd.org/release/api/class_usd_geom_primvars_a_p_i.html#a2336d8d750d52f1a8950abe5cfafb75a and https://openusd.org/release/api/class_usd_geom_points.html#a7c62fe4bca24edb5beae756618bf602f to no avail for an attribute that I created by adding some information in a text editor to a .usda In https://projects.blender.org/blender/blender/src/branch/main/source/blender/io/usd/intern/usd_reader_mesh.cc#L727 that you (@makowalski) shared, it appears that the querying for attributes is performed on a blender mesh object, not a USD representation of the mesh right? I guess what I'm trying to figure out is whether there's a method like attributes_for_write() or not for me to use when reading in a USDGeomPoint type that will get me all the attributes to add via bke::SpanAttributeWriter I'll also copy these messages over to the official feature issue too when I have a moment makowalski14:03 devin-bayly Calling UsdGeomPrimvarsAPI::GetPrimvars() or the equivalent on a geom points prim should work, I believe. https://openusd.org/release/api/class_usd_geom_primvars_a_p_i.html#a2336d8d750d52f1a8950abe5cfafb75a Can you provide a code snippet of how you're calling this (maybe on the issue page)? Charles Wardlaw for visibility. :roll_safe: 1 devin-bayly17:22 will do! ``` This section can be summarized as my attempts to understand how to access custom primitive information in a usdgeom file. I wrote the following code to experiment with loading up the custom primitives that I added to a file, but in the text that is printed to the screen for debugging I don't see the custom variables that I've added by hand. here's the output from running import usd ``` attr: visibility attr: purpose attr: xformOpOrder attr: extent attr: primvars:displayColor attr: primvars:displayOpacity attr: doubleSided attr: orientation attr: points attr: velocities attr: accelerationsfile:///home/yara/Downloads/test.usda attr: normals attr: widths attr: ids Custom Attributes: primvars:displayColor (color3f[]) primvars:displayOpacity (float[]) USD import of '/home/u4/baylyd/xdisk/blender_usd_experiments/blender_building/test.usda' took 303.6 ms ``` with this usd file below that I added a double customvar line to. Here's my contribution fork, and the most recent commits are the modifications that show my attempts https://projects.blender.org/devin-bayly/blender/commits/branch/abc_usd_geometry_sets Is there a different way to iterate over the custom attributes that are present in a USDGeomType ?
test.usda
17 KiB
devin-bayly commented 2023-10-03 22:49:37 +02:00
Author
Copy Link

I wanted to chime back in to say that GetProperties is doing what I was hoping, but I'm now struggling how to get a value out of a property when I've already checked that it is custom. It seems like the USD GetAttribute then Get for a value works but they expect me to declare a time value. https://openusd.org/release/api/class_usd_attribute.html#a9d41bc223be86408ba7d7f74df7c35a9

This I think causes a segfault when I attempt to .Get(0) on a custom property that doesn't have more than one value.

#include <iostream>
#include <pxr/usd/usd/primRange.h>
#include <pxr/usd/usd/stage.h>
#include <pxr/usd/usdGeom/pointBased.h>
#include <pxr/usd/usdGeom/points.h>
#include <pxr/usd/usd/property.h>

int main()
{
    // Path to the USD file
    std::string filePath = "test_custom.usda";

    // Create a USD stage
    pxr::UsdStageRefPtr stage = pxr::UsdStage::Open(filePath);

    if (!stage) {
        std::cerr << "Failed to open USD stage." << std::endl;
        return 1;
    }

    // Get the root layer of the USD stage
    pxr::SdfLayerHandle rootLayer = stage->GetRootLayer();

    // Iterate over the prims in the stage
    for (const pxr::UsdPrim& prim : stage->Traverse()) {
        // Check if the prim is a point-based primitive
        if (prim.IsA<pxr::UsdGeomPoints>()) {

            std::vector<pxr::UsdProperty> props = prim.GetProperties();
            for (auto & prop: props) {
                std::cout << prop.GetBaseName() << std::endl;
                // try to get the prop value
                auto attr = prim.GetAttribute(prop.GetBaseName());
                if (attr.HasValue()) {
                // get the time samples to know how to look up
                std::vector<double> times;
                auto ts = attr.GetTimeSamples(& times);
                std::cout << times.size() << std::endl;
/* this returns 0  in my custom attribute case */
/* ERROR */
                std::cout << attr.Get(0) << std::endl;
                }
            }

        }
    }

    return 0;
}

I'm running this code with the following test usda file

I wanted to chime back in to say that `GetProperties` is doing what I was hoping, but I'm now struggling how to get a value out of a property when I've already checked that it is custom. It seems like the USD `GetAttribute` then `Get` for a value works but they expect me to declare a time value. https://openusd.org/release/api/class_usd_attribute.html#a9d41bc223be86408ba7d7f74df7c35a9 This I think causes a segfault when I attempt to `.Get(0)` on a custom property that doesn't have more than one value. ```Cpp #include <iostream> #include <pxr/usd/usd/primRange.h> #include <pxr/usd/usd/stage.h> #include <pxr/usd/usdGeom/pointBased.h> #include <pxr/usd/usdGeom/points.h> #include <pxr/usd/usd/property.h> int main() { // Path to the USD file std::string filePath = "test_custom.usda"; // Create a USD stage pxr::UsdStageRefPtr stage = pxr::UsdStage::Open(filePath); if (!stage) { std::cerr << "Failed to open USD stage." << std::endl; return 1; } // Get the root layer of the USD stage pxr::SdfLayerHandle rootLayer = stage->GetRootLayer(); // Iterate over the prims in the stage for (const pxr::UsdPrim& prim : stage->Traverse()) { // Check if the prim is a point-based primitive if (prim.IsA<pxr::UsdGeomPoints>()) { std::vector<pxr::UsdProperty> props = prim.GetProperties(); for (auto & prop: props) { std::cout << prop.GetBaseName() << std::endl; // try to get the prop value auto attr = prim.GetAttribute(prop.GetBaseName()); if (attr.HasValue()) { // get the time samples to know how to look up std::vector<double> times; auto ts = attr.GetTimeSamples(& times); std::cout << times.size() << std::endl; /* this returns 0 in my custom attribute case */ /* ERROR */ std::cout << attr.Get(0) << std::endl; } } } } return 0; } ``` I'm running this code with the following test usda file
test_custom.usda
17 KiB
Michael Kowalski commented 2023-10-04 02:46:35 +02:00
Member
Copy Link

@devin-bayly Thanks for the update. I'll have some feedback, suggestions and example code for you tomorrow.

@devin-bayly Thanks for the update. I'll have some feedback, suggestions and example code for you tomorrow.
devin-bayly commented 2023-10-04 19:04:59 +02:00
Author
Copy Link

Sounds good, thanks so much!

Sounds good, thanks so much!
Michael Kowalski commented 2023-10-05 03:47:27 +02:00
Member
Copy Link

@devin-bayly As an initial comment, please keep in mind that you will typically be converting USD primvars to Blender attributes. I think you added a custom property to the USD, which is different from a primvar. Here are a couple of useful links to explain the concepts:

https://openusd.org/release/glossary.html#usdglossary-primvar
https://openusd.org/dev/api/class_usd_geom_primvar.html#details

Primvars are array values, where the number of entries depends on the interpolation type (as described in the docs I pointed you to). For example, for vertex interpolation, there would be one entry per point. For constant interpolation, the array would have a single entry for the entire point cloud, indicating that every point has the same value. Other interpolation types are possible, depending on the type of geometry.

I'm attaching a point cloud dumped from Houdini that has two primvars: foo (float) and displayColor (color3f).

Here is an example of iterating over the primvars:

  #include <pxr/usd/usdGeom/primvarsAPI.h>

  pxr::UsdGeomPrimvarsAPI pv_api = pxr::UsdGeomPrimvarsAPI(points_prim_);
  std::vector<pxr::UsdGeomPrimvar> primvars = pv_api.GetPrimvarsWithValues();

  for (const pxr::UsdGeomPrimvar &pv : primvars) {
     const pxr::SdfValueTypeName type = pv.GetTypeName();
     const pxr::TfToken interp = pv.GetInterpolation();
     const pxr::TfToken name = pv.StripPrimvarsName(pv.GetPrimvarName());

     printf("%s %s %s\n", name.GetText(), type.GetAsToken().GetText(), interp.GetText());
  }

I'll try to provide an example of converting primvars in a separate comment, but, as mentioned earlier, usd_reader_mesh.cc has many examples of such conversions.

@devin-bayly As an initial comment, please keep in mind that you will typically be converting USD `primvars` to Blender attributes. I think you added a custom property to the USD, which is different from a `primvar`. Here are a couple of useful links to explain the concepts: https://openusd.org/release/glossary.html#usdglossary-primvar https://openusd.org/dev/api/class_usd_geom_primvar.html#details Primvars are array values, where the number of entries depends on the interpolation type (as described in the docs I pointed you to). For example, for `vertex` interpolation, there would be one entry per point. For `constant` interpolation, the array would have a single entry for the entire point cloud, indicating that every point has the same value. Other interpolation types are possible, depending on the type of geometry. I'm attaching a point cloud dumped from Houdini that has two primvars: `foo` (float) and `displayColor` (color3f). Here is an example of iterating over the primvars: ``` #include <pxr/usd/usdGeom/primvarsAPI.h> pxr::UsdGeomPrimvarsAPI pv_api = pxr::UsdGeomPrimvarsAPI(points_prim_); std::vector<pxr::UsdGeomPrimvar> primvars = pv_api.GetPrimvarsWithValues(); for (const pxr::UsdGeomPrimvar &pv : primvars) { const pxr::SdfValueTypeName type = pv.GetTypeName(); const pxr::TfToken interp = pv.GetInterpolation(); const pxr::TfToken name = pv.StripPrimvarsName(pv.GetPrimvarName()); printf("%s %s %s\n", name.GetText(), type.GetAsToken().GetText(), interp.GetText()); } ``` I'll try to provide an example of converting primvars in a separate comment, but, as mentioned earlier, `usd_reader_mesh.cc` has many examples of such conversions.
pointsTestColors.usda
709 KiB
pointsTestColorsStatic.usda
29 KiB
devin-bayly commented 2023-10-05 04:23:11 +02:00
Author
Copy Link

Ah yes, this is totally me not understanding the distinction between those things. I also appreciate the quickness you've helped me course correct after I started to look at properties instead.

Thanks for those test files also, I'll add that to my blender development environment and try importing. I think this will also get me over the hump of creating blender attributes from the primvars, and then I can start sharing some more of my code perhaps in the form of a PR (or whatever is appropriate for the first draft of this feature).

Ah yes, this is totally me not understanding the distinction between those things. I also appreciate the quickness you've helped me course correct after I started to look at properties instead. Thanks for those test files also, I'll add that to my blender development environment and try importing. I think this will also get me over the hump of creating blender attributes from the primvars, and then I can start sharing some more of my code perhaps in the form of a PR (or whatever is appropriate for the first draft of this feature).
Michael Kowalski commented 2023-10-05 05:14:32 +02:00
Member
Copy Link

Here is the same loop expanded to read color primvars. This is just example code, isn't full tested, and doesn't handle all data and interpolation types, but is hopefully enough to allow you to explore further.

#include <pxr/usd/usdGeom/primvarsAPI.h>

#include <pxr/base/vt/array.h>
#include <pxr/base/vt/types.h>
#include <pxr/base/vt/value.h>


pxr::UsdGeomPrimvarsAPI pv_api = pxr::UsdGeomPrimvarsAPI(points_prim_);
  std::vector<pxr::UsdGeomPrimvar> primvars = pv_api.GetPrimvarsWithValues();

   for (const pxr::UsdGeomPrimvar &pv : primvars) {
    if (!pv.HasValue()) {
      continue;
    }
    const pxr::SdfValueTypeName type = pv.GetTypeName();
    const pxr::TfToken interp = pv.GetInterpolation();
    const pxr::TfToken name = pv.StripPrimvarsName(pv.GetPrimvarName());

    printf("%s %s %s\n", name.GetText(), type.GetAsToken().GetText(), interp.GetText());

    /* Just handle float colors with vertex interpolation for now.
     * This is not sufficient for production, as we will also need to handle all
     * color types (doubles and half) as well as constant interpolation.
     * See usd_read_mesh.cc for examples. */
    if (type == pxr::SdfValueTypeNames->Color3fArray && interp == pxr::UsdGeomTokens->vertex) {

      bke::SpanAttributeWriter<ColorGeometry4f> color_writer = point_cloud->attributes_for_write()
                       .lookup_or_add_for_write_only_span<ColorGeometry4f>(name.GetText(), ATTR_DOMAIN_POINT);
      if (!color_writer) {
        printf("Couldn't create writer for color %s\n", name.GetText());
        continue;
      }

      pxr::VtVec3fArray colors;
      if (!pv.ComputeFlattened(&colors, params.motion_sample_time)) {
        printf("Couldn't compute flattened color primvar %s\n", name.GetText());
        continue;
      }

      for (int i = 0; i < colors.size(); ++i) {
        const pxr::GfVec3f &usd_color = colors[i];
        color_writer.span[i] = ColorGeometry4f(
            usd_color[0], usd_color[1], usd_color[2], 1.0f);
      }

      color_writer.finish();
    }
  }
Here is the same loop expanded to read color primvars. This is just example code, isn't full tested, and doesn't handle all data and interpolation types, but is hopefully enough to allow you to explore further. ``` #include <pxr/usd/usdGeom/primvarsAPI.h> #include <pxr/base/vt/array.h> #include <pxr/base/vt/types.h> #include <pxr/base/vt/value.h> pxr::UsdGeomPrimvarsAPI pv_api = pxr::UsdGeomPrimvarsAPI(points_prim_); std::vector<pxr::UsdGeomPrimvar> primvars = pv_api.GetPrimvarsWithValues(); for (const pxr::UsdGeomPrimvar &pv : primvars) { if (!pv.HasValue()) { continue; } const pxr::SdfValueTypeName type = pv.GetTypeName(); const pxr::TfToken interp = pv.GetInterpolation(); const pxr::TfToken name = pv.StripPrimvarsName(pv.GetPrimvarName()); printf("%s %s %s\n", name.GetText(), type.GetAsToken().GetText(), interp.GetText()); /* Just handle float colors with vertex interpolation for now. * This is not sufficient for production, as we will also need to handle all * color types (doubles and half) as well as constant interpolation. * See usd_read_mesh.cc for examples. */ if (type == pxr::SdfValueTypeNames->Color3fArray && interp == pxr::UsdGeomTokens->vertex) { bke::SpanAttributeWriter<ColorGeometry4f> color_writer = point_cloud->attributes_for_write() .lookup_or_add_for_write_only_span<ColorGeometry4f>(name.GetText(), ATTR_DOMAIN_POINT); if (!color_writer) { printf("Couldn't create writer for color %s\n", name.GetText()); continue; } pxr::VtVec3fArray colors; if (!pv.ComputeFlattened(&colors, params.motion_sample_time)) { printf("Couldn't compute flattened color primvar %s\n", name.GetText()); continue; } for (int i = 0; i < colors.size(); ++i) { const pxr::GfVec3f &usd_color = colors[i]; color_writer.span[i] = ColorGeometry4f( usd_color[0], usd_color[1], usd_color[2], 1.0f); } color_writer.finish(); } } ```
devin-bayly commented 2023-10-05 07:13:32 +02:00
Author
Copy Link

Yes! This was going to be my next question, how to pick the right templated writer provided the types that I get back from the primvar.

This is definitely room to explore, and will help me better understand what I'm reading on the usd_read_mesh.cc. Thanks @makowalski

Yes! This was going to be my next question, how to pick the right templated writer provided the types that I get back from the primvar. This is definitely room to explore, and will help me better understand what I'm reading on the `usd_read_mesh.cc`. Thanks @makowalski
Michael Kowalski commented 2023-10-05 15:53:17 +02:00
Member
Copy Link

You're very welcome! As for a PR, we need to keep in mind that this implementation requires changes in Kevin's branch

https://projects.blender.org/kevindietrich/blender/src/branch/abc_usd_geometry_sets

So this PR would need to wait until Kevin has committed these changes to main or we can perhaps create a PR into Kevin's branch instead. We should discuss with @kevindietrich when the time comes, but I don't think we're ready for a PR yet.

You're very welcome! As for a PR, we need to keep in mind that this implementation requires changes in Kevin's branch https://projects.blender.org/kevindietrich/blender/src/branch/abc_usd_geometry_sets So this PR would need to wait until Kevin has committed these changes to main or we can perhaps create a PR into Kevin's branch instead. We should discuss with @kevindietrich when the time comes, but I don't think we're ready for a PR yet.
devin-bayly commented 2023-10-05 17:51:30 +02:00
Author
Copy Link

Sounds good, as soon as I wrote that I was thinking "I bet that was a hasty suggestion," and will be happy to proceed whatever way makes the most sense!

Stay tuned

Sounds good, as soon as I wrote that I was thinking "I bet that was a hasty suggestion," and will be happy to proceed whatever way makes the most sense! Stay tuned
👍 1
devin-bayly commented 2023-10-14 00:02:58 +02:00
Author
Copy Link

Ok, so integrating that code from above I have the color being brought in. I'm curious what the correct name would be to have blender automatically pick up the colors without having to use a custom shading material? Here you can see that I'm using the attribute name primvar:displayColor to make the point colors get selected correctly.
image

Also I'm curious, what other types of interpolation would I be working with besides vertex since with a point cloud we don't have any edges or faces right?

Ok, so integrating that code from above I have the color being brought in. I'm curious what the correct name would be to have blender automatically pick up the colors without having to use a custom shading material? Here you can see that I'm using the attribute name `primvar:displayColor` to make the point colors get selected correctly. ![image](/attachments/82ef4018-a753-4334-952c-7901d82fc4fc) Also I'm curious, what other types of interpolation would I be working with besides vertex since with a point cloud we don't have any edges or faces right?
image.png
153 KiB
Michael Kowalski commented 2023-10-16 23:07:32 +02:00
Member
Copy Link

Hi @devin-bayly. Nice progress!

Ok, so integrating that code from above I have the color being brought in. I'm curious what the correct name would be to have blender automatically pick up the colors without having to use a custom shading material? Here you can see that I'm using the attribute name primvar:displayColor to make the point colors get selected correctly.

To be honest, I haven't worked with Blender point clouds very much, so I don't know how to specify which color attribute to use for viewport display. Perhaps @HooglyBoogly would know. Otherwise, maybe you can ask on the blender-coders channel.

By the way, you probably want to strip the primvars: namespace prefix from the attribute name. I believe UsdGeomPrimvar::StripPrimvarsName() will do that, if I'm not mistaken:

https://openusd.org/release/api/class_usd_geom_primvar.html#a657439a0bca230d608522b786da8bcf3

Also I'm curious, what other types of interpolation would I be working with besides vertex since with a point cloud we don't have any edges or faces right?

In addition to vertex interpolation, you will encounter constant interpolation for point clouds, where a single value is assigned to every point.

Hi @devin-bayly. Nice progress! > Ok, so integrating that code from above I have the color being brought in. I'm curious what the correct name would be to have blender automatically pick up the colors without having to use a custom shading material? Here you can see that I'm using the attribute name `primvar:displayColor` to make the point colors get selected correctly. To be honest, I haven't worked with Blender point clouds very much, so I don't know how to specify which color attribute to use for viewport display. Perhaps @HooglyBoogly would know. Otherwise, maybe you can ask on the blender-coders channel. By the way, you probably want to strip the `primvars:` namespace prefix from the attribute name. I believe `UsdGeomPrimvar::StripPrimvarsName()` will do that, if I'm not mistaken: https://openusd.org/release/api/class_usd_geom_primvar.html#a657439a0bca230d608522b786da8bcf3 > Also I'm curious, what other types of interpolation would I be working with besides vertex since with a point cloud we don't have any edges or faces right? In addition to `vertex` interpolation, you will encounter `constant` interpolation for point clouds, where a single value is assigned to every point.
Hans Goudey commented 2023-10-16 23:47:03 +02:00
Member
Copy Link

To be honest, I haven't worked with Blender point clouds very much, so I don't know how to specify which color attribute to use for viewport display. Perhaps @HooglyBoogly would know. Otherwise, maybe you can ask on the blender-coders channel.

Point clouds are fairly new in Blender, so they don't have the idea of an "active color attribute" (in Blender lingo) yet. So far they've mostly been created with geometry nodes, where the viewer node is the most convenient answer for previewing a certain attribute anyway.

I wouldn't worry about that for now though, it's just a feature Blender will need to support sometime soon. At that time it can be added to USD I/O as well.

In addition to vertex interpolation, you will encounter constant interpolation for point clouds, where a single value is assigned to every point.

To add to that, Blender currently doesn't have a "constant" storage option, so just fill the entire attribute array with the single value from USD.

>To be honest, I haven't worked with Blender point clouds very much, so I don't know how to specify which color attribute to use for viewport display. Perhaps @HooglyBoogly would know. Otherwise, maybe you can ask on the blender-coders channel. Point clouds are fairly new in Blender, so they don't have the idea of an "active color attribute" (in Blender lingo) yet. So far they've mostly been created with geometry nodes, where the viewer node is the most convenient answer for previewing a certain attribute anyway. I wouldn't worry about that for now though, it's just a feature Blender will need to support sometime soon. At that time it can be added to USD I/O as well. >In addition to vertex interpolation, you will encounter constant interpolation for point clouds, where a single value is assigned to every point. To add to that, Blender currently doesn't have a "constant" storage option, so just fill the entire attribute array with the single value from USD.
👍 1
devin-bayly commented 2023-10-28 02:25:51 +02:00
Author
Copy Link

It was pretty painless to switch to the color I wanted so I figure I can keep doing it that way for now.

TY for the notes about the interpolations, I'll just behave as if the constants are really redundant values applied to each vertex.

The biggest delay for me right now is actually on the project that motivated this feature. I've been at the step where I can to create a usd file that has a set of custom prim vars for a few attributes on the point cloud provided by the lidar scanner

dtype([('x', '<f4'), ('y', '<f4'), ('z', '<f4'), ('intensity', '<f4'), ('t', '<u4'), ('reflectivity', '<u2'), ('ring', '<u2'), ('ambient', '<u2'), ('range', '<u4')])

I'm a bit confused at this point with the python usd library. On this page https://openusd.org/dev/api/class_usd_geom_primvar.html#details it details creating and accessing primvars, but bases it on an existing attribute. I'm stuck at the moment on building my custom primvars for each of the non x,y,z attributes above. Once I have that worked out I'll get back to fitting more pieces into the importer.

It was pretty painless to switch to the color I wanted so I figure I can keep doing it that way for now. TY for the notes about the interpolations, I'll just behave as if the constants are really redundant values applied to each vertex. The biggest delay for me right now is actually on the project that motivated this feature. I've been at the step where I can to create a usd file that has a set of custom prim vars for a few attributes on the point cloud provided by the lidar scanner ``` dtype([('x', '<f4'), ('y', '<f4'), ('z', '<f4'), ('intensity', '<f4'), ('t', '<u4'), ('reflectivity', '<u2'), ('ring', '<u2'), ('ambient', '<u2'), ('range', '<u4')]) ``` I'm a bit confused at this point with the python usd library. On this page https://openusd.org/dev/api/class_usd_geom_primvar.html#details it details creating and accessing primvars, but bases it on an existing attribute. I'm stuck at the moment on building my custom primvars for each of the non x,y,z attributes above. Once I have that worked out I'll get back to fitting more pieces into the importer.
devin-bayly commented 2023-11-03 20:58:22 +01:00
Author
Copy Link

OK, that took far too long to work out. I now have the piece in place that will convert my lidar timesteps into usdc. Here's a small snippet of the additional primvars that I'm outputting. I'm seeing something funky when I bring them into blender, even though it appears to read the additional primvars right.

image

I think perhaps this doesn't relate to what code I'm putting into blender so more work in the preprocessing is required for me still.

OK, that took far too long to work out. I now have the piece in place that will convert my lidar timesteps into usdc. Here's a small snippet of the additional primvars that I'm outputting. I'm seeing something funky when I bring them into blender, even though it appears to read the additional primvars right. ![image](/attachments/45ba6672-8824-45a1-a2d1-6c10090bcddc) I think perhaps this doesn't relate to what code I'm putting into blender so more work in the preprocessing is required for me still.
sama_pcd_multiple_small.usdc
20 MiB
image.png
1.0 MiB
devin-bayly commented 2023-11-03 21:17:58 +01:00
Author
Copy Link

I can confirm the usdviewer also has this prob, so I think I can confirm I did something wrong ahead of the blender step. on the right is cloud compare viewing one timestep of this lidar scan.

image

I can confirm the usdviewer also has this prob, so I think I can confirm I did something wrong ahead of the blender step. on the right is cloud compare viewing one timestep of this lidar scan. ![image](/attachments/89fae9b2-d485-413c-9867-eb234ba678f0)
image.png
405 KiB
devin-bayly commented 2023-11-03 21:44:23 +01:00
Author
Copy Link

Ok figured out I left off a transpose somewhere when I was saving out the point arrays.

image

Ok figured out I left off a transpose somewhere when I was saving out the point arrays. ![image](/attachments/fcedefec-4159-4539-9798-c84801a64c69)
image.png
1.1 MiB
devin-bayly commented 2023-11-03 21:56:40 +01:00
Author
Copy Link

seems good with color ramps too!
image

seems good with color ramps too! ![image](/attachments/38e9c52e-51b9-46b7-8936-c07daa6858e7)
image.png
1.2 MiB
Michael Kowalski commented 2024-01-16 18:30:04 +01:00
Member
Copy Link

@devin-bayly I just wanted to touch base on how things are going with this task. Looks live you had made some really nice progress! Is there any issue that you need help with?

@devin-bayly I just wanted to touch base on how things are going with this task. Looks live you had made some really nice progress! Is there any issue that you need help with?
devin-bayly commented 2024-01-19 23:06:53 +01:00
Author
Copy Link

Hi there!! Yea I'd love to reconnect in a day or so to get a sense of what the best next steps are. Thanks for checking on me!

Shoot how has it been 10 months already

Hi there!! Yea I'd love to reconnect in a day or so to get a sense of what the best next steps are. Thanks for checking on me! Shoot how has it been 10 months already
👍 1
devin-bayly commented 2024-02-02 18:09:13 +01:00
Author
Copy Link

Ok, I'm officially back at work after much vacation. Catching up here I see I should try to work in

After that I'd be up for a quick go over for my code to hear what I can be doing that improves the quality, or any other ideas about next steps. Let me know what you think @makowalski

Ok, I'm officially back at work after much vacation. Catching up here I see I should try to work in * https://openusd.org/release/api/class_usd_geom_primvar.html#a657439a0bca230d608522b786da8bcf3 `primvars:` stripping * line that duplicates a constant to a vertex length array After that I'd be up for a quick go over for my code to hear what I can be doing that improves the quality, or any other ideas about next steps. Let me know what you think @makowalski
Michael Kowalski commented 2024-02-02 18:17:52 +01:00
Member
Copy Link

After that I'd be up for a quick go over for my code to hear what I can be doing that improves the quality, or any other ideas about next steps. Let me know what you think @makowalski

That sounds good! I'll be happy to review your code, whenever you're ready. Thanks for the update!

> After that I'd be up for a quick go over for my code to hear what I can be doing that improves the quality, or any other ideas about next steps. Let me know what you think @makowalski That sounds good! I'll be happy to review your code, whenever you're ready. Thanks for the update!
Michael Kowalski commented 2024-02-28 15:50:29 +01:00
Member
Copy Link

Hi @devin-bayly. Now that the Alembic/USD geometry sets PR has landed, I think the coast is clear to create a PR for the UsdGeomPoints import work you've done so far, even if not every feature is complete. You can always continue improving point cloud import after it has landed, if you wish, but I think what you have so far would be quite useful. I'd be happy to help create this initial pull request, if you'd like.

Hi @devin-bayly. Now that the Alembic/USD geometry sets [PR](https://projects.blender.org/blender/blender/pulls/115623) has landed, I think the coast is clear to create a PR for the `UsdGeomPoints` import work you've done so far, even if not every feature is complete. You can always continue improving point cloud import after it has landed, if you wish, but I think what you have so far would be quite useful. I'd be happy to help create this initial pull request, if you'd like.
devin-bayly commented 2024-02-29 03:13:51 +01:00
Author
Copy Link

@makowalski , I keep starting a reply and then forgetting to send. Sorry! Yes I'm up for what you recommend. I'll just remove the primvars annoyance in the attributes read and then I'll send along to you.

@makowalski , I keep starting a reply and then forgetting to send. Sorry! Yes I'm up for what you recommend. I'll just remove the primvars annoyance in the attributes read and then I'll send along to you.
devin-bayly commented 2024-02-29 07:12:23 +01:00
Author
Copy Link

I think I might have botched up a little of the git history so I'll probably need to work on that a little, but here's the changes that I've worked on most recently.

https://projects.blender.org/devin-bayly/blender/src/branch/devin-bayly-patch-3

I think if I go back to my patch-2 branch and then cherry pick just the changes that I made to the points.cc file then I think it'll be a little cleaner what I commit. If you have other suggestions then let me know!

I think I might have botched up a little of the git history so I'll probably need to work on that a little, but here's the changes that I've worked on most recently. https://projects.blender.org/devin-bayly/blender/src/branch/devin-bayly-patch-3 I think if I go back to my patch-2 branch and then cherry pick just the changes that I made to the points.cc file then I think it'll be a little cleaner what I commit. If you have other suggestions then let me know!
👍 1
devin-bayly commented 2024-03-26 00:19:07 +01:00
Author
Copy Link

I'm truly in awe now of people who work on the large repos. Even the simple things seem to trip me up. Here's a branch that I think keeps the changes local to the two files (usd_reader_points.cc,.h) that actually got edited. Sorry for all the delays, and thanks for the tremendous amount of support @makowalski '

https://projects.blender.org/devin-bayly/blender/src/branch/devin-bayly-patch-2-clean

what's the next step we should take?

I'm truly in awe now of people who work on the large repos. Even the simple things seem to trip me up. Here's a branch that I think keeps the changes local to the two files (usd_reader_points.cc,.h) that actually got edited. Sorry for all the delays, and thanks for the tremendous amount of support @makowalski ' https://projects.blender.org/devin-bayly/blender/src/branch/devin-bayly-patch-2-clean what's the next step we should take?
Michael Kowalski commented 2024-03-26 01:34:00 +01:00
Member
Copy Link

Hi @devin-bayly. I'll take a look at this in the next day or so. I'm sorry for the delay on my part, and thanks for all the hard work!

Hi @devin-bayly. I'll take a look at this in the next day or so. I'm sorry for the delay on my part, and thanks for all the hard work!
Michael Kowalski commented 2024-03-26 19:25:42 +01:00
Member
Copy Link

Hi @devin-bayly. The branch you're working on is very much out of date with main. As a first step, I'd like to apply the changes you have cleanly to top of main so we have a branch we can use to create the pull request. I'm working on this right now and will let you know when the new branch is ready. We can then continue the review from there.

Hi @devin-bayly. The branch you're working on is very much out of date with main. As a first step, I'd like to apply the changes you have cleanly to top of main so we have a branch we can use to create the pull request. I'm working on this right now and will let you know when the new branch is ready. We can then continue the review from there.
Michael Kowalski commented 2024-03-27 17:34:13 +01:00
Member
Copy Link

Hi @devin-bayly . I made this branch that has your changes from devin-bayly-patch-2-clean applied to the latest main:

https://projects.blender.org/makowalski/blender/src/branch/usd-points-import

I made some updates to get it to compile with main. I also renamed usd_reader_points.h to usd_reader_points.hh, since the .hh extension is now standard in the USD module. In addition, I did some minor cleanup:

  • Removed unused includes
  • Removed debug code and printfs
  • Updated the license identifier headers
  • Changed printfs for warnings to CLOG calls
  • Fixed formatting
  • Removed primvars prefix from color attribute names

Would you mind creating a pull request from this branch? Basically, if you clone my usd-points-import branch and push it to your own remote, you'll then have an option to create a pull request from it. This will allow us to continue with the review process and eventually merge it into main.

Here is some info on creating pull requests: https://developer.blender.org/docs/handbook/contributing/pull_requests/

Please let me know if you have questions.

Hi @devin-bayly . I made this branch that has your changes from `devin-bayly-patch-2-clean` applied to the latest `main`: https://projects.blender.org/makowalski/blender/src/branch/usd-points-import I made some updates to get it to compile with `main`. I also renamed `usd_reader_points.h` to `usd_reader_points.hh`, since the .hh extension is now standard in the USD module. In addition, I did some minor cleanup: - Removed unused includes - Removed debug code and printfs - Updated the license identifier headers - Changed printfs for warnings to CLOG calls - Fixed formatting - Removed primvars prefix from color attribute names Would you mind creating a pull request from this branch? Basically, if you clone my `usd-points-import` branch and push it to your own remote, you'll then have an option to create a pull request from it. This will allow us to continue with the review process and eventually merge it into main. Here is some info on creating pull requests: https://developer.blender.org/docs/handbook/contributing/pull_requests/ Please let me know if you have questions.
devin-bayly commented 2024-03-27 19:37:02 +01:00
Author
Copy Link

The branch you're working on is very much out of date with main.

Oh i bet, thanks for helping out with making the code apply to the latest version of the source.

Happy to make a PR from that branch and I'll quickly read over that link below.

> The branch you're working on is very much out of date with main. Oh i bet, thanks for helping out with making the code apply to the latest version of the source. Happy to make a PR from that branch and I'll quickly read over that link below.
devin-bayly commented 2024-03-27 20:22:27 +01:00
Author
Copy Link

@makowalski Just checking, did I do what you were hoping here? https://projects.blender.org/devin-bayly/blender/src/branch/usd-points-import

@makowalski Just checking, did I do what you were hoping here? https://projects.blender.org/devin-bayly/blender/src/branch/usd-points-import
Michael Kowalski commented 2024-03-27 21:12:46 +01:00
Member
Copy Link

Hi @devin-bayly. Thanks for following up! I see your copy of the branch, but did you create the pull request?

https://developer.blender.org/docs/handbook/contributing/pull_requests/#create-a-pull-request

Hi @devin-bayly. Thanks for following up! I see your copy of the branch, but did you create the pull request? https://developer.blender.org/docs/handbook/contributing/pull_requests/#create-a-pull-request
devin-bayly commented 2024-03-27 22:21:41 +01:00
Author
Copy Link

Haha yea I only did the copying step, but I'll submit the pr now. It's going to blender:main hope that's right

Haha yea I only did the copying step, but I'll submit the pr now. It's going to `blender:main` hope that's right
devin-bayly commented 2024-03-27 22:22:36 +01:00
Author
Copy Link

Oh, it looks like makowalski:main is the only option I have in the drop down

Oh, it looks like `makowalski:main` is the only option I have in the drop down
Michael Kowalski commented 2024-03-27 22:56:47 +01:00
Member
Copy Link

Yes, it should go to blender:main. I'm not sure why you're not seeing it. Maybe something went wrong when you copied my branch.
How did you copy my branch?

In any case, maybe try copying the usd-import-points branch to another name locally, push it to your remote, and see if the pull works in that case?

Yes, it should go to blender:main. I'm not sure why you're not seeing it. Maybe something went wrong when you copied my branch. How did you copy my branch? In any case, maybe try copying the usd-import-points branch to another name locally, push it to your remote, and see if the pull works in that case?
devin-bayly commented 2024-03-27 23:14:54 +01:00
Author
Copy Link

haha I knew I messed something up a bit. So my branch cloning worked something like,

git remote add mako https://projects.blender.org/makowalski/blender
git fetch mako
git checkout mako/usd-import-points
# now making my actual branch from the remote
git checkout -b usd-import-points
git push origin usd-import-points

Does this go further back to the point where I first cloned the repo using your page instead of the original blender source repo?

haha I knew I messed something up a bit. So my branch cloning worked something like, ``` git remote add mako https://projects.blender.org/makowalski/blender git fetch mako git checkout mako/usd-import-points # now making my actual branch from the remote git checkout -b usd-import-points git push origin usd-import-points ``` Does this go further back to the point where I first cloned the repo using your page instead of the original blender source repo?
Michael Kowalski commented 2024-03-27 23:50:36 +01:00
Member
Copy Link

Yes, it could be that you did not fork the original blender source repo.

Did you originally follow this setup: https://developer.blender.org/docs/handbook/contributing/pull_requests/#one-time-setup

Yes, it could be that you did not fork the original blender source repo. Did you originally follow this setup: https://developer.blender.org/docs/handbook/contributing/pull_requests/#one-time-setup
Michael Kowalski commented 2024-03-29 14:15:29 +01:00
Member
Copy Link

@devin-bayly Per our direct discussion yesterday, I opened pull request #120060 based on your branch.

@devin-bayly Per our direct discussion yesterday, I opened pull request https://projects.blender.org/blender/blender/pulls/120060 based on your branch.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
main
brush-assets-project
fix-121021
blender-v4.1-release
blender-v3.3-release
blender-v3.6-release
universal-scene-description
blender-v3.6-temp_wmoss_animrig_public
temp-sculpt-dyntopo
gpencil-next
anim/animation-id-113594
blender-v4.0-release
blender-projects-basics
bridge-curves
sculpt-blender
asset-browser-frontend-split
asset-shelf
tmp-usd-python-mtl
tmp-usd-3.6
blender-v3.5-release
blender-v2.93-release
realtime-clock
sculpt-dev
bevelv2
xr-dev
v4.1.1
v3.6.11
v3.3.18
v4.1.0
v3.3.17
v3.6.10
v3.6.9
v3.3.16
v3.6.8
v3.6.7
v3.3.14
v4.0.2
v4.0.1
v4.0.0
v3.6.5
v3.3.12
v3.6.4
v3.6.3
v3.3.11
v3.6.2
v3.3.10
v3.6.1
v3.3.9
v3.6.0
v3.3.8
v3.3.7
v2.93.18
v3.5.1
v3.3.6
v2.93.17
v3.5.0
v2.93.16
v3.3.5
v3.3.4
v2.93.15
v2.93.14
v3.3.3
v2.93.13
v2.93.12
v3.4.1
v3.3.2
v3.4.0
v3.3.1
v2.93.11
v3.3.0
v3.2.2
v2.93.10
v3.2.1
v3.2.0
v2.83.20
v2.93.9
v3.1.2
v3.1.1
v3.1.0
v2.83.19
v2.93.8
v3.0.1
v2.93.7
v3.0.0
v2.93.6
v2.93.5
v2.83.18
v2.93.4
v2.93.3
v2.83.17
v2.93.2
v2.93.1
v2.83.16
v2.93.0
v2.83.15
v2.83.14
v2.83.13
v2.92.0
v2.83.12
v2.91.2
v2.83.10
v2.91.0
v2.83.9
v2.83.8
v2.83.7
v2.90.1
v2.83.6.1
v2.83.6
v2.90.0
v2.83.5
v2.83.4
v2.83.3
v2.83.2
v2.83.1
v2.83
v2.82a
v2.82
v2.81a
v2.81
v2.80
v2.80-rc3
v2.80-rc2
v2.80-rc1
v2.79b
v2.79a
v2.79
v2.79-rc2
v2.79-rc1
v2.78c
v2.78b
v2.78a
v2.78
v2.78-rc2
v2.78-rc1
v2.77a
v2.77
v2.77-rc2
v2.77-rc1
v2.76b
v2.76a
v2.76
v2.76-rc3
v2.76-rc2
v2.76-rc1
v2.75a
v2.75
v2.75-rc2
v2.75-rc1
v2.74
v2.74-rc4
v2.74-rc3
v2.74-rc2
v2.74-rc1
v2.73a
v2.73
v2.73-rc1
v2.72b
2.72b
v2.72a
v2.72
v2.72-rc1
v2.71
v2.71-rc2
v2.71-rc1
v2.70a
v2.70
v2.70-rc2
v2.70-rc
v2.69
v2.68a
v2.68
v2.67b
v2.67a
v2.67
v2.66a
v2.66
v2.65a
v2.65
v2.64a
v2.64
v2.63a
v2.63
v2.61
v2.60a
v2.60
v2.59
v2.58a
v2.58
v2.57b
v2.57a
v2.57
v2.56a
v2.56
v2.55
v2.54
v2.53
v2.52
v2.51
v2.50
v2.49b
v2.49a
v2.49
v2.48a
v2.48
v2.47
v2.46
v2.45
v2.44
v2.43
v2.42a
v2.42
v2.41
v2.40
v2.37a
v2.37
v2.36
v2.35a
v2.35
v2.34
v2.33a
v2.33
v2.32
v2.31a
v2.31
v2.30
v2.28c
v2.28a
v2.28
v2.27
v2.26
v2.25
Labels
Clear labels   
Interest
Alembic

  
Interest
Animation & Rigging

  
Interest
Asset Browser

  
Interest
Asset Browser Project Overview

  
Interest
Audio

  
Interest
Automated Testing

  
Interest
Blender Asset Bundle

  
Interest
BlendFile

  
Interest
Collada

  
Interest
Compatibility
This issue affects/is about backward or forward compatibility

  
Interest
Compositing

  
Interest
Core

  
Interest
Cycles

  
Interest
Dependency Graph

  
Interest
Development Management

  
Interest
EEVEE

  
Interest
EEVEE & Viewport

  
Interest
Freestyle

  
Interest
Geometry Nodes

  
Interest
Grease Pencil

  
Interest
ID Management

  
Interest
Images & Movies

  
Interest
Import Export

  
Interest
Line Art

  
Interest
Masking

  
Interest
Metal

  
Interest
Modeling

  
Interest
Modifiers

  
Interest
Motion Tracking

  
Interest
Nodes & Physics

  
Interest
OpenGL

  
Interest
Overlay

  
Interest
Overrides

  
Interest
Performance

  
Interest
Physics

  
Interest
Pipeline, Assets & IO

  
Interest
Platforms, Builds & Tests

  
Interest
Python API

  
Interest
Render & Cycles

  
Interest
Render Pipeline

  
Interest
Sculpt, Paint & Texture

  
Interest
Text Editor

  
Interest
Translations

  
Interest
Triaging

  
Interest
Undo

  
Interest
USD

  
Interest
User Interface

  
Interest
UV Editing

  
Interest
VFX & Video

  
Interest
Video Sequencer

  
Interest
Virtual Reality

  
Interest
Vulkan

  
Interest
Wayland
Issues relating to Wayland windowing support.

  
Interest
Workbench

  
Interest: X11

Issues relating to Xorg/X11 support.

  
Legacy
Blender 2.8 Project

  
Legacy
Milestone 1: Basic, Local Asset Browser

  
Legacy
OpenGL Error

  
Meta
Good First Issue

  
Meta
Papercut

  
Meta
Retrospective

  
Meta
Security
Issues relating to security: https://wiki.blender.org/wiki/Process/Vulnerability_Reports

  
Module
Animation & Rigging

  
Module
Core

  
Module
Development Management

  
Module
EEVEE & Viewport

  
Module
Grease Pencil

  
Module
Modeling

  
Module
Nodes & Physics

  
Module
Pipeline, Assets & IO

  
Module
Platforms, Builds & Tests

  
Module
Python API

  
Module
Render & Cycles

  
Module
Sculpt, Paint & Texture

  
Module
Triaging

  
Module
User Interface

  
Module
VFX & Video

  
Platform
FreeBSD

  
Platform
Linux

  
Platform
macOS

  
Platform
Windows

  
Priority
High

  
Priority
Low

  
Priority
Normal

  
Priority
Unbreak Now!

  
Status
Archived

  
Status
Confirmed

  
Status
Duplicate

  
Status
Needs Info from Developers

  
Status
Needs Information from User

  
Status
Needs Triage

  
Status
Resolved

  
Type
Bug

  
Type
Design

  
Type
Known Issue

  
Type
Patch

  
Type
Report

  
Type
To Do

No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
USD
Assignees
Clear assignees
No Assignees
5 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#106398
No description provided.
Delete Branch "%!s(<nil>)"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?