WIP: USD: UsdGeomPoints import support #120060
No reviewers
Labels
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: blender/blender#120060
Loading…
Reference in New Issue
No description provided.
Delete Branch "makowalski/blender:usd-points-import"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
The work on this pull request was contributed by devin-bayly and addresses issue #106398.
This commit provides an implemention of a
USDPointsReader
class to importUsdGeomPoints
primitives as Blender Point Clouds.This implementation looks good. I would recommend extending it as follows:
USDPointsReader::is_animated()
to handle animating attributes in addition to points.I am available to help with these tasks.
We should also add some simple test coverage for import along with these changes. The
pointsTestColors.usda
file from #106398 would work well (just 2-3 frames would suffice). I can help with that as well.@ -0,0 +104,4 @@
bke::SpanAttributeWriter<float3> positions_writer =
point_cloud->attributes_for_write().lookup_or_add_for_write_span<float3>(
"position", bke::AttrDomain::Point);
MutableSpan<float3> point_positions = positions_writer.span;
The few lines above can be collapsed into just the following:
MutableSpan<float3> point_positions = point_cloud->positions_for_write();
@ -0,0 +106,4 @@
"position", bke::AttrDomain::Point);
MutableSpan<float3> point_positions = positions_writer.span;
for (size_t i = 0; i < positions.size(); i++) {
We can use a more efficient form here for positions. Replace the entirety of the loop with:
We've done similar in
usd_reader_curve.cc
@ -0,0 +118,4 @@
* custom spans for the attributes. */
std::vector<pxr::UsdGeomPrimvar> primvars = primvarsLoaded.GetPrimvarsWithValues();
for (auto pv : primvars) {
Use
const auto &pv
as auto does not use const or references on its own.@ -0,0 +143,4 @@
for (int i = 0; i < colors.size(); ++i) {
const pxr::GfVec3f &usd_color = colors[i];
primvar_writer.span[i] = ColorGeometry4f(usd_color[0], usd_color[1], usd_color[2], 1.0f);
};
Remove trailing
;
on for loop bracket@ -0,0 +161,4 @@
continue;
}
for (int i = 0; i < values.size(); ++i) {
Like the above, this can use the more efficient form:
primvar_writer.span.copy_from(Span(values.data(), values.size()));
@makowalski If you don't mind, I'll be updating this PR to address my feedback above and to add in code to read velocity and width data.
Sure, that would be fine. My apologies for the delay addressing these points, but I was waiting till some of the common attribute IO functions were committed and available. But if you would like to move forward with that task, it would b much appreciated. Thanks!
Yeah, I've been waffling back and forth on how best to separate out the reader attribute processing... I started with the writer side over at !121145. Give it a look when you get the time to see if that's the direction we want to move towards.
For now my changes just flesh out the main portions of the class but don't load any additional attributes besides the velocity/width data + the existing Color and Float attributes that were there already. So it's a tiny step closer but probably not enough to commit just yet without the other attribute types.
Checkout
From your project repository, check out a new branch and test the changes.