The changes look good to me. Thanks!
Another thing to consider: use
userProperties:blender:object_name
/userProperties:blender:data_name
if these have been exported? (this happens if you have theBlender Names
option ON for…
Hmm, if a blender property is currently called "customNs:prop" then it will become "customNs_prop" during export since invalid USD identifier characters are turned to underscores. I suppose this…
This introduces some asymmetry with Import. Given an object with custom property "prop", if you export as
userProperties:prop
then on Import this will just be read back in asprop
- as…
I believe the logic should also be added to USDPointInstancerReader
and USDPointsReader
.
I am not sure, but it might make sense to move this logic to USDXformReader
since you would need access to USDXformReader::use_parent_xform()
to decide what the object name should be.
I don't believe you need to tokenize the path yourself in this case. The pxr::SdfPath
class already provides facilities for doing this, e.g.,
Thanks for this work, @lichtwerk! This is an important fix and you're definitely on the right track.
However, you should only use the parent name for the object name if `USDXformReader::use_p…
@lichtwerk Thanks for looking into this! Yes, by all means, please create a pull request for this patch when you are ready.
@deadpin I think you need to turn off Lights->Enable Default Dome Light
in USDView
to fix the issue you are seeing: