Michael Kowalski makowalski
  • Joined on 2020-09-17
Michael Kowalski commented on pull request blender/blender#123031 2024-06-11 20:05:47 +02:00
USD export: fix malformed joint paths

Sorry about that :(. Thanks for investigating the fix here.

No worries at all! Like I said, I should have caught it in the review myself, since it wasn't obvious how the path building should…

Michael Kowalski commented on issue blender/blender#122636 2024-06-11 04:41:43 +02:00
USD: Armature animations are not exported correctly

It looks like there are actually 2 separate, unrelated issues. The bug I mentioned above was preventing the UsdSkel animation from being imported at all in Blender 4.2. The fix I have will…

Michael Kowalski commented on pull request blender/blender#123031 2024-06-10 20:10:53 +02:00
USD export: fix malformed joint paths

Thanks for pointing this out, @deadpin. It looks like there were two separate issues affecting 4.2, then. (Without the above fix, this UsdSkel animation exported from Blender wouldn't load at…

Michael Kowalski commented on issue blender/blender#122636 2024-06-10 19:34:37 +02:00
USD: Armature animations are not exported correctly

I have a fix for this in pull request #123031.

Michael Kowalski created pull request blender/blender#123031 2024-06-10 19:31:34 +02:00
Fix 122636: USD export: fix malformed joint paths
Michael Kowalski created branch usd-export-fix-joint-paths in makowalski/blender 2024-06-10 19:29:51 +02:00
Michael Kowalski pushed to usd-export-fix-joint-paths at makowalski/blender 2024-06-10 19:29:51 +02:00
88caa880aa Fix 122636: USD export: fix malformed joint paths
4f593b5710 Fix: Incorrect layout in vertex color shader node
6cccbc8df9 Fix #82483: Random Cycles baking hangs with node editor open
28f7a467fa cmake: windows: only install fftw's dlls when available
83edd748a2 Fix #120466: Crash when opening file with inactive asset browser
Compare 10 commits »
Michael Kowalski commented on issue blender/blender#122636 2024-06-10 17:56:24 +02:00
USD: Armature animations are not exported correctly

I believe the issue is a bug in how the joint paths are saved. I.e., forward-slash separators in joint paths are being saved as underscores. E.g., path "mixamorig1_Hips/mixamorig1_Spine" is…

Michael Kowalski commented on issue blender/blender#122636 2024-06-10 17:21:16 +02:00
USD: Armature animations are not exported correctly

I've confirmed that the UsdSkel export of this animation worked as expected in a build as of a couple of months ago, so I'm comparing the output to determine what might have changed.

Michael Kowalski commented on issue blender/blender#122636 2024-06-10 16:24:12 +02:00
USD: Armature animations are not exported correctly

I'm investigating this as well.

Michael Kowalski opened issue blender/blender#123008 2024-06-10 15:20:59 +02:00
USD Targets for blender 4.3
Michael Kowalski commented on pull request blender/blender#122804 2024-06-05 22:47:38 +02:00
USD: Adding an option to convert the scene's meters per unit value

Thanks for porting this @CharlesWardlaw ! I was thinking that the unit conversion should be made more generic to handle arbitrary unit scaling, not just centimeters. The initial USD branch…

Michael Kowalski approved blender/blender#122575 2024-06-05 18:34:51 +02:00
USD: Add MaterialX shader export

As I mentioned earlier, I can only do a limited review, but the changes on the whole look good to me. With that caveat, I am approving this PR, so as not to block the commit once @deadpin and @brecht approve the latest changes.

Michael Kowalski commented on pull request blender/blender#122415 2024-06-05 15:53:10 +02:00
USD: use panels for Import and Export

@makowalski One part I'm not sure about is the "Convert World Material" option currently being under a "Lights" panel, matching the usd branch. It seems that with issue #122651 it might be…

Michael Kowalski commented on pull request blender/blender#122415 2024-06-05 15:52:22 +02:00
USD: use panels for Import and Export

Adding @CharlesWardlaw as a reviewer, as he originally implemented the panels feature in the USD branch.

Michael Kowalski commented on pull request blender/blender#122575 2024-06-04 18:08:43 +02:00
USD: Add MaterialX shader export

@makowalski Yes that's a limitation of USD's MaterialX translation currently. Is there a place where you resolve that name? It doesn't seem to make it into the MaterialX graph itself, so it's…

Michael Kowalski commented on pull request blender/blender#122575 2024-06-04 17:00:42 +02:00
USD: Add MaterialX shader export

I can only do a partial review (due to time constraints), but the changes to the existing files (e.g., usd_writer_material.cc, etc.) look good to me. I tested exporting MaterialX to Houdini and…

Michael Kowalski approved blender/blender#122471 2024-06-04 07:27:14 +02:00
USD: implement native Unicode support

Good to know the crash is fixed. Otherwise, the changes look good and work well with my tests. I will go ahead and approve this PR. Thank you for this work!

Michael Kowalski commented on pull request blender/blender#122471 2024-06-04 07:18:09 +02:00
USD: implement native Unicode support

Not sure if it's related to the missing guards you just mentioned, but I get a crash when trying to export a simple animation with an animating transform. To reproduce, load the attached blend…

Michael Kowalski commented on pull request blender/blender#122471 2024-06-04 04:03:11 +02:00
USD: implement native Unicode support

I believe this include needs to be conditional on USD 24.03: