Matias Mendiola mendio
0 Followers · 5 Following
  • Joined on 2013-10-31
Repositories
2
 Projects Public Activity Starred Repositories
3
Matias Mendiola pushed to GPv3_OP_Move_to_layer at mendio/blender 2024-01-19 14:08:19 +01:00
214651e58f Cleanup: Removed unused and duplicated code
Matias Mendiola commented on pull request blender/blender#117244 2024-01-19 13:26:13 +01:00
GPv3: Move to layer

I rephrased the comments in the if...else to clarify that one move/copy geometry and the other append to existing geometry. Let me know if you think more detail is still needed in this comments.

Matias Mendiola commented on pull request blender/blender#117244 2024-01-19 13:19:20 +01:00
GPv3: Move to layer

I rephrased the comments for clarity.

Matias Mendiola pushed to GPv3_OP_Move_to_layer at mendio/blender 2024-01-19 13:16:42 +01:00
8f1b56b1eb Cleanup: Comments
e1f1e1cb66 Cleanup: remove trailing whitespace
Compare 2 commits »
Matias Mendiola commented on pull request blender/blender#117244 2024-01-18 20:28:33 +01:00
GPv3: Move to layer

sorry, the problem was a typo

Matias Mendiola pushed to GPv3_OP_Move_to_layer at mendio/blender 2024-01-18 20:27:47 +01:00
a04e536dd9 Cleanup: style
Matias Mendiola commented on pull request blender/blender#117244 2024-01-18 18:59:28 +01:00
GPv3: Move to layer

@filedescriptor right now because we are no longer use the invoke in the operator when adding a new layer the code never reach grease_pencil_move_to_layer_exec, it only works when we select a…

Matias Mendiola commented on pull request blender/blender#117244 2024-01-18 18:54:18 +01:00
GPv3: Move to layer

When doing this way the Layer add popup shows empty

Matias Mendiola pushed to GPv3_OP_Move_to_layer at mendio/blender 2024-01-18 18:52:56 +01:00
68d27d6d52 Cleanup: remove unused code
Matias Mendiola commented on pull request blender/blender#117244 2024-01-18 15:16:01 +01:00
GPv3: Move to layer

perfect, that works, also the set Active Layer operator is working as intended

Matias Mendiola pushed to GPv3_OP_Move_to_layer at mendio/blender 2024-01-18 15:13:54 +01:00
074ac27c21 Use layer_add invoked as a popup
Matias Mendiola commented on pull request blender/blender#117244 2024-01-18 14:06:26 +01:00
GPv3: Move to layer

in GPv2 we follow the Move to Collection behavior, when the user wants to move an object to a new collection, the name of the new collection can be typed in a popup window. Maybe I'm wrong but is…

Matias Mendiola commented on pull request blender/blender#117244 2024-01-18 13:20:31 +01:00
GPv3: Move to layer

It seems not possible, in Separate operator was told me that frames can't be inserted into a grease pencil data-block in parallel

Matias Mendiola pushed to GPv3_OP_Move_to_layer at mendio/blender 2024-01-18 13:20:22 +01:00
4a40b72099 changes after first review
Matias Mendiola commented on pull request blender/blender#116726 2024-01-17 22:17:43 +01:00
GPv3: Merge Points

Thanks @PRiera1 , but please coordinate this with @filedescriptor because there is an ongoing PR for Join operator [#113570: GPv3: Join Strokes](https://projects.blender.org/blender/blender/issues/…

Matias Mendiola pushed to GPv3_OP_Move_to_layer at mendio/blender 2024-01-17 20:02:11 +01:00
a770d6092e Merge branch 'main' into GPv3_OP_Move_to_layer
633e8f09c8 Cleanup: Remove unused asset C functions
8ba7e40bb4 Revert #106653: Cleanup Dialog to Manage Orphaned Data
4a77cdf745 Cleanup: GPv3: Remove unused editor function
f566f51f29 Cleanup: GPv3: Move curve smoothing to geometry namespace
Compare 5 commits »
Matias Mendiola pushed to GPv3_OP_Move_to_layer at mendio/blender 2024-01-17 19:58:32 +01:00
f4cf948226 Cleanup: Remove comments and unused code
Matias Mendiola commented on pull request blender/blender#117244 2024-01-17 19:30:58 +01:00
GPv3: Move to layer

Thanks Hans! after some tweaks of your code I've got this working, I'll remove the WIP to the title and wait for a more indeep review

Matias Mendiola pushed to GPv3_OP_Move_to_layer at mendio/blender 2024-01-17 19:28:34 +01:00
b603cd6954 Use geometry::join_geometries to append strokes to existing Layer
Matias Mendiola commented on pull request blender/blender#117244 2024-01-17 18:17:27 +01:00
GPv3: Move to layer

Thanks! do you have any code sample using geometry::join_geometries maybe is the right way to do this