added missing types

@@ -1641,0 +1641,4 @@
+static int grease_pencil_stroke_merge_exec(bContext *C, wmOperator * /* op */)
+{
+  auto compute_src_ranges = [](IndexMask src_selection, const bke::CurvesGeometry &src_geometry) -> Vector<IndexRange> {
+    Vector<IndexRange> initial_ranges = src_selection.to_ranges();

@@ -1641,0 +1643,4 @@
+  auto compute_src_ranges = [](IndexMask src_selection, const bke::CurvesGeometry &src_geometry) -> Vector<IndexRange> {
+    Vector<IndexRange> initial_ranges = src_selection.to_ranges();
+
+    // Splitting the source selection by ranges doesn't take into account the strokes,

@@ -1641,0 +1648,4 @@
+    // indices end up in the same range. Let's refine the splitting
+    Vector<IndexRange> final_ranges{};
+    const Array<int> points_map = src_geometry.point_to_curve_map();
+    for (const auto index_range : initial_ranges) {

@@ -1641,0 +1737,4 @@
+  bke::greasepencil::Drawing *act_drawing = grease_pencil.get_editable_drawing_at(active_layer, current_frame);
+  bke::CurvesGeometry& act_geometry = act_drawing->strokes_for_write();
+
+  for (auto layer : grease_pencil.layers_for_write())

@@ -1641,0 +1743,4 @@
+      continue;
+    }
+
+    auto *drawing = grease_pencil.get_editable_drawing_at(layer, current_frame);

@@ -1641,0 +1750,4 @@
+    }
+
+    IndexMaskMemory memory;
+    const bke::CurvesGeometry &geometry = drawing->strokes();

@@ -1641,0 +1751,4 @@
+
+    IndexMaskMemory memory;
+    const bke::CurvesGeometry &geometry = drawing->strokes();
+    IndexMask points_selection = curves::retrieve_selected_points(geometry, memory);

@@ -1641,0 +1757,4 @@
+      continue;
+    }
+
+    const Vector<IndexRange> src_ranges = compute_src_ranges(points_selection, geometry);

@@ -1641,0 +1763,4 @@
+        src_ranges, points_selection.size(), act_geometry);
+
+    copy_attributes_for_selected_ranges(geometry, src_ranges, new_geometry_offsets, act_geometry);
+  }

@@ -1641,0 +1766,4 @@
+  }
+
+  // WIP: this was hardcoded to prevent an old crash, requires fix
+  act_geometry.fill_curve_types(CURVE_TYPE_CATMULL_ROM);

@@ -1641,0 +1771,4 @@
+
+  act_drawing->tag_topology_changed();
+  act_geometry.update_curve_types();
+  return OPERATOR_FINISHED;

@@ -1640,1 +1640,4 @@
 
+static int grease_pencil_stroke_merge_exec(bContext *C, wmOperator * /* op */)
+{
+  auto compute_src_ranges = [](IndexMask src_selection, const bke::CurvesGeometry &src_geometry) -> Vector<IndexRange> {

@@ -1641,0 +1675,4 @@
+    return final_ranges;
+  };
+  
+  auto resize_and_compute_new_offsets =

@@ -1641,0 +1773,4 @@
+  bool changed = false;
+
+  threading::parallel_for_each(drawings, [&](MutableDrawingInfo &info) {
+    IndexMaskMemory memory;

@@ -1040,2 +1039,4 @@
     this->curve_num = curves_num;
   }
+
+  this->curve_offsets[this->curve_num] = this->point_num;

@@ -1668,1 +1670,4 @@
 
+namespace stroke_merge_utils {
+struct CurveRange {
+  IndexMask range_mask;

@@ -1669,0 +1681,4 @@
+  bool is_active_layer;
+};
+
+static Array<CurveRange> compute_stroke_ranges(IndexMask selection,

@@ -1669,0 +1725,4 @@
+  return final_ranges.as_span();
+}
+
+static Array<LayerSelectionInfo> obtain_selections_by_layer(

@@ -1669,0 +1732,4 @@
+    IndexMaskMemory &memory)
+{
+  Vector<LayerSelectionInfo> selections_by_layer;
+  for (MutableDrawingInfo info : frame_drawings) {

@@ -1669,0 +1777,4 @@
+
+  IndexMaskMemory memory;
+  Array<int> mask_values(info.selected_ranges.size());
+  for (const auto index : mask_values.index_range()) {

@@ -1669,0 +1778,4 @@
+  IndexMaskMemory memory;
+  Array<int> mask_values(info.selected_ranges.size());
+  for (const auto index : mask_values.index_range()) {
+    mask_values[index] = index * 2;

@@ -1669,0 +1792,4 @@
+                                   dst_curves.attributes_for_write());
+}
+
+static void remove_selection(bke::CurvesGeometry &curves, IndexMask points_selection)

@@ -1669,0 +1846,4 @@
+
+  Map<int, Vector<MutableDrawingInfo>> drawings_per_frame{};
+  for (auto &drawing : drawings) {
+    auto &frame_drawings = drawings_per_frame.lookup_or_add_default(drawing.frame_number);

@@ -1669,0 +1861,4 @@
+    }
+
+    Span<const Layer *> layers = grease_pencil.layers();
+    const auto it = std::find(layers.begin(), layers.end(), active_layer);

@@ -1669,0 +1671,4 @@
+namespace stroke_merge_utils {
+struct CurveRange {
+  IndexMask range_mask;
+  CurveType curve_type;

@@ -1669,0 +1684,4 @@
+static Array<CurveRange> compute_stroke_ranges(IndexMask selection,
+                                               const bke::CurvesGeometry &curves)
+{
+  const Span<IndexRange> initial_ranges = selection.to_ranges();

@@ -1669,0 +1692,4 @@
+   * indices end up in the same range. Let's refine the splitting
+   */
+  const VArray<int8_t> curve_types = curves.curve_types();
+  Vector<CurveRange> final_ranges{};

@@ -1669,0 +1693,4 @@
+   */
+  const VArray<int8_t> curve_types = curves.curve_types();
+  Vector<CurveRange> final_ranges{};
+  const Array<int> points_map = curves.point_to_curve_map();

@@ -1669,0 +1722,4 @@
+    final_ranges.append({range, static_cast<CurveType>(curve_types[previous_curve])});
+  }
+
+  return final_ranges.as_span();

@@ -1669,0 +1757,4 @@
+  const int dst_initial_points = dst_curves.points_num();
+  int previos_offset = 0;
+  Vector dst_raw_offsets{dst_initial_points};
+  Vector<int> src_raw_offsets{};

@@ -1669,0 +1803,4 @@
+
+static void merge_curve_attributes(const LayerSelectionInfo &info, bke::CurvesGeometry &dst_curves)
+{
+  /**

@@ -1669,0 +1844,4 @@
+
+  bool changed = false;
+
+  Map<int, Vector<MutableDrawingInfo>> drawings_per_frame{};

@@ -1669,0 +1866,4 @@
+    const int active_layer_index = it - layers.begin();
+
+    IndexMaskMemory memory;
+    Array<LayerSelectionInfo> selections_by_layer = obtain_selections_by_layer(

@@ -1671,0 +1677,4 @@
+static void GREASE_PENCIL_OT_stroke_from_selection(wmOperatorType *ot)
+{
+  ot->name = "Create Stroke";
+  ot->idname = "GREASE_PENCIL_OT_stroke_from_points";

@@ -0,0 +232,4 @@
+
+  bool changed = false;
+
+  Map<int, Vector<MutableDrawingInfo>> drawings_per_frame;

@@ -0,0 +241,4 @@
+
+  const Layer *active_layer = grease_pencil.get_active_layer();
+  if (active_layer == nullptr) {
+    return OPERATOR_FINISHED;

@@ -0,0 +269,4 @@
+    }
+
+    const int dst_initial_points_num = dst_curves.points_num();
+    dst_curves.resize(dst_initial_points_num + selected_points, dst_curves.curves_num() + 1);

@@ -386,0 +387,4 @@
+   * Appends the passed curves to this one, by making a copy of its data.
+   * The new strokes are appended after the existing ones
+   */
+  void append(const CurvesGeometry &other);

@@ -392,0 +399,4 @@
+   * Change the direction of selected points (switch the start and end) without changing their
+   * shape.
+   */
+  void reverse_points(const IndexMask &points_to_reverse);

@@ -1422,0 +1423,4 @@
+/** \name Stroke From Points Operator
+ * \{ */
+
+extern int(grease_pencil_join_selection_exec)(bContext *C, wmOperator *op);

@@ -0,0 +23,4 @@
+
+namespace blender::ed::greasepencil {
+
+namespace {

@@ -0,0 +35,4 @@
+  bool belongs_to_active_layer;
+};
+
+enum class ACTION_ON_NEXT_RANGE { NOTHING, REVERSE_EXISTING, REVERSE_ADDITION, REVERSE_BOTH };

@@ -0,0 +44,4 @@
+ *
+ *  A range of points is defined as a group contiguous and visually connected points
+ */
+std::pair<Vector<PointsRange>, int64_t> retrieve_selection_ranges(

@@ -0,0 +46,4 @@
+ */
+std::pair<Vector<PointsRange>, int64_t> retrieve_selection_ranges(
+    Object &object,
+    Span<MutableDrawingInfo> drawings,

@@ -0,0 +104,4 @@
+}
+
+void apply_action(ACTION_ON_NEXT_RANGE action,
+                  IndexRange current_range,

@@ -0,0 +105,4 @@
+
+void apply_action(ACTION_ON_NEXT_RANGE action,
+                  IndexRange current_range,
+                  IndexRange adding_range,

@@ -0,0 +138,4 @@
+ *  - first: the index of the closest range
+ *  - second: the action to take
+ */
+std::pair<int64_t, ACTION_ON_NEXT_RANGE> compute_closest_range_to(PointsRange &range,

@@ -0,0 +156,4 @@
+  int64_t ret_value = starting_from;
+  ACTION_ON_NEXT_RANGE action = ACTION_ON_NEXT_RANGE::NOTHING;
+
+  for (int64_t i = starting_from; i < ranges.size(); i++) {

@@ -0,0 +159,4 @@
+  for (int64_t i = starting_from; i < ranges.size(); i++) {
+    const auto [range_begin, range_end] = get_range_begin_end(ranges[i]);
+
+    float dist = len_squared_v3v3(cur_range_end, range_begin);

@@ -0,0 +242,4 @@
+  int next_point_index = 0;
+  copy_range_to_dst(first_range, next_point_index, dst_curves);
+
+  for (std::size_t i = 1; i < selected_ranges.size(); i++) {

@@ -0,0 +274,4 @@
+  }();
+
+  const bke::CurvesGeometry &src_curves = *src_range.owning_curves;
+  const Array points_map = src_curves.point_to_curve_map();

@@ -0,0 +364,4 @@
+  BLI_assert(opt_layer_index.has_value());
+  const int active_layer_index = *opt_layer_index;
+
+  IndexMaskMemory memory;

@@ -0,0 +375,4 @@
+  auto [ranges_selected, selected_points_count] = retrieve_selection_ranges(
+      *object, retrieve_editable_drawings(*scene, grease_pencil), active_layer_index, memory);
+  if (ranges_selected.size() <= 1) {
+    // Nothing to join

@@ -0,0 +380,4 @@
+  }
+
+  // Temporary geometry where to perform the logic
+  // Once the it gets stable, it is appended all at once to the destination curves

@@ -0,0 +318,4 @@
+  }
+}
+
+void remove_selected_points_in_active_layer(Span<PointsRange> ranges_selected,

@@ -0,0 +291,4 @@
+                              dst_curve_offsets,
+                              IndexMask({first_selected_curve, 1}),
+                              dst_curves.attributes_for_write());
+  dst_curves.cyclic_for_write()[0] = false;