GPv3: Merge Points #113582

New Issue

Pratik Borhade · 2023-10-12T12:04:19+02:00

Pratik Borhade commented

2023-10-12 12:04:19 +02:00

Create new stroke of selected points in active layer

Define GREASE_PENCIL_OT_stroke_merge operator in grease_pencil_edit.cc
Retrieve geometry of active layer at current frame
- Get drawing_index from frame number: active_layer->drawing_index_at(scene->r.cfra);
- Use drawing_index to get active drawing: grease_pencil.drawing(index)
- Get geometry: bke::CurvesGeometry &act_layer_curves = drawing.strokes_for_write();
Iterate through all the drawings at current scene frame (foreach_editable_drawing)
- Get geometry of current drawing:
- Handle selection of point/curve modes separately: ED_grease_pencil_selection_domain_get
- for points mode:
- Get selected points (maybe curves::retrieve_selected_points?)
- Include these points in active-layer geometry = act_layer_curves.resize()
- Update offset value, copy attributes of selected points to act_layer_curves (i.e. offset, position, radius, selection etc.)
- Do similar for stroke mode.
Resize the geometry

Legacy GP has some operator properties: mode, draw on back, cyclic, clear point, clear stroke
We can include them in GPv3.

By default new stroke will appear in front. For "draw on back", new stroke should be added at the first offset index
For clear stroke, CurvesGeometry::remove_curves
For dissolve points: CurvesGeometry::remove_curves (in case we want to delete points, remove_points_and_split defined in #111571 can be used)

Create new stroke of selected points in active layer - Define `GREASE_PENCIL_OT_stroke_merge` operator in `grease_pencil_edit.cc` - Retrieve geometry of active layer at current frame - Get drawing_index from frame number: `active_layer->drawing_index_at(scene->r.cfra);` - Use drawing_index to get active drawing: `grease_pencil.drawing(index)` - Get geometry: `bke::CurvesGeometry &act_layer_curves = drawing.strokes_for_write();` - Iterate through all the drawings at current scene frame (`foreach_editable_drawing`) - Get geometry of current drawing: - Handle selection of point/curve modes separately: `ED_grease_pencil_selection_domain_get` - for points mode: - Get selected points (maybe `curves::retrieve_selected_points`?) - Include these points in active-layer geometry = `act_layer_curves.resize()` - Update offset value, copy attributes of selected points to `act_layer_curves ` (i.e. offset, position, radius, selection etc.) - Do similar for `stroke` mode. - Resize the geometry Legacy GP has some operator properties: `mode`, `draw on back`, `cyclic`, `clear point`, `clear stroke` We can include them in GPv3. - By default new stroke will appear in front. For "draw on back", new stroke should be added at the first offset index - For `clear stroke`, `CurvesGeometry::remove_curves` - For dissolve points: `CurvesGeometry::remove_curves` (in case we want to delete points, `remove_points_and_split` defined in https://projects.blender.org/blender/blender/pulls/111571 can be used)

Pratik Borhade added the

labels 2023-10-12 12:04:20 +02:00

Pratik Borhade added this to the Grease Pencil project 2023-10-12 12:08:32 +02:00

Pratik Borhade added

and removed

labels 2023-10-12 12:49:30 +02:00

Pratik Borhade added the

Module

Grease Pencil

label 2023-10-12 13:01:59 +02:00

Falk David referenced this issue

2023-10-25 18:43:46 +02:00

GPv3: Community Tasks: Overview #114158

Pedro commented

2023-12-15 23:23:50 +01:00

I'd like to work on this if no one else already is. I'm a first-time contributor so it can take a bit.

👍 1

~~Pedro referenced this issue 2024-01-02 23:10:59 +01:00~~

GPv3: Merge Points #116726

Pedro commented

2024-01-02 23:18:40 +01:00

Just opened PR with current state. I still have to do the strokes version, and the undo mechanism, and probably there is some bug. But I hope the changes so far match the requirements. Any feedback about the code will be welcome.

Just opened [PR ](https://projects.blender.org/blender/blender/pulls/116726) with current state. I still have to do the strokes version, and the undo mechanism, and probably there is some bug. But I hope the changes so far match the requirements. Any feedback about the code will be welcome.

casey-bianco-davis referenced this issue

2024-01-03 22:03:03 +01:00

GPv3: Merge Points #116726

Pratik Borhade referenced this issue

2024-01-04 11:29:58 +01:00

GPv3: Merge Points #116726

Pedro referenced a pull request that will close this issue

2024-01-05 00:15:29 +01:00

GPv3: Merge Points #116726

Pedro referenced a pull request that will close this issue

2024-02-06 20:02:19 +01:00

GPv3: Join Operator #117916