mont29/blender
0
0
Fork 0
forked from blender/blender
Code Pull Requests Activity

USD: Fix Export progress report. #2

Closed
Bastien Montagne wants to merge 1 commits from tmp-usd-export-fix-wqprogress-report into tmp-usd-fix-deg-export-crash
pull from: tmp-usd-export-fix-wqprogress-report
merge into: mont29:tmp-usd-fix-deg-export-crash

When changing the target branch, be careful to rebase the branch in your fork to match. See documentation.
Conversation 0 Commits 1 Files Changed 1 +46 -3
Bastien Montagne commented 2023-10-11 13:11:44 +02:00
Owner
Copy Link

This progress report was utterly broken and useless when not exporting
animations, and not great either with animation export. This commit
fixes:

  • Not generating any progress report when exporting a single frame.
  • Assuming actual data export covers 100% of progress.

That last point is the biggest change, now actual export (be it
animated or still) only covers 75% of the whole range. The rest is used
to cover depsgraph building and updates (which can be noticiably slow
with big scenes), stage writing, etc.

Progression is still far from linear in time, but at least it gives
better feedback on actual progress of the whole export.

NOTE: based on changes from !113537

This progress report was utterly broken and useless when not exporting animations, and not great either with animation export. This commit fixes: * Not generating any progress report when exporting a single frame. * Assuming actual data export covers 100% of progress. That last point is the biggest change, now actual export (be it animated or still) only covers 75% of the whole range. The rest is used to cover depsgraph building and updates (which can be noticiably slow with big scenes), stage writing, etc. Progression is still far from linear in time, but at least it gives better feedback on actual progress of the whole export. ---------------------- NOTE: based on changes from !113537
Bastien Montagne added 1 commit 2023-10-11 13:12:04 +02:00 
This progress report was utterly broken and useless when not exporting
animations, and not great either with animation export. This commit
fixes:
* Not generating any progress report when exporting a single frame.
* Assuming actual data export covers 100% of progress.

That last point is the biggest change, now actual export (be it
animated or still) only covers 75% of the whole range. The rest is used
to cover depsgraph building and updates (which can be noticiably slow
with big scenes), stage writing, etc.

Progression is still far from linear in time, but at least it gives
better feedback on actual progress of the whole export.
Bastien Montagne closed this pull request 2023-10-12 19:10:47 +02:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: mont29/blender#2
No description provided.
Delete Branch "tmp-usd-export-fix-wqprogress-report"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?