mont29/blender
0
0
Fork 0
forked from blender/blender
Code Pull Requests Activity

Fix #102103: Copy/Paste of nodes is not handling ID references properly. #3

Closed
Bastien Montagne wants to merge 1 commits from tmp-node-copypaste into tmp-libquery-subdata-foreachid
pull from: tmp-node-copypaste
merge into: mont29:tmp-libquery-subdata-foreachid

When changing the target branch, be careful to rebase the branch in your fork to match. See documentation.
Conversation 0 Commits 1 Files Changed 1 +188 -40
Bastien Montagne commented 2024-04-26 12:46:23 +02:00
Owner
Copy Link

This commit fixes several critical issues with previous code:

  • It only covered a (very small) subset of potential ID references in a
    node (namely, just the bNode::id pointer).
  • It completely ignored linked data case.
  • It would modify ID pointers in the clipboard itself.

The new code stores ID reference info in a separate mapping. It uses the
new 'sub-data' foreach_id feature from BKE_lib_query to reliably and
generically process all ID pointers of a node.

The paste handling of ID pointers is split in two steps:

  • All knowns ID references are searched for in current Main data-base,
    and the result (current valid ID pointer or null if not found) is
    stored temporarily in the ID references mapping.
  • Once a node has been duplicated from the clipboard into the paste
    destination nodetree, its ID pointers are updated accordingly.

This allows to keep the 'reference ID' data in the clipboard always
valid, regardless of which IDs are currently existing in Main (i.e. to
keep all available data, even when opening new blendfiles, or doing
undo/redo that would affect the existing IDs).

This commit fixes several critical issues with previous code: * It only covered a (very small) subset of potential ID references in a node (namely, just the `bNode::id` pointer). * It completely ignored linked data case. * It would modify ID pointers in the clipboard itself. The new code stores ID reference info in a separate mapping. It uses the new 'sub-data' foreach_id feature from `BKE_lib_query` to reliably and generically process all ID pointers of a node. The paste handling of ID pointers is split in two steps: * All knowns ID references are searched for in current Main data-base, and the result (current valid ID pointer or null if not found) is stored temporarily in the ID references mapping. * Once a node has been duplicated from the clipboard into the paste destination nodetree, its ID pointers are updated accordingly. This allows to keep the 'reference ID' data in the clipboard always valid, regardless of which IDs are currently existing in Main (i.e. to keep all available data, even when opening new blendfiles, or doing undo/redo that would affect the existing IDs).
Bastien Montagne added 1 commit 2024-04-26 12:46:46 +02:00 
This commit fixes several critical issues with previous code:
* It only covered a (very small) subset of potential ID references in a
  node (namely, just the `bNode::id` pointer).
* It completely ignored linked data case.
* It would modify ID pointers in the clipboard itself.

The new code stores ID reference info in a separate mapping. It uses the
new 'sub-data' foreach_id feature from `BKE_lib_query` to reliably and
generically process all ID pointers of a node.

The paste handling of ID pointers is split in two steps:
* All knowns ID references are searched for in current Main data-base,
  and the result (current valid ID pointer or null if not found) is
  stored temporarily in the ID references mapping.
* Once a node has been duplicated from the clipboard into the paste
  destination nodetree, its ID pointers are updated accordingly.

This allows to keep the 'reference ID' data in the clipboard always
valid, regardless of which IDs are currently existing in Main (i.e. to
keep all available data, even when opening new blendfiles, or doing
undo/redo that would affect the existing IDs).
Bastien Montagne closed this pull request 2024-04-26 12:47:35 +02:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: mont29/blender#3
No description provided.
Delete Branch "tmp-node-copypaste"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?