- Amsterdam, The Netherlands
-
Blender developer, mainly focused on 'Core' module.
- Joined on
2010-10-07 -
-
While this change may be fine in current status of node code, I have tow concerns:
I don't think this will handle properly cases with more than one string passed to the constructor, like in b.add_input<decl::Float>("Value", "Value_001") ?
Feature makes sense to me, and code looks good. Comments below are mainly for style/formatting issues.
Should be "translation_context=\"*\", " I think?
broken format, should be on two different lines.
avoid wrapping multiple variables declarations over more than one line. Better to keep it on one line, and repeat the type for the next line.
Have the feeling there are more changes than needed here... Also not sure about the rational of adding contexts to strings like "Mode" or "Type"?
Don't understand the need for this change (and the one above)? Doubt there is any conflict with any other usage/meanings here?
Don't think that one is needed here, 'light' is in color context here...
Uuuuh nice finding, thanks a lot! And great explanations once again. :D
Nice that we can get rid of this extra level of complexity here!
I unfortunately cannot remember the details of the reproducible case, hit the crash in some production file from the studio while working on something else as far as I can remember. But in general…