Think you should create new PR, if I checkout that PR it still has massive differences from actual current main...
Unfortunately gitea does not seem to handle this very well still...
Not ideal, but would leave here for now 9for that reason of keeping existing messages order as stable as possible).
This also seems to not be properly rebased on current main?
You also need to rebase your branch on main
, and force-push it I think? At least right now they seem to be in conflict...
Think at least for now we can hope this composite method will work well enough yes... Explicit full strings would be fairly annoyingly verbose.
Am wondering about how much speed differences we are talking about here... because this double codepath handling for a same thing has a significant impact on readability and maintainability, so would only consider it necessary if we are talking about real use-cases where the difference would be in tens of seconds on edge-cases, or at least seconds in more common cases?