Joerg Mueller neXyon
1 Followers · 0 Following
  • Joined on 2009-02-04
Repositories
1
 Projects Public Activity Starred Repositories
Joerg Mueller approved blender/blender#130566 2024-11-20 23:38:27 +01:00
CMake: Fix Deprecation Warning in audaspace
Joerg Mueller commented on pull request blender/blender#129312 2024-10-24 09:41:26 +02:00
Fix #129162: High idle CPU usage with PulseAudio in Linux

Yep, its' alright. The pa main loop only needs to be locked during the flush and cork calls. It doesn't matter if m_corked is written while it's locked or not as it is not accessed by the main…

Joerg Mueller commented on pull request blender/blender#129312 2024-10-22 15:51:46 +02:00
Fix #129162: High idle CPU usage with PulseAudio in Linux

I wouldn't be able to test this, as I don't have an easy access to Linux machines at this time.

The PR would definitely benefit from more explanation of what's going on, and what the fix…

Joerg Mueller created pull request blender/blender#129312 2024-10-21 20:27:39 +02:00
Fix #129162: High idle CPU usage with PulseAudio in Linux
Joerg Mueller pushed to fix_129162 at neXyon/blender 2024-10-21 20:25:46 +02:00
90eb5688d2 Fix #129162: High idle CPU usage with PulseAudio in Linux
Joerg Mueller created branch fix_129162 in neXyon/blender 2024-10-21 20:25:46 +02:00
Joerg Mueller created repository neXyon/blender 2024-10-21 20:21:39 +02:00
Joerg Mueller pushed to main at blender/blender 2024-10-21 00:54:03 +02:00
3b8bd516e9 Fix #129162: High idle CPU usage with PulseAudio in Linux
Joerg Mueller closed issue blender/blender#129162 2024-10-21 00:54:01 +02:00
High idle CPU usage with PulseAudio in Linux
Joerg Mueller commented on pull request blender/blender#126047 2024-09-12 22:30:04 +02:00
WIP: Try to fix Coreaudio playback cancel issues

@neXyon That is actually a good find!

Unfortunately, with CoreAudio the issue is only partially resolved: after the cancel the scene is advanced one frame forward. So if you start…

Joerg Mueller commented on pull request blender/blender#126047 2024-09-12 22:27:16 +02:00
WIP: Try to fix Coreaudio playback cancel issues

Thanks for the detailed explanation! With these your code changes are much easier to follow. You are right, it is much better to have Blender actually react fully to the synchronization callback…

Joerg Mueller commented on pull request blender/blender#126091 2024-09-12 20:58:56 +02:00
WIP: Pipewire audio backend, sound system fixes.

Thanks for the upstream PRs! To make things simpler, I would like to continue the review/discussion of upstream changes there. As soon as the PRs are merged upstream we can commit those changes to…

Joerg Mueller approved blender/blender#127203 2024-09-10 21:05:16 +02:00
Fix FFmpeg deprecation warnings

The audaspace part is fine I guess. I still suggest considering uping the minimum required ffmpeg version to get rid of old code instead of adding more ifdefs. Also note that there are these two PRs: #121947 and #121960.

Joerg Mueller commented on pull request blender/blender#126047 2024-08-31 19:32:06 +02:00
WIP: Try to fix Coreaudio playback cancel issues

Ok, I figured out that you mean pressing the Escape key which cancels playback running screen_animation_cancel_exec. It appears that the first issue is at play here: AUD_seekSynchronizer is…

Joerg Mueller commented on pull request blender/blender#126047 2024-08-31 18:27:18 +02:00
WIP: Try to fix Coreaudio playback cancel issues

I have never had that behavior, Blender always stops right where it is, when I pause playback (with Spacebar or the Pause button in the Timeline). Can you tell me how you trigger the behavior that…

Joerg Mueller commented on pull request blender/blender#126047 2024-08-23 15:13:49 +02:00
WIP: Try to fix Coreaudio playback cancel issues

@neXyon I should have clarified a few things, sorry:

  1. CoreAudio. The issue here was that the CoreAudio backend used (by mistake) the same code paths as JACK on the Blender side of…
Joerg Mueller commented on pull request blender/blender#126091 2024-08-20 22:19:50 +02:00
WIP: Pipewire audio backend, sound system fixes.

Have a nice vacation then! :)

Ok, if you think that's the way to go, I don't have any good reasons to object. All good!

Joerg Mueller commented on pull request blender/blender#126047 2024-08-20 22:18:25 +02:00
WIP: Try to fix Coreaudio playback cancel issues

I have a hard time reviewing this, since I don't even know which problem this PR is supposed to solve? The title speaks about CoreAudio and then there are lots of changes in Jack and none in…

Joerg Mueller approved blender/blender#126091 2024-08-15 19:34:11 +02:00
WIP: Pipewire audio backend, sound system fixes.

That's a nice surprise for a PR!

Joerg Mueller commented on issue blender/blender#125881 2024-08-06 18:00:59 +02:00
Does Blender support build with MSVC under c++20 or c++latest ?

I fixed the audaspace part of this.