Joerg Mueller neXyon
1 Followers · 0 Following
  • Joined on 2009-02-04
Repositories Projects Public Activity Starred Repositories
Joerg Mueller commented on pull request blender/blender#126047 2024-09-12 22:30:04 +02:00
WIP: Try to fix Coreaudio playback cancel issues

@neXyon That is actually a good find!

Unfortunately, with CoreAudio the issue is only partially resolved: after the cancel the scene is advanced one frame forward. So if you start…

Joerg Mueller commented on pull request blender/blender#126047 2024-09-12 22:27:16 +02:00
WIP: Try to fix Coreaudio playback cancel issues

Thanks for the detailed explanation! With these your code changes are much easier to follow. You are right, it is much better to have Blender actually react fully to the synchronization callback…

Joerg Mueller commented on pull request blender/blender#126091 2024-09-12 20:58:56 +02:00
WIP: Pipewire audio backend, sound system fixes.

Thanks for the upstream PRs! To make things simpler, I would like to continue the review/discussion of upstream changes there. As soon as the PRs are merged upstream we can commit those changes to…

Joerg Mueller approved blender/blender#127203 2024-09-10 21:05:16 +02:00
Fix FFmpeg deprecation warnings

The audaspace part is fine I guess. I still suggest considering uping the minimum required ffmpeg version to get rid of old code instead of adding more ifdefs. Also note that there are these two PRs: #121947 and #121960.

Joerg Mueller commented on pull request blender/blender#126047 2024-08-31 19:32:06 +02:00
WIP: Try to fix Coreaudio playback cancel issues

Ok, I figured out that you mean pressing the Escape key which cancels playback running screen_animation_cancel_exec. It appears that the first issue is at play here: AUD_seekSynchronizer is…

Joerg Mueller commented on pull request blender/blender#126047 2024-08-31 18:27:18 +02:00
WIP: Try to fix Coreaudio playback cancel issues

I have never had that behavior, Blender always stops right where it is, when I pause playback (with Spacebar or the Pause button in the Timeline). Can you tell me how you trigger the behavior that…

Joerg Mueller commented on pull request blender/blender#126047 2024-08-23 15:13:49 +02:00
WIP: Try to fix Coreaudio playback cancel issues

@neXyon I should have clarified a few things, sorry:

  1. CoreAudio. The issue here was that the CoreAudio backend used (by mistake) the same code paths as JACK on the Blender side of…
Joerg Mueller commented on pull request blender/blender#126091 2024-08-20 22:19:50 +02:00
WIP: Pipewire audio backend, sound system fixes.

Have a nice vacation then! :)

Ok, if you think that's the way to go, I don't have any good reasons to object. All good!

Joerg Mueller commented on pull request blender/blender#126047 2024-08-20 22:18:25 +02:00
WIP: Try to fix Coreaudio playback cancel issues

I have a hard time reviewing this, since I don't even know which problem this PR is supposed to solve? The title speaks about CoreAudio and then there are lots of changes in Jack and none in…

Joerg Mueller approved blender/blender#126091 2024-08-15 19:34:11 +02:00
WIP: Pipewire audio backend, sound system fixes.

That's a nice surprise for a PR!

Joerg Mueller commented on issue blender/blender#125881 2024-08-06 18:00:59 +02:00
Does Blender support build with MSVC under c++20 or c++latest ?

I fixed the audaspace part of this.

Joerg Mueller pushed to main at blender/blender 2024-08-06 18:00:15 +02:00
fae2195553 Audaspace: merge changes from upstream.
Joerg Mueller commented on issue blender/blender#125011 2024-08-03 11:24:06 +02:00
Scrubbing on Video Sequencer does not produce sound if scrbbing spans only a few frames

Should be fixed. Please test and let me know in case the issue is still present!

Joerg Mueller pushed to main at blender/blender 2024-08-03 11:23:27 +02:00
e6178be3b8 Fix #125011: Scrubbing not producing audio output
a235a18aca Audaspace: port changes from upstream.
Compare 2 commits »
Joerg Mueller closed issue blender/blender#125011 2024-08-03 11:23:26 +02:00
Scrubbing on Video Sequencer does not produce sound if scrbbing spans only a few frames
Joerg Mueller pushed to main at blender/blender 2024-06-13 21:22:40 +02:00
c810d1413d PyAPI Doc: fix doc gen warning wrt loadLeftHrtfSet
Joerg Mueller merged pull request blender/blender#123147 2024-06-13 21:22:40 +02:00
PyAPI Doc: fix doc gen warning wrt loadLeftHrtfSet
Joerg Mueller commented on pull request blender/blender#122149 2024-05-24 00:35:22 +02:00
Fix #121719: Sound does not play when playback starts outside of strip

I pushed it upstream, thanks.

Joerg Mueller approved blender/blender#122149 2024-05-23 21:21:58 +02:00
Fix #121719: Sound does not play when playback starts outside of strip

Great, thanks for the fix!

Joerg Mueller commented on pull request blender/blender#121948 2024-05-19 21:20:27 +02:00
Update Audaspace to 1.5.0 for FFmpeg 7.0

Thanks for that thorough investigation! That should help with the decision. Maybe one more question: do you know which versions of blender these distros ship?