@ideasman42 how would you like to solve this issue? I see three options:
- keep as is to not break anything depending on it
- change the behavior to work correctly (i.e. negate `rna_Scene_use…
Overall changes look good now! I've added some comments inline of what I'd like to see changed still and additionally:
I dislike the hardcoding of this value, especially since it reappears just a few lines below again. Maybe you could turn this into a proper variable and even base it on some other value that makes sense (see e.g. sleep_duration in WASAPIDevice.cpp:95).
Please don't mix std::chrono code with ctime code, just use std::chrono everywhere!
Not sure what you mean? Do you mean running clang-format as auto-formatter? Clang format can also be run on just the changes in a diff which would be ideal here. So, can you apply the cleanup…
Please fix the formatting first as I mentioned before, otherwise it's hard to read the diff.
-1 signals that there is actually no synchronizer working (that's what the DefaultSynchronizer does). Coreaudio and jack do have proper synchronizer support, so they are supposed to return 0 or…
aud Python module instance methods are documented as classmethods
I have reverted changes in Audaspace, I am trying to resolve some build issues on Windows at least still.
Great! I assume once the build issues are resolved, the changes to audaspace's…
Please follow the code style of audaspace and do not apply Blender's clang format in this file. This leads to way too many changes in this file. Audaspace has it's own clang format changes, but you should only format actually changed code.
As I've written on developers.blender.org before accepting this patch I would like any changes to audaspace reverted. Everything necessary is in there already (in upstream audaspace and also ported to blender) and we need fftw3f (the float version not the double version) as a new dependency, since using fftw3d (the double version) is unnecessary here. Afaik, it is possible to have both versions of the library in one project. I've stated a couple of times already on developers.blender.org that the package maintainers have to be contacted to get fftw3f in.
I've added two name change suggestions, just fixing their styling.