nrupsis
/
blender
forked from blender/blender
0
0
Fork 0
Code Pull Requests Activity

WIP: just adding in the Phab DIFF to local repo to easily see what's left to refactor #2

Closed
Nate Rupsis wants to merge 1 commits from NLA-refactor-diff into main
pull from: NLA-refactor-diff
merge into: nrupsis:main

When changing the target branch, be careful to rebase the branch in your fork to match. See documentation.
Conversation 1 Commits 1 Files Changed 21 +9899 -38
Nate Rupsis commented 2023-02-13 19:02:08 +01:00
Owner
Copy Link

NLA refactor

Ref to old phab diff: https://archive.blender.org/developer/D10101

  1. First refactor

    • BKE_nlastrips_add_strip_unsafe (instead of BKE_nlastrips_try_add_strip)

  2. Second Refactor

    • BKE_nlatrack_remove_strip
    • BKE_nlastrip_remove
    • BKE_nlastrip_remove_and_free

  3. Third Refactor

    • BKE_nlatrack_removes
    • BKE_nlatrack_remove_and_free

TODO

  • struct NlaTrack *BKE_nlatrack_new(); (I think this can either be removed, or it needs some refactoring
  • BKE_nlatrack_remove
  • BKE_nlatrack_remove_and_free
  • BKE_nlatrack_insert_after
  • BKE_nlatrack_insert_before
  • BKE_nlatrack_new_after_and_set_active
  • BKE_nlatrack_new_before_and_set_active
  • BKE_nlatrack_new_tail_and_set_active
  • BKE_nlatrack_new_head_and_set_active
  • BKE_nlatrack_new_head_and_set_active
  • BKE_nlameta_try_add_strip // I don't think this needs to be done
## NLA refactor Ref to old phab diff: https://archive.blender.org/developer/D10101 1. [First refactor](https://projects.blender.org/blender/blender/commit/f31ad5d98b3aa0697b5b1d477f7d58791ac19f97) * BKE_nlastrips_add_strip_unsafe (instead of BKE_nlastrips_try_add_strip) 2. [Second Refactor](https://projects.blender.org/blender/blender/pulls/104437) * BKE_nlatrack_remove_strip * BKE_nlastrip_remove * BKE_nlastrip_remove_and_free 3. [Third Refactor](https://projects.blender.org/blender/blender/pulls/104752) * BKE_nlatrack_removes * BKE_nlatrack_remove_and_free ## TODO - [x] struct NlaTrack *BKE_nlatrack_new(); (I think this can either be removed, or it needs some refactoring - [x] BKE_nlatrack_remove - [x] BKE_nlatrack_remove_and_free - [x] BKE_nlatrack_insert_after - [x] BKE_nlatrack_insert_before - [x] BKE_nlatrack_new_after_and_set_active - [x] BKE_nlatrack_new_before_and_set_active - [x] BKE_nlatrack_new_tail_and_set_active - [x] BKE_nlatrack_new_head_and_set_active - [x] BKE_nlatrack_new_head_and_set_active - [x] BKE_nlameta_try_add_strip // I don't think this needs to be done
Nate Rupsis added 1 commit 2023-02-13 19:02:10 +01:00
Nate Rupsis commented 2023-03-14 17:50:17 +01:00
Author
Owner
Copy Link

Everything is completed and merged in!

Everything is completed and merged in!
Nate Rupsis closed this pull request 2023-03-14 17:50:18 +01:00

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: nrupsis/blender#2
No description provided.
Delete Branch "NLA-refactor-diff"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?