93d3b64772
Fix: Add Mesh Extra Objects: Inverted normals of solids when vertex positions are inverted
Looks good to me!
I didn't know about
bmesh, and that's definitely a better and cleaner approach than what I was doing with updating and restoring the current selection.
Great that you learned something…
It seems to work and I would prefer this to recalculating normals afterwards,
You’re right, it’s not as hard as I thought it would be and your fix is better.
I found another issue,…
I had a look at this. When vertex truncation is > 1.0, the truncated polyhedron is computed using a mirrored (scaled -1.0) dual of the base polyhedron. Dual themselves are mirrored as well. I…
Ah, interesting! My understanding is that short names are used both for display and input, while alt names only for input. My concern in this PR is mostly to use accurate unit symbols, but also to…
- The fix works well, but I don’t really like seeing single quotes when double quotes are used everywhere else, and are the convention for Blender. Also this would make existing translations…
Sorry about that, I just pushed a fix. Thanks for the review.
Should be all right now, the first commit contains only the core changes.
FYI since you also work a lot on this tool these days, and in case you want to check. For me it's good to go.
This change makes sense at a glance, I’ll test it tomorrow.