Sahar A. Kashi salipour
  • Joined on 2022-02-10
Sahar A. Kashi commented on issue blender/blender#120702 2024-06-12 18:10:29 +02:00
Cycles HIP-RT Memory leak

We can do that, but it will require the user to update their driver (no Blender change is required). We are working to get open-sourced HIP-RT integrated in Blender 4.3 and eliminate any driver…

Sahar A. Kashi created branch hiprt2.2_main in salipour/AMD_HIPRT 2024-06-12 01:20:21 +02:00
Sahar A. Kashi pushed to hiprt2.2_main at salipour/AMD_HIPRT 2024-06-12 01:20:21 +02:00
bd187874bf Merge HIPRT_OPEN_SOURCE branch into main
Sahar A. Kashi pushed to main at salipour/AMD_HIPRT 2024-06-12 01:07:01 +02:00
8726157489 Sculpt: Initial data oriented refactor for nudge brush
c5864a3dcb Sculpt: Initial data oriented refactor for inflate brush
bfb7918ac5 Cleanup: Sculpt: Avoid repeated access of CCG position
c93c7cbc4c Sculpt: Initial data oriented refactor for flatten brush
22788ad1cf Merge branch 'blender-v4.2-release'
Compare 3773 commits »
Sahar A. Kashi commented on issue blender/blender#120702 2024-06-11 21:14:22 +02:00
Cycles HIP-RT Memory leak

The issue is now resolved in the latest HIP-RT SDK. I think it is too late to push it to Blender 4.2 . I expect it to become available in Blender 4.3.

Sahar A. Kashi commented on pull request blender/blender#121050 2024-06-11 20:52:37 +02:00
Cycles: Linux Support for HIP-RT

easy-encription is no longer needed. Thanks for the feedback. We'll update the HIP-RT and let you know.

Sahar A. Kashi commented on pull request blender/blender#121050 2024-06-11 17:22:48 +02:00
Cycles: Linux Support for HIP-RT

@brecht
HIP-RT has been updated and now the changes are public: https://github.com/GPUOpen-LibrariesAndSDKs/HIPRT/releases Let me know if there is any pending task from AMD side.

Sahar A. Kashi commented on issue blender/blender#120702 2024-06-04 01:35:13 +02:00
Cycles HIP-RT Memory leak

It seems the leak is somewhere in the hiprt runtime. I will keep you posted.

Sahar A. Kashi commented on issue blender/blender#120702 2024-05-29 22:15:16 +02:00
Cycles HIP-RT Memory leak

@salipour Have you had a chance to look at this? Can you reproduce the issue?

Sort of. Frame one was using around under 6 GB and by frame 50, the usage had increased to 8 GB. Is it an issue…

Sahar A. Kashi commented on pull request blender/blender#121050 2024-05-28 21:12:52 +02:00
Cycles: Linux Support for HIP-RT

Ah yes, technically we don't even need the .lib with the current implementation. We should add a comment about this though.

I wasn't sure if it would be best to patch hiprt to not include…

Sahar A. Kashi commented on pull request blender/blender#121050 2024-05-28 18:24:43 +02:00
Cycles: Linux Support for HIP-RT

I forgot the C++20 issue. @salipour we could also use help to make HIPRT build with C++17. That's the version used by the VFX reference platform (https://vfxplatform.com/) that Blender and other…

Sahar A. Kashi commented on pull request blender/blender#121050 2024-05-28 18:20:50 +02:00
Cycles: Linux Support for HIP-RT
  • The trick of renaming the library to get rid of the version number in it, doesn't work on windows, there's always a .lib and .dll pair, and the .lib will have full name of the dll embedded in…
Sahar A. Kashi commented on pull request blender/blender#121050 2024-05-23 02:06:42 +02:00
Cycles: Linux Support for HIP-RT

I gotta admit i'm a bit confused this got put up for review given the state it is in.

Well, that was the advice, to quickly put something together and make a WIP pull request. Anyway, let me…

Sahar A. Kashi commented on pull request blender/blender#121050 2024-05-23 01:13:01 +02:00
Cycles: Linux Support for HIP-RT

It's not clear to me which build options should be enabled. There were a bunch listed in the original code, but which ones do we actually want to set, and how?

Let me check with HIPRT team…

Sahar A. Kashi commented on pull request blender/blender#121050 2024-05-22 21:26:03 +02:00
Cycles: Linux Support for HIP-RT

Sorry for asking here, but expected to be in blender 4.2 release? or 4.3+

4.2

Sahar A. Kashi commented on pull request blender/blender#121050 2024-05-22 18:16:31 +02:00
Cycles: Linux Support for HIP-RT

@brecht I made changes according to the feedback. What's the next step to move forward with this pull request?

Sahar A. Kashi pushed to HIPRT_OPEN_SOURCE at salipour/AMD_HIPRT 2024-05-22 18:12:33 +02:00
a95b14a621 reverting submodule
Sahar A. Kashi pushed to HIPRT_OPEN_SOURCE at salipour/AMD_HIPRT 2024-05-02 02:52:54 +02:00
d675edf94a HIPRT Linux, Code Review #1
Sahar A. Kashi commented on pull request blender/blender#121050 2024-05-02 01:00:02 +02:00
Cycles: Linux Support for HIP-RT

The main intention was to check if the dynamic library for hiprt exists before enabling it.