Blender Kitsu: Shot Builder assertion error #93

New Issue

johan tri handoyo · 2023-06-23T02:30:00+02:00

johan tri handoyo commented

2023-06-23 02:30:00 +02:00

So, I successfully make the correct project folder and make the shot builder addon work, and it shows the new shot menu

But after I click OK, another error appears regarding the editorial path.

Shot builder is dependant on a valid editorial export path and file pattern.
Check Preferences, errors appear in console

Can you elaborate on this issue, since it has very little documentation on editorial except for this file structure tutorial https://studio.blender.org/pipeline/td-guide/project-setup

PS: I'm using spritefright edit_bundle and its character library as a sample of my study. And at the moment I set the folder like this

So, I successfully make the correct project folder and make the shot builder addon work, and it shows the new shot menu ![image](/attachments/473b72fa-02ea-45ae-b6a4-e845d473bb61) But after I click OK, another error appears regarding the editorial path. Shot builder is dependant on a valid editorial export path and file pattern. Check Preferences, errors appear in console Can you elaborate on this issue, since it has very little documentation on editorial except for this file structure tutorial https://studio.blender.org/pipeline/td-guide/project-setup PS: I'm using spritefright edit_bundle and its character library as a sample of my study. And at the moment I set the folder like this ![image](/attachments/aa0327ad-cf04-445c-bf87-1ffd60ae6efb)

image.png

18 KiB

image.png

35 KiB

Nick Alberelli commented

2023-06-23 18:04:35 +02:00

Hey so the files contained in that edit bundle don't match the new naming convention which should be project-name_v001.mp4 but this isn't a great design as it will expect some file to exist there before it will allow this to work, this made sense in the context of some of our productions but I should change this.

I am planning a full re-write of the shot builder in the coming weeks as it has several issues that need to be resolved, and needs to have better error reporting.

Hey so the files contained in that edit bundle don't match the new naming convention which should be` project-name_v001.mp4` but this isn't a great design as it will expect some file to exist there before it will allow this to work, this made sense in the context of some of our productions but I should change this. I am planning a full re-write of the shot builder in the coming weeks as it has several issues that need to be resolved, and needs to have better error reporting.

Nick Alberelli commented

2023-06-23 20:09:24 +02:00

@JohanTriHandoyo I have gone ahead and added a quick commit that removes this dependency, so it should work now, but will skip importing an reference movie from the editorial export folder, unless your your files matches the convention I mentioned earlier.

b0faab5901

Please let me know if this resolves your issue.

@JohanTriHandoyo I have gone ahead and added a quick commit that removes this dependency, so it should work now, but will skip importing an reference movie from the editorial export folder, unless your your files matches the convention I mentioned earlier. https://projects.blender.org/studio/blender-studio-pipeline/commit/b0faab59010f1e126104f6b46aca8649e3c05ff1 Please let me know if this resolves your issue.

Nick Alberelli changed title from ~~How to setup editorial export and the correct file pattern for shot builder?~~ to Blender Kitsu: Invalid Editorial Export Directory

2023-06-23 20:10:45 +02:00

Nick Alberelli added the

Kind: Community

Kind

Bug

labels 2023-06-23 20:11:34 +02:00

johan tri handoyo commented

2023-06-24 02:37:06 +02:00

Unfortunately still has the same error. I'm using the latest commit and double check the operators.py. I'm wondering, for the file naming, does it consider capital letters?

Also happy to hear that you plan to rewrite the whole shot builder, I will patiently be waiting and watch your progress 👍

Unfortunately still has the same error. I'm using the latest commit and double check the operators.py. I'm wondering, for the file naming, does it consider capital letters? Also happy to hear that you plan to rewrite the whole shot builder, I will patiently be waiting and watch your progress 👍

Nick Alberelli commented

2023-06-26 13:49:01 +02:00

Hey @JohanTriHandoyo are you sure you are on the latest commit because I have removed this error message in b0faab5901, so you shouldn't be getting the same error? Can you share exactly what the error is?

Hey @JohanTriHandoyo are you sure you are on the latest commit because I have removed this error message in https://projects.blender.org/studio/blender-studio-pipeline/commit/b0faab59010f1e126104f6b46aca8649e3c05ff1, so you shouldn't be getting the same error? Can you share exactly what the error is?

Nick Alberelli added

and removed

labels 2023-06-26 14:13:44 +02:00

johan tri handoyo commented

2023-06-26 15:36:03 +02:00

Hi Nick, I'm not sure why I get the same error. However, I reinstall my Ubuntu yesterday and use the latest addon in my Blender and I got crashed when I try to create a new shot. Here's the error:

Traceback (most recent call last):
File "/home/johantri/.config/blender/3.3/scripts/addons/blender_kitsu/shot_builder/operators.py", line 207, in execute
shot_builder = ShotBuilder(
File "/home/johantri/.config/blender/3.3/scripts/addons/blender_kitsu/shot_builder/builder/init.py", line 24, in init
assert(shot)
AssertionError
Error: Python: Traceback (most recent call last):
File "/home/johantri/.config/blender/3.3/scripts/addons/blender_kitsu/shot_builder/operators.py", line 207, in execute
shot_builder = ShotBuilder(
File "/home/johantri/.config/blender/3.3/scripts/addons/blender_kitsu/shot_builder/builder/init.py", line 24, in init
assert(shot)
AssertionError

Writing: /tmp/blender.crash.txt
Segmentation fault (core dumped)

I also attached the blender.crash.txt file

Hi Nick, I'm not sure why I get the same error. However, I reinstall my Ubuntu yesterday and use the latest addon in my Blender and I got crashed when I try to create a new shot. Here's the error: Traceback (most recent call last): File "/home/johantri/.config/blender/3.3/scripts/addons/blender_kitsu/shot_builder/operators.py", line 207, in execute shot_builder = ShotBuilder( File "/home/johantri/.config/blender/3.3/scripts/addons/blender_kitsu/shot_builder/builder/__init__.py", line 24, in __init__ assert(shot) AssertionError Error: Python: Traceback (most recent call last): File "/home/johantri/.config/blender/3.3/scripts/addons/blender_kitsu/shot_builder/operators.py", line 207, in execute shot_builder = ShotBuilder( File "/home/johantri/.config/blender/3.3/scripts/addons/blender_kitsu/shot_builder/builder/__init__.py", line 24, in __init__ assert(shot) AssertionError Writing: /tmp/blender.crash.txt Segmentation fault (core dumped) I also attached the blender.crash.txt file

blender.crash.txt

993 B

Nick Alberelli commented

2023-06-27 20:23:19 +02:00

Hey @JohanTriHandoyo this is not the same error with the edit directory this is actually a new more different error.

It appears your shot builder is failing to invoke the hooks that define the shots, but it doesn't give a good error message. I have tried this on my side, and it does continue to work if you have correctly populated the config directory for shot-builder, so there is something wrong with shots.py.

The hope is that in my re-write I will address this and improve the error reporting.

Hey @JohanTriHandoyo this is not the same error with the edit directory this is actually a new more different error. It appears your shot builder is failing to invoke the hooks that define the shots, but it doesn't give a good error message. I have tried this on my side, and it does continue to work if you have correctly populated the config directory for shot-builder, so there is something wrong with `shots.py`. The hope is that in my re-write I will address this and improve the error reporting.

Nick Alberelli changed title from ~~Blender Kitsu: Invalid Editorial Export Directory~~ to Blender Kitsu: Shot Builder assertion error

2023-06-27 22:04:23 +02:00

johan tri handoyo commented

2023-06-29 10:28:34 +02:00

Hi Nick, I am using the same shots.py just like in the doc folder:

from blender_kitsu.shot_builder.shot import Shot
from blender_kitsu.shot_builder.project import Production

class SpriteFrightShot(Shot):
def get_anim_file_path(self, production: Production, shot: Shot) -> str:
"""
Get the animation file path for this given shot.
"""
return self.file_path_format.format_map({
'production': production,
'shot': shot,
'task_type': "anim"
})

def get_output_collection_name(self, shot: Shot, task_type: str) -> str:
    """
    Get the collection name where the output is stored.
    """
    return f"{shot.sequence_code}_{shot.code}.{task_type}.output"

class Sequence_0002(SpriteFrightShot):
sequence_code = "0002"

class Shot_0001_0001_A(Sequence_0002):
name = "001"
code = "0001"

Hi Nick, I am using the same shots.py just like in the doc folder: from blender_kitsu.shot_builder.shot import Shot from blender_kitsu.shot_builder.project import Production class SpriteFrightShot(Shot): def get_anim_file_path(self, production: Production, shot: Shot) -> str: """ Get the animation file path for this given shot. """ return self.file_path_format.format_map({ 'production': production, 'shot': shot, 'task_type': "anim" }) def get_output_collection_name(self, shot: Shot, task_type: str) -> str: """ Get the collection name where the output is stored. """ return f"{shot.sequence_code}_{shot.code}.{task_type}.output" class Sequence_0002(SpriteFrightShot): sequence_code = "0002" class Shot_0001_0001_A(Sequence_0002): name = "001" code = "0001"

shots.py

830 B

Nick Alberelli referenced this issue

2023-06-29 14:57:27 +02:00

Blender Kitsu: Shots pushed from Edit do not have Tasks Status #101

Nick Alberelli commented

2023-06-29 14:58:54 +02:00

Hey @JohanTriHandoyo your shots.py file looks correct. Per my comment #101 (comment) on another issue you opened, it appears that your Kitsu server didn't have the shot tasks input, please try manually setting up a shot task on the kitsu server than re attempt to use the shot builder.

The Blender Kitsu: Shot Builder is dependent on data from Kitsu Server to know what shots to build

Please let me know if that resolves your issue.

Hey @JohanTriHandoyo your shots.py file looks correct. Per my comment https://projects.blender.org/studio/blender-studio-pipeline/issues/101#issuecomment-968999 on another issue you opened, it appears that your Kitsu server didn't have the shot tasks input, please try manually setting up a shot task on the kitsu server than re attempt to use the shot builder. The Blender Kitsu: Shot Builder is dependent on data from Kitsu Server to know what shots to build Please let me know if that resolves your issue.

Nick Alberelli commented

2023-07-14 20:38:29 +02:00

Hello @JohanTriHandoyo per my comment on this issue #101 (comment) it is likely that the above assertion error is because the shot builder couldn't find a task related to the shot you want to build.

Per my above comment #93 (comment) the solution is to ensure the shot has a task on the kitsu server than re attempt building. I will be closing this issue now due to inactivity, I assuming this issue is resolved now.

Hello @JohanTriHandoyo per my comment on this issue https://projects.blender.org/studio/blender-studio-pipeline/issues/101#issuecomment-979354 it is likely that the above assertion error is because the shot builder couldn't find a task related to the shot you want to build. Per my above comment https://projects.blender.org/studio/blender-studio-pipeline/issues/93#issuecomment-969001 the solution is to ensure the shot has a task on the kitsu server than re attempt building. I will be closing this issue now due to inactivity, I assuming this issue is resolved now.

Nick Alberelli closed this issue

2023-07-14 20:38:29 +02:00

johan tri handoyo referenced this issue

2023-07-16 06:30:45 +02:00

Blender Kitsu: Shots pushed from Edit do not have Tasks Status #101

Nick Alberelli removed the

Status

Need More Info

label 2023-07-19 17:35:06 +02:00

Sign in to join this conversation.