studio/blender-studio-pipeline
13
30
Fork 19
Code Issues 20 Pull Requests 4 Projects Releases 1 Activity

Blender Kitsu: Move Render Review into Blender Kitsu #296

Merged
Nick Alberelli merged 17 commits from TinyNick/blender-studio-pipeline:feature/move-render-review-into-blender-kitsu into main 2024-05-28 19:29:41 +02:00
Conversation 7 Commits 17 Files Changed 26 +531 -1535
Nick Alberelli commented 2024-05-14 19:33:14 +02:00
Member
Copy Link

Why this change?

Render Review requires the Blender Kitsu Add-On to review sequences from a production. (I am also aware there is a way to review 'offline' without Kitsu). Users need to set the same directory paths twice between Blender Kitsu Add-On and Render Review Add-On. By merging these two add-ons we can reduce the friction in setting up a project, and remove duplicate code that exists between the add-ons. Render Review will retain it's 'offline' functionality if no project is set in the Kitsu Add-On.

What's Changed:

  • Move Render Review Add-On into Blender Kitsu Add-On
  • Move Render Review preferences into Blender Kitsu preferences
  • De-duplicate code between Render Review and Blender Kitsu
  • Adds custom getter/setter for farm output path to automatically set the path my_project/render
  • Adds early return if farm output path is invalid
  • Add option to skip incomplete renders

New Render REview Preferences UI

image

New Incomplete Renders Option

image

## Why this change? Render Review requires the Blender Kitsu Add-On to review sequences from a production. (I am also aware there is a way to review 'offline' without Kitsu). Users need to set the same directory paths twice between Blender Kitsu Add-On and Render Review Add-On. By merging these two add-ons we can reduce the friction in setting up a project, and remove duplicate code that exists between the add-ons. Render Review will retain it's 'offline' functionality if no project is set in the Kitsu Add-On. ## What's Changed: - Move Render Review Add-On into Blender Kitsu Add-On - Move Render Review preferences into Blender Kitsu preferences - De-duplicate code between Render Review and Blender Kitsu - Adds custom getter/setter for farm output path to automatically set the path `my_project/render` - Adds early return if farm output path is invalid - Add option to skip incomplete renders ## New Render REview Preferences UI ![image](/attachments/96022adf-a1d7-47ce-a397-eb6cce97fbbb) ## New Incomplete Renders Option ![image](/attachments/8e38f5fa-b8c2-4dba-a513-d71c7a7d6fbd)
image.png
10 KiB
image.png
60 KiB
Nick Alberelli added 1 commit 2024-05-14 19:33:20 +02:00
Nick Alberelli added 1 commit 2024-05-15 17:07:55 +02:00
Nick Alberelli added 2 commits 2024-05-15 20:38:04 +02:00
Nick Alberelli added 1 commit 2024-05-17 18:18:20 +02:00
Nick Alberelli added 1 commit 2024-05-17 18:36:29 +02:00
Nick Alberelli force-pushed feature/move-render-review-into-blender-kitsu from 920e216f42 to 466ba38a9f 2024-05-17 18:58:25 +02:00 Compare
Nick Alberelli added 1 commit 2024-05-17 19:09:10 +02:00
Nick Alberelli added 1 commit 2024-05-17 19:17:25 +02:00
Nick Alberelli added 1 commit 2024-05-17 20:00:19 +02:00
Nick Alberelli added 1 commit 2024-05-17 20:08:45 +02:00
Nick Alberelli commented 2024-05-17 20:13:42 +02:00
Author
Member
Copy Link

@ZedDB I am setting the default farm output directory to project_name/render because that is how we recommend users set this up in the documentation I wanted to verify if this path is true for Blender Studio users. Otherwise all users will need to manually set this path. Just wanted to check what the farm output directory is suppose to be within Blender Studio before I merge.

@ZedDB I am setting the default farm output directory to `project_name/render` because that is how we recommend users set this up in the [documentation](https://studio.blender.org/pipeline/td-guide/project_folder_structure#:~:text=Create%20render%20directory%20(Optional)) I wanted to verify if this path is true for Blender Studio users. Otherwise all users will need to manually set this path. Just wanted to check what the farm output directory is suppose to be within Blender Studio before I merge.
Nick Alberelli changed title from WIP: Move Render Review into Blender Kitsu Add-On to Move Render Review into Blender Kitsu Add-On 2024-05-17 20:13:57 +02:00
Nick Alberelli added 1 commit 2024-05-17 20:20:45 +02:00
Nick Alberelli added 1 commit 2024-05-17 20:21:50 +02:00
Nick Alberelli changed title from Move Render Review into Blender Kitsu Add-On to Blender Kitsu: Move Render Review into Blender Kitsu 2024-05-17 21:22:09 +02:00
Sebastian Parborg commented 2024-05-21 10:56:30 +02:00
Member
Copy Link

@TinyNick the render path in the studio is /render/<project_name>/

I don't expect other users to mimic our file structure with /render though. So having a different default value is ok for me.

@TinyNick the render path in the studio is `/render/<project_name>/` I don't expect other users to mimic our file structure with `/render` though. So having a different default value is ok for me.
Nick Alberelli commented 2024-05-22 16:06:37 +02:00
Author
Member
Copy Link

ok, I just want to check in with some users before I merge it then.

@Andy_Goralczyk @SimonThommes

I am moving the render review add-on into the blender kitsu add-on. The reasoning is to reduce the amount of preferences that need to be setting up a project / reduce duplicated code.

After merging this you will need to set the farm output directory in the Blender Kitsu preferences to /render/<project_name>/ if you do not a valid render directory you will get a warning when running the operator.

ok, I just want to check in with some users before I merge it then. @Andy_Goralczyk @SimonThommes I am moving the render review add-on into the blender kitsu add-on. The reasoning is to reduce the amount of preferences that need to be setting up a project / reduce duplicated code. After merging this you will need to set the `farm output directory` in the Blender Kitsu preferences to `/render/<project_name>/` if you do not a valid render directory you will get a warning when running the operator.
👍 1
Simon Thommes commented 2024-05-22 16:36:21 +02:00
Member
Copy Link

okay, that's fine with me

okay, that's fine with me
Nick Alberelli added 2 commits 2024-05-27 15:03:09 +02:00
Nick Alberelli commented 2024-05-27 15:16:23 +02:00
Author
Member
Copy Link

@SimonThommes I have added the feature you requested to skip incomplete renders to this pull request

@SimonThommes I have added the feature you requested to [skip incomplete renders](https://projects.blender.org/studio/blender-studio-pipeline/pulls/296#:~:text=New%20Incomplete%20Renders%20Option) to this pull request
Simon Thommes commented 2024-05-27 15:20:45 +02:00
Member
Copy Link

@TinyNick Awesome, thank you! Is the setting on by default? It should be.

@TinyNick Awesome, thank you! Is the setting on by default? It should be.
Nick Alberelli commented 2024-05-27 15:21:54 +02:00
Author
Member
Copy Link

@SimonThommes it's off by default I will change that based on ur feedback

@SimonThommes it's off by default I will change that based on ur feedback
👍 1
Nick Alberelli added 1 commit 2024-05-27 20:03:02 +02:00
Nick Alberelli added 1 commit 2024-05-27 20:04:26 +02:00
Nick Alberelli added 1 commit 2024-05-27 22:09:50 +02:00 
This reverts commit 681b190462.
Nick Alberelli merged commit 03253b88ab into main 2024-05-28 19:29:41 +02:00
Nick Alberelli deleted branch feature/move-render-review-into-blender-kitsu 2024-05-28 19:29:42 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Kind
Breaking
Breaking change that won't be backward compatible

  
Kind
Bug
Something is not working

  
Kind: Community

Issues opened by members of the community / outside the studio

  
Kind
Documentation
Documentation changes

  
Kind
Easy
Simple to complete

  
Kind
Enhancement
Improve existing functionality

  
Kind
Feature
New functionality

  
Kind
Proposal
A proposal or idea that requires feedback

  
Kind
Security
This is security issue

  
Kind
Studio Request
Requested by a user at the Blender-Studio

  
Kind
Testing
Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

No Label
Kind
Breaking
Kind
Bug
Kind: Community
Kind
Documentation
Kind
Easy
Kind
Enhancement
Kind
Feature
Kind
Proposal
Kind
Security
Kind
Studio Request
Kind
Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: studio/blender-studio-pipeline#296
No description provided.
Delete Branch "TinyNick/blender-studio-pipeline:feature/move-render-review-into-blender-kitsu"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?