studio/blender-studio-tools
13
32
Fork 19
Code Issues 21 Pull Requests 4 Projects Releases 1 Activity

SVN: UX improvements #136

Merged
Demeter Dzadik merged 15 commits from Mets/blender-studio-pipeline:svn_ux_improvements into main 2023-08-01 15:39:18 +02:00
Conversation 0 Commits 15 Files Changed 20 +456 -449
Demeter Dzadik commented 2023-08-01 15:30:38 +02:00
Member
Copy Link

General:

  • Add support for when SVN isn't on the system:
    • Background processes won't start, the add-on won't initialize.
    • The add-on prefs UI will have a button that takes you to Apache.
  • Improve UX for trying to commit during a conflict; Commit checkbox will be grayed out for the conflicting file; Conflict must be resolved as a separate step before committing.
  • Bring back filebrowser support; Simplified, now it's just the active repo's UI in the filebrowser sidebar. No multi-repo support here. Mainly due to poor filebrowser PyAPI, but also due to this being a fringe use case.
  • Fix updating not working after reverting repo once.

File list:

  • Fix file list and SVN log not being updated when opening a new file.
  • Entire file list no longer gets grayed out during update and commit, only operations.
  • Fix file list getting permanently grayed out when trashing a file.
  • Add option in right-click menu to open file with UI instead of only without.
  • Fix opening a file didn't prompt the save dialog.

"File is outdated" warning:

  • Moved to top of Blender instead of 3D View. Arguably less satanic.
  • Now clickable, and prompts to update and reload the file.
  • Warning stays until you commit or revert. This is explained by the tooltip.

Multi-repo workflow:

  • Remove the "Active Repo Mode" selector, that had the options of "Current File's Repo" or "Selected Repo".
  • Instead, the active repo is always the repo of whatever file was last opened, if any.
  • Fix having to re-auth when changing repo, if that repo was already authenticated in this Blender session.
  • Fix error when adding an existing repo.
**General:** - Add support for when SVN isn't on the system: - Background processes won't start, the add-on won't initialize. - The add-on prefs UI will have a button that takes you to [Apache](https://subversion.apache.org/packages.html). - Improve UX for trying to commit during a conflict; Commit checkbox will be grayed out for the conflicting file; Conflict must be resolved as a separate step before committing. - Bring back filebrowser support; Simplified, now it's just the active repo's UI in the filebrowser sidebar. No multi-repo support here. Mainly due to poor filebrowser PyAPI, but also due to this being a fringe use case. - Fix updating not working after reverting repo once. **File list:** - Fix file list and SVN log not being updated when opening a new file. - Entire file list no longer gets grayed out during update and commit, only operations. - Fix file list getting permanently grayed out when trashing a file. - Add option in right-click menu to open file with UI instead of only without. - Fix opening a file didn't prompt the save dialog. **"File is outdated" warning:** - Moved to top of Blender instead of 3D View. Arguably less satanic. - Now clickable, and prompts to update and reload the file. - Warning stays until you commit or revert. This is explained by the tooltip. **Multi-repo workflow:** - Remove the "Active Repo Mode" selector, that had the options of "Current File's Repo" or "Selected Repo". - Instead, the active repo is always the repo of whatever file was last opened, if any. - Fix having to re-auth when changing repo, if that repo was already authenticated in this Blender session. - Fix error when adding an existing repo.
Demeter Dzadik added 15 commits 2023-08-01 15:30:42 +02:00 
- Add option to open file with UI instead of only without
- Clarify that UI will be kept when reloading a file
- Reloading a file now prompts if current file is dirty
(only from right-click menu)
- Fix file list and SVN log not being updated when opening a new file
- Fix file list getting permanently grayed out when trashing a file
- Move outdated file warning from 3DView header to the top-bar

Minor code tweaks:
- Move force_good_active_index inside of update_file_filter
- Rename update_file_filter to refresh_ui_lists
- Remove file open operator. I figured out how to use the built-in one
- Saving the file won't re-authenticate
- Loading a file from another repo won't re-authenticate
This greatly simplifies a lot of both UX and code,
however, we seem to lose the ability to not
flicker the UI on file save/load... Would like to bring that back.
It was hard to find where the code for the repo list
add/remove operators were.
Filenames are more specific and accurate now.
Previously, if the user loads an old version of a file,
then updates to the latest again without reloading,
the "this file is outdated" warning will disappear,
which is slightly misleading.

This could still happen though,
if there are two instances of Blender open,
and you mess with the file that's open in one,
from the other. Can't help that.
Demeter Dzadik changed title from svn_ux_improvements to SVN: UX improvements 2023-08-01 15:31:31 +02:00
Demeter Dzadik merged commit 940f58ea01 into main 2023-08-01 15:39:18 +02:00
Demeter Dzadik deleted branch svn_ux_improvements 2023-08-01 15:39:18 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Kind
Breaking
Breaking change that won't be backward compatible

  
Kind
Bug
Something is not working

  
Kind: Community

Issues opened by members of the community / outside the studio

  
Kind
Documentation
Documentation changes

  
Kind
Easy
Simple to complete

  
Kind
Enhancement
Improve existing functionality

  
Kind
Feature
New functionality

  
Kind
Proposal
A proposal or idea that requires feedback

  
Kind
Security
This is security issue

  
Kind
Studio Request
Requested by a user at the Blender-Studio

  
Kind
Testing
Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

No Label
Kind
Breaking
Kind
Bug
Kind: Community
Kind
Documentation
Kind
Easy
Kind
Enhancement
Kind
Feature
Kind
Proposal
Kind
Security
Kind
Studio Request
Kind
Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: studio/blender-studio-tools#136
No description provided.
Delete Branch "Mets/blender-studio-pipeline:svn_ux_improvements"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?