studio/blender-studio-tools
13
32
Fork 19
Code Issues 21 Pull Requests 4 Projects Releases 1 Activity

Blender Kitsu: fix episode's sequence creation #202

Merged
Nick Alberelli merged 2 commits from slumber/blender-studio-pipeline:fix-episode-sequence-creation into main 2024-01-16 17:41:37 +01:00
Conversation 2 Commits 2 Files Changed 3 +11 -3
Swann Martinez commented 2024-01-15 14:59:04 +01:00
Contributor
Copy Link

A small fix to expose episode related sequences creation.

A small fix to expose episode related sequences creation.
Swann Martinez added 2 commits 2024-01-15 14:59:06 +01:00
Nick Alberelli reviewed 2024-01-15 15:57:58 +01:00
Nick Alberelli left a comment
Member
Copy Link

Thank you for this contribution! I have given it a test, but it appears that you need to set the active Episode for the push to work correctly, from a UX standpoint there is no episode active selector in the" Submit New Sequence" Operator Pop-Up. I am working on a PR that updates the UI for selecting active Episode/Sequence/Shot etc. Once that PR is merged, you can re-use the core functions in context/core.py to draw that UI element.

I will follow up on this to request the changes once that PR is merged! Thanks again for your contribution.

Thank you for this contribution! I have given it a test, but it appears that you need to set the active Episode for the push to work correctly, from a UX standpoint there is no episode active selector in the" Submit New Sequence" Operator Pop-Up. I am working on a [PR](https://projects.blender.org/studio/blender-studio-pipeline/pulls/187) that updates the UI for selecting active Episode/Sequence/Shot etc. Once that PR is merged, you can re-use the core functions in [`context/core.py`](https://projects.blender.org/studio/blender-studio-pipeline/pulls/187/files#diff-0e145619628c024d17aeaabfcfde1a2b1614075c) to draw that UI element. I will follow up on this to request the changes once that PR is merged! Thanks again for your contribution.
❤️ 1
Swann Martinez commented 2024-01-15 17:22:58 +01:00
Author
Contributor
Copy Link

Thank you for this contribution! I have given it a test, but it appears that you need to set the active Episode for the push to work correctly, from a UX standpoint there is no episode active selector in the" Submit New Sequence" Operator Pop-Up. I am working on a PR that updates the UI for selecting active Episode/Sequence/Shot etc. Once that PR is merged, you can re-use the core functions in context/core.py to draw that UI element.

I will follow up on this to request the changes once that PR is merged! Thanks again for your contribution.

Thanks for the quick answer ! I'll do the requested changes as soon as you merge you PR 🙂

In our current use, the active Episode is set from the episode selector in the context menu (using "edit" category), it is the wrong way to do it ? 🤔

> Thank you for this contribution! I have given it a test, but it appears that you need to set the active Episode for the push to work correctly, from a UX standpoint there is no episode active selector in the" Submit New Sequence" Operator Pop-Up. I am working on a [PR](https://projects.blender.org/studio/blender-studio-pipeline/pulls/187) that updates the UI for selecting active Episode/Sequence/Shot etc. Once that PR is merged, you can re-use the core functions in [`context/core.py`](https://projects.blender.org/studio/blender-studio-pipeline/pulls/187/files#diff-0e145619628c024d17aeaabfcfde1a2b1614075c) to draw that UI element. > > I will follow up on this to request the changes once that PR is merged! Thanks again for your contribution. Thanks for the quick answer ! I'll do the requested changes as soon as you merge you PR 🙂 In our current use, the active Episode is set from the episode selector in the context menu (using "edit" category), it is the wrong way to do it ? 🤔
Nick Alberelli commented 2024-01-16 17:40:21 +01:00
Member
Copy Link

Thanks for the quick answer ! I'll do the requested changes as soon as you merge you PR 🙂

In our current use, the active Episode is set from the episode selector in the context menu (using "edit" category), it is the wrong way to do it ? 🤔

@slumber Actually no changes are needed, episodes was a recent addition so I forgot the episode select was already drawn there by the context menu, and it didn't appear in my inital test due to an error in my Kitsu Test Server. Thanks for pointing that out, I have tested it again and I did get the correct UX.

Will merge, thank you for your contribution.

> > Thanks for the quick answer ! I'll do the requested changes as soon as you merge you PR 🙂 > > In our current use, the active Episode is set from the episode selector in the context menu (using "edit" category), it is the wrong way to do it ? 🤔 @slumber Actually no changes are needed, episodes was a recent addition so I forgot the episode select was already drawn there by the context menu, and it didn't appear in my inital test due to an error in my Kitsu Test Server. Thanks for pointing that out, I have tested it again and I did get the correct UX. Will merge, thank you for your contribution.
❤️ 1
Nick Alberelli merged commit 156294e73a into main 2024-01-16 17:41:37 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Kind
Breaking
Breaking change that won't be backward compatible

  
Kind
Bug
Something is not working

  
Kind: Community

Issues opened by members of the community / outside the studio

  
Kind
Documentation
Documentation changes

  
Kind
Easy
Simple to complete

  
Kind
Enhancement
Improve existing functionality

  
Kind
Feature
New functionality

  
Kind
Proposal
A proposal or idea that requires feedback

  
Kind
Security
This is security issue

  
Kind
Studio Request
Requested by a user at the Blender-Studio

  
Kind
Testing
Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

No Label
Kind
Breaking
Kind
Bug
Kind: Community
Kind
Documentation
Kind
Easy
Kind
Enhancement
Kind
Feature
Kind
Proposal
Kind
Security
Kind
Studio Request
Kind
Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: studio/blender-studio-tools#202
No description provided.
Delete Branch "slumber/blender-studio-pipeline:fix-episode-sequence-creation"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?