Asset Pipeline: Store Asset Catalog in String #230
No reviewers
Labels
No Label
Kind
Breaking
Kind
Bug
Kind: Community
Kind
Documentation
Kind
Easy
Kind
Enhancement
Kind
Feature
Kind
Proposal
Kind
Security
Kind
Studio Request
Kind
Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
No Milestone
No project
No Assignees
4 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: studio/blender-studio-tools#230
Loading…
Reference in New Issue
Block a user
No description provided.
Delete Branch "TinyNick/blender-studio-pipeline:fix/asset-catalog"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Closes: studio/blender-studio-pipeline#229
What's Changed?
Breaking Changes
New UI
asset_catalog_id
forasset_catalog_name
73b9c01df0@eyecandy This is fix is ready, but it does contain breaking changes, so I have not put this in main yet.
Please let me know if you would like to roll this change out or if we are worried about the breaking changes (having to reset asset catalog on all assets, listed above) I can likely handle the issue using a bbatch script.
I am off Feburary 14th (tomorrow) so please feel free to ask @ZedDB to Squash Commit this PR if you would like to roll this out by updating add-ons. otherwise I will handle any feedback on Thursday Feburary 15th.
Asset Pipeline: Store Asset Catalog in String instead of Enumto Asset Pipeline: Store Asset Catalog in StringIf both @Mets and @SimonThommes are fine with it, feel free to push this change. I'm off on the 14th as well, so I'm fine waiting until the 15th as well. thanks for fixing this so quick!
Sounds good to me. @TinyNick how is the owner of the set catalog defined right now. Would we only have to change the setting in the publish or in every working file? In case of the latter it would indeed be better to do this with a script.
☝️ Same sentiments and questions as Simon, once that's cleared up, this is fine by me.
@Mets @SimonThommes
Currently you will need to update this string in all working files, but I have decided there is a better way...
I am going to add a getter/setter for this value, so it will be pre-populated with whatever the current state of the asset is based on the
blender_assets.cats.txt
file. This way the behaviour will be; whatever asset catalog the published file is set to will be populated into the new string value. Bypassing the need for a script to update the value on all these files (and it's better behaviour IMO)In that case you will only need to change the asset catalog if it catalog is wrong and to make this change you can do it from any of the working files. Once the asset catalog is changed and sync'd to publish it will update the
blender_assets.cats.txt
which will be reflected in the string property for all working files.I'm not sure what the
blender_assets.cats.txt
has to do with this. Shouldn't that file just specify the general catalog hierarchy and their UUIDs? It doesn't have anything to do with the actual assets afaik, so we shouldn't have to touch it here.Am I misunderstanding something?
Yes I take back that comment I had a brain fart, forgot that the actual asset files aren't listed in
blender_assets.cats.txt
otherwise this would be easy. but the first part of my comment still stands, that you will need to set this string in multiple files so it's better if it is done with a script before I roll this out. I will get to work on that script asap.@SimonThommes @Mets @eyecandy
Do we have an opinion on which working files can change the asset catalog?
In the current step-up it can be changed by all task layer files but those changes are not sync'd so a change in working file A is reflected in publish but not in working file B.
Personally I think that should be changed. Would you guys prefer to have a single working file control this value, or have all working files share control of this value (assuming they are sync'd up some how)
since there is no 'main' working file and this should usually not change anyways, it would be acceptable to me if all files shared the ownership of this setting
Alright I have updated this PR, the Asset Catalog ID is now stored in the Task Layer JSON file, this way all task layers are in "sync" when changing this value. I have crawled all the asset files and was able to set this property on your behalf for all the assets that had a category set (which was about half of them). I have updated the task layer JSONs for those files in SVN revision.
Going forward you only need to set the asset catalog in one of the working files, and it will populate to the other working files automatically, and to publish when you Sync/Push.
Changes have been rolled out to your workstations.