studio/blender-studio-tools
13
32
Fork 19
Code Issues 21 Pull Requests 4 Projects Releases 1 Activity

Gentoo feedback and edits #232

Closed
Julien Kaspar wants to merge 1 commits from julienkaspar-install-software-feedback into main
pull from: julienkaspar-install-software-feedback
merge into: studio:main

When changing the target branch, be careful to rebase the branch in your fork to match. See documentation.
Conversation 1 Commits 1 Files Changed 2 +32 -10
Julien Kaspar commented 2024-02-16 15:54:00 +01:00
Member
Copy Link

Made some comments for feedback.
Also made some edits for minor formatting, rephrasing and missing information.

NOTE: I have no idea how scripts-blender/addons/lighting_overrider/json_io.py was also edited ...

Made some comments for feedback. Also made some edits for minor formatting, rephrasing and missing information. NOTE: I have no idea how `scripts-blender/addons/lighting_overrider/json_io.py` was also edited ...
Julien Kaspar added 1 commit 2024-02-16 15:54:01 +01:00 
Made some comments for feedback.
Also made some edits for minor formatting, rephrasing and missing information.
Julien Kaspar requested review from Sebastian Parborg 2024-02-16 15:54:09 +01:00
Julien Kaspar added the
Kind
Studio Request
Kind
Documentation
 labels 2024-02-16 15:57:14 +01:00
Nick Alberelli commented 2024-03-21 20:29:17 +01:00
Member
Copy Link

I have gone ahead and made a commit 7a76ba1087 integrating your feedback/changes. Below find my response to each comment.

First paragraph should give a quick overview of "merge" vs "Discover".
One sentence each, with quick understanding of pros/cons.

Thanks you for this feedback I have expanded the first paragraph to satisfy this comment.

This video seems redundant.
Either visually show all steps of installing and removing software or remove the video.

I am leaving the video and intructions because some users find it easier to follow videos while others perfer instructions. This redudency is important because this is an important fundemental step required for all other steps.

I have gone ahead and made a commit https://projects.blender.org/studio/blender-studio-pipeline/commit/7a76ba1087992ce4a9e113084b3b7d6ee908fd89 integrating your feedback/changes. Below find my response to each comment. > First paragraph should give a quick overview of "merge" vs "Discover". > One sentence each, with quick understanding of pros/cons. Thanks you for this feedback I have expanded the first paragraph to satisfy this comment. > This video seems redundant. > Either visually show all steps of installing and removing software or remove the video. I am leaving the video and intructions because some users find it easier to follow videos while others perfer instructions. This redudency is important because this is an important fundemental step required for all other steps.
Nick Alberelli closed this pull request 2024-03-21 20:29:18 +01:00

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Sebastian Parborg
Labels
Clear labels   
Kind
Breaking
Breaking change that won't be backward compatible

  
Kind
Bug
Something is not working

  
Kind: Community

Issues opened by members of the community / outside the studio

  
Kind
Documentation
Documentation changes

  
Kind
Easy
Simple to complete

  
Kind
Enhancement
Improve existing functionality

  
Kind
Feature
New functionality

  
Kind
Proposal
A proposal or idea that requires feedback

  
Kind
Security
This is security issue

  
Kind
Studio Request
Requested by a user at the Blender-Studio

  
Kind
Testing
Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

No Label
Kind
Breaking
Kind
Bug
Kind: Community
Kind
Documentation
Kind
Easy
Kind
Enhancement
Kind
Feature
Kind
Proposal
Kind
Security
Kind
Studio Request
Kind
Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: studio/blender-studio-tools#232
No description provided.
Delete Branch "julienkaspar-install-software-feedback"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?