studio/blender-studio-tools
13
32
Fork 19
Code Issues 21 Pull Requests 4 Projects Releases 1 Activity

Asset Pipeline: Improve Performance #235

Merged
Nick Alberelli merged 15 commits from TinyNick/blender-studio-pipeline:feature/asset-pipeline-performance-improvements into main 2024-04-17 21:13:54 +02:00
Conversation 3 Commits 15 Files Changed 9 +385 -175
Nick Alberelli commented 2024-02-17 00:27:15 +01:00
Member
Copy Link

What's Changed?

  • Vertex Groups are transferred as a group instead of individually
  • Don't Use tmp transfer data during merge process
  • Move objects being transfered to temp collection and disable all other collections during transfer
  • Add profiler to print performance numbers

TODO:

  • Don't Use tmp transfer data during merge process
  • Move objects being transfered to temp collection and disable all other collections during transfer
  • Clear Temp transfer data if cancelled
## What's Changed? - Vertex Groups are transferred as a group instead of individually - Don't Use tmp transfer data during merge process - Move objects being transfered to temp collection and disable all other collections during transfer - Add profiler to print performance numbers ## TODO: - [x] Don't Use tmp transfer data during merge process - [x] Move objects being transfered to temp collection and disable all other collections during transfer - ~~Clear Temp transfer data if cancelled~~
Nick Alberelli commented 2024-02-17 00:29:27 +01:00
Author
Member
Copy Link

@Mets I changed how the asset mapping stores transfer data so now we can transfer all vertex groups in one shot, I have tested this on Mikassa and didn't see any improvement in performance. I will look into this further next week.

@Mets I changed how the asset mapping stores transfer data so now we can transfer all vertex groups in one shot, I have tested this on Mikassa and didn't see any improvement in performance. I will look into this further next week.
Nick Alberelli force-pushed feature/asset-pipeline-performance-improvements from abacdd3717 to bc7c56fa7c 2024-04-09 21:04:00 +02:00 Compare
Nick Alberelli changed title from Asset Pipeline: Transfer Vertex Groups all at once to WIP: Asset Pipeline: Improve Performance 2024-04-09 21:05:35 +02:00
Nick Alberelli force-pushed feature/asset-pipeline-performance-improvements from bc7c56fa7c to abacdd3717 2024-04-12 19:05:42 +02:00 Compare
Nick Alberelli force-pushed feature/asset-pipeline-performance-improvements from 463d4bc07e to bf756b586f 2024-04-12 20:14:48 +02:00 Compare
Nick Alberelli commented 2024-04-12 20:50:25 +02:00
Author
Member
Copy Link

Performance Tests Round 1:
Trout Rigging Pull
Changed : 0.9310691356658936 seconds
Original: 1.0032949447631836 seconds

Whale Rigging Pull
Changed : 1.8040406703948975 seconds
Original: 2.4862008094787598 seconds

Boat Rigging Pull
Changed : 22.407100915908813 seconds
Original: 23.096190690994263 seconds

Performance Tests Round 1: Trout Rigging Pull Changed : 0.9310691356658936 seconds Original: 1.0032949447631836 seconds Whale Rigging Pull Changed : 1.8040406703948975 seconds Original: 2.4862008094787598 seconds Boat Rigging Pull Changed : 22.407100915908813 seconds Original: 23.096190690994263 seconds
Nick Alberelli force-pushed feature/asset-pipeline-performance-improvements from 832e6eed9c to 5a475a7731 2024-04-15 18:32:39 +02:00 Compare
Nick Alberelli added 1 commit 2024-04-15 18:57:48 +02:00
Nick Alberelli added 1 commit 2024-04-15 19:15:29 +02:00
Nick Alberelli added 1 commit 2024-04-15 21:46:50 +02:00
Nick Alberelli commented 2024-04-15 21:52:20 +02:00
Author
Member
Copy Link

Here are the final performance numbers from my testing

Name Original Avg Change Avg Difference Percentage
Trout Rigging 0.25 sec 0.18 sec .07 sec 41.69%
Boat Rigging 24.01 sec 16.01 sec 7.99 sec 49.92%
Mikassa Rigging 270.15 sec 256.44 sec 13.71 sec 5.35%

Tested on:
CPU: 8 × Intel® Core™ i7-8550U CPU @ 1.80GHz
Memory: 15.5 GiB of RAM

Testing the time it takes to execute merge_task_layer() on pull

Here are the final performance numbers from my testing | Name | Original Avg | Change Avg | Difference | Percentage | |-----------------|--------------|------------|------------|-------------| | Trout Rigging | 0.25 sec | 0.18 sec | .07 sec | 41.69% | | Boat Rigging | 24.01 sec | 16.01 sec | 7.99 sec | 49.92% | | Mikassa Rigging | 270.15 sec | 256.44 sec | 13.71 sec | 5.35% | Tested on: CPU: 8 × Intel® Core™ i7-8550U CPU @ 1.80GHz Memory: 15.5 GiB of RAM Testing the time it takes to execute `merge_task_layer()` on pull
Nick Alberelli changed title from WIP: Asset Pipeline: Improve Performance to Asset Pipeline: Improve Performance 2024-04-15 21:52:23 +02:00
Nick Alberelli added 1 commit 2024-04-16 16:43:59 +02:00
Nick Alberelli added 1 commit 2024-04-16 17:00:54 +02:00
Nick Alberelli added 3 commits 2024-04-17 19:43:31 +02:00
Nick Alberelli added 1 commit 2024-04-17 20:03:41 +02:00
Nick Alberelli merged commit 453cb3cc0f into main 2024-04-17 21:13:54 +02:00
Nick Alberelli deleted branch feature/asset-pipeline-performance-improvements 2024-04-17 21:13:55 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Kind
Breaking
Breaking change that won't be backward compatible

  
Kind
Bug
Something is not working

  
Kind: Community

Issues opened by members of the community / outside the studio

  
Kind
Documentation
Documentation changes

  
Kind
Easy
Simple to complete

  
Kind
Enhancement
Improve existing functionality

  
Kind
Feature
New functionality

  
Kind
Proposal
A proposal or idea that requires feedback

  
Kind
Security
This is security issue

  
Kind
Studio Request
Requested by a user at the Blender-Studio

  
Kind
Testing
Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

No Label
Kind
Breaking
Kind
Bug
Kind: Community
Kind
Documentation
Kind
Easy
Kind
Enhancement
Kind
Feature
Kind
Proposal
Kind
Security
Kind
Studio Request
Kind
Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: studio/blender-studio-tools#235
No description provided.
Delete Branch "TinyNick/blender-studio-pipeline:feature/asset-pipeline-performance-improvements"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?