studio/blender-studio-tools
12
31
Fork 19
Code Issues 21 Pull Requests 4 Projects Releases 1 Activity

Blender Media Viewer: Add UI Scale Option #294

Merged
Nick Alberelli merged 1 commits from TinyNick/blender-studio-pipeline:feature/blender-media-viewer-ui-scale into main 2024-05-13 18:07:05 +02:00
Conversation 1 Commits 1 Files Changed 1 +4
Nick Alberelli commented 2024-05-07 21:28:28 +02:00
Member
Copy Link

Closes: studio/blender-studio-pipeline#281

Blender Media Viewer scales the view to 1.5X as opposed to the default 1X, we don't want to change that because in most cases this is the best UI scale, but it may be good to give the user ability to change this, espcially when working on small screens or tablets for example.

What's Changed

  • Adds UI Scale Option to Settings

Issues with this Fix

The UI Scale doesn't behave well when scaling elements, the menu it lives in needs to re-draw (only occurs after closing an opening the menu) not sure if this really acceptable as a fix because it makes the UI so ugly while changing scales. Aside from exposing the Preferences menu (which is not a good idea for a "Application Template") I don't see any solution to this issue

expose_ui_scale

Closes: https://projects.blender.org/studio/blender-studio-pipeline/issues/281 Blender Media Viewer scales the view to 1.5X as opposed to the default 1X, we don't want to change that because in most cases this is the best UI scale, but it may be good to give the user ability to change this, espcially when working on small screens or tablets for example. ## What's Changed - Adds UI Scale Option to Settings ## Issues with this Fix The UI Scale doesn't behave well when scaling elements, the menu it lives in needs to re-draw (only occurs after closing an opening the menu) not sure if this really acceptable as a fix because it makes the UI so ugly while changing scales. Aside from exposing the Preferences menu (which is not a good idea for a "Application Template") I don't see any solution to this issue ![expose_ui_scale](/attachments/c2d454d4-aa4f-45c1-9034-2c63ab66b6e2)
expose_ui_scale.gif
4.2 MiB
Nick Alberelli added 1 commit 2024-05-07 21:28:35 +02:00
Nick Alberelli commented 2024-05-07 21:28:48 +02:00
Author
Member
Copy Link

@ZedDB Would appreciate your two cents on this one

@ZedDB Would appreciate your two cents on this one
Sebastian Parborg approved these changes 2024-05-10 12:36:04 +02:00
Sebastian Parborg left a comment
Member
Copy Link

Even though it doesn't look that nice, I think it's good enough for the use case.
It is probably only something end users will adjust very rarely.

Even though it doesn't look that nice, I think it's good enough for the use case. It is probably only something end users will adjust very rarely.
Nick Alberelli merged commit 414ea004c5 into main 2024-05-13 18:07:05 +02:00
Nick Alberelli deleted branch feature/blender-media-viewer-ui-scale 2024-05-13 18:07:05 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Sebastian Parborg
Labels
Clear labels   
Kind
Breaking
Breaking change that won't be backward compatible

  
Kind
Bug
Something is not working

  
Kind: Community

Issues opened by members of the community / outside the studio

  
Kind
Documentation
Documentation changes

  
Kind
Easy
Simple to complete

  
Kind
Enhancement
Improve existing functionality

  
Kind
Feature
New functionality

  
Kind
Proposal
A proposal or idea that requires feedback

  
Kind
Security
This is security issue

  
Kind
Studio Request
Requested by a user at the Blender-Studio

  
Kind
Testing
Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

No Label
Kind
Breaking
Kind
Bug
Kind: Community
Kind
Documentation
Kind
Easy
Kind
Enhancement
Kind
Feature
Kind
Proposal
Kind
Security
Kind
Studio Request
Kind
Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: studio/blender-studio-tools#294
No description provided.
Delete Branch "TinyNick/blender-studio-pipeline:feature/blender-media-viewer-ui-scale"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?