studio/blender-studio-tools
13
32
Fork 19
Code Issues 21 Pull Requests 4 Projects Releases 1 Activity

Merge shot_builder into blender kitsu #3

Merged
Nick Alberelli merged 1 commits from :feature/merge_shot_builder_into_blender_kitsu into master 2023-04-04 16:43:33 +02:00
Conversation 2 Commits 1 Files Changed 33 +697 -753
Nick Alberelli commented 2023-03-24 17:22:06 +01:00
Member
Copy Link

Closes: TinyNick/blender-studio-tools#2

Move Shot Builder into Blender Kitsu

The goal of this merge is to re-use to 'Blender Kitsu' addon's gazu based login/api functions in the 'shot builder' addon.

What's Changed

  • Move Shot_builder files to Blender Kitsu Addon
  • Remove Legacy Shot_builder preferences
  • Move Shot_builder properties into Blender Kitsu
  • Use Gazu within shot_builder's kitsu connector
  • Restore Shot Builder Documentation
Closes: https://projects.blender.org/TinyNick/blender-studio-tools/issues/2 # Move Shot Builder into Blender Kitsu The goal of this merge is to re-use to 'Blender Kitsu' addon's gazu based login/api functions in the 'shot builder' addon. **What's Changed** - Move Shot_builder files to Blender Kitsu Addon - Remove Legacy Shot_builder preferences - Move Shot_builder properties into Blender Kitsu - Use Gazu within shot_builder's kitsu connector - Restore Shot Builder Documentation
Nick Alberelli added 1 commit 2023-03-24 17:22:08 +01:00 
- Move Shot_builder into Blender_Kitsu
 - Changes from older branch
Nick Alberelli changed title from WIP: Merge `shot_builder` into `blender kitsu` to Merge `shot_builder` into `blender kitsu` 2023-03-24 17:23:47 +01:00
Nick Alberelli commented 2023-03-24 17:24:11 +01:00
Author
Member
Copy Link

@ZedDB I have got a new PR for you to review :)

@ZedDB I have got a new PR for you to review :)
Nick Alberelli requested review from Sebastian Parborg 2023-03-24 17:24:20 +01:00
Sebastian Parborg approved these changes 2023-03-31 14:18:45 +02:00
Nick Alberelli merged commit f85db92325 into master 2023-04-04 16:43:33 +02:00
Nick Alberelli deleted branch feature/merge_shot_builder_into_blender_kitsu 2023-04-04 16:43:34 +02:00
Nick Alberelli commented 2023-04-12 14:49:31 +02:00
Author
Member
Copy Link

Since this change occured there is a difference in how the hook files work. /{pro-name}/pro/shot-builder/
You only need to care about this change if you are trying to run the shot builder itself.

So at the top of each file the imports currently says something like

from shot_builder.hooks import hook, Wildcard
from shot_builder.asset import Asset
from shot_builder.shot import Shot
from shot_builder.project import Production

since this merge was done #3 the imports have changed. Because Shot_builder is now a sub-module of the blender_kitsu addon. So the imports will look like this at the top of each file: replacing shot_builder. with blender_kitsu.shot_builder

from blender_kitsu.shot_builder.hooks import hook, Wildcard
from blender_kitsu.shot_builder.asset import Asset
from blender_kitsu.shot_builder.shot import Shot
from blender_kitsu.shot_builder.project import Production
Since this change occured there is a difference in how the hook files work. `/{pro-name}/pro/shot-builder/` You only need to care about this change if you are trying to run the shot builder itself. So at the top of each file the imports currently says something like ``` from shot_builder.hooks import hook, Wildcard from shot_builder.asset import Asset from shot_builder.shot import Shot from shot_builder.project import Production ``` since this merge was done https://projects.blender.org/studio/blender-studio-tools/pulls/3 the imports have changed. Because Shot_builder is now a sub-module of the blender_kitsu addon. So the imports will look like this at the top of each file: replacing `shot_builder.` with `blender_kitsu.shot_builder` ``` from blender_kitsu.shot_builder.hooks import hook, Wildcard from blender_kitsu.shot_builder.asset import Asset from blender_kitsu.shot_builder.shot import Shot from blender_kitsu.shot_builder.project import Production ```
Sign in to join this conversation.
Reviewers
No reviewers
Sebastian Parborg
Labels
Clear labels   
Kind
Breaking
Breaking change that won't be backward compatible

  
Kind
Bug
Something is not working

  
Kind: Community

Issues opened by members of the community / outside the studio

  
Kind
Documentation
Documentation changes

  
Kind
Easy
Simple to complete

  
Kind
Enhancement
Improve existing functionality

  
Kind
Feature
New functionality

  
Kind
Proposal
A proposal or idea that requires feedback

  
Kind
Security
This is security issue

  
Kind
Studio Request
Requested by a user at the Blender-Studio

  
Kind
Testing
Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

No Label
Kind
Breaking
Kind
Bug
Kind: Community
Kind
Documentation
Kind
Easy
Kind
Enhancement
Kind
Feature
Kind
Proposal
Kind
Security
Kind
Studio Request
Kind
Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: studio/blender-studio-tools#3
No description provided.
Delete Branch ":feature/merge_shot_builder_into_blender_kitsu"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?