Blender Crawl: Improvements based on User Feedback #53

Merged
Nick Alberelli merged 11 commits from fix/blender-crawl-improvements into main 2023-05-22 16:50:42 +02:00
Member

Closes: studio/blender-studio-pipeline#52

Preview New README: here

New Features

  • Add logic to Save after script execution and enable by default
  • Always restore user save version settings after running tool
  • Add --nosave flag to skip saving

Changes to README

  • Fix --ask descriptions
  • Add information about root access for install
  • Add info about default save behaviour
  • Add info and example for --nosave option
Closes: https://projects.blender.org/studio/blender-studio-pipeline/issues/52 Preview New README: [here](https://projects.blender.org/studio/blender-studio-pipeline/src/commit/32f12316505701f3c966424837be6363500955f9/scripts/blender-crawl/README.md) ### New Features - Add logic to Save after script execution and enable by default - Always restore user save version settings after running tool - Add `--nosave` flag to skip saving ### Changes to README - Fix `--ask` descriptions - Add information about root access for install - Add info about default save behaviour - Add info and example for `--nosave` option
Nick Alberelli added 2 commits 2023-05-19 15:19:27 +02:00
- Provide instructions for Linux workstations
 - Provide links to root permissions instructions on mac and windows
Nick Alberelli added 3 commits 2023-05-19 16:48:38 +02:00
- Use context manager to restore user prefrences after execution
 - Cleanup Print Statements for save
- Append Save Script to User provided Scripts
 - Create "--nosave" flag to optionally skip saving
 - Convert get_purge to get_default_scripts function and re-use for getting save.py
 - Save scripts with appended save.py in tmp directory
Nick Alberelli added 1 commit 2023-05-19 16:55:13 +02:00
- Purge scripts use to set user save version preferences to 0
- previous commits added save.py script that restores user settings after excution via context manager
- use context manager in purge script as well
Nick Alberelli added 1 commit 2023-05-19 17:01:07 +02:00
Nick Alberelli added 1 commit 2023-05-19 17:01:45 +02:00
Nick Alberelli changed title from WIP: Blender Crawl: Improvements based on User Feedback to Blender Crawl: Improvements based on User Feedback 2023-05-19 17:02:37 +02:00
Nick Alberelli added 1 commit 2023-05-19 17:14:06 +02:00
Nick Alberelli added 1 commit 2023-05-19 17:31:00 +02:00
Nick Alberelli requested review from Sebastian Parborg 2023-05-19 17:43:22 +02:00

The changes looks good.

However I would change the install instructions as installing things this way is not really recommended.
We could recommend using pip if they really want to install things outside of their package manager with pip install . (https://stackoverflow.com/a/1550235)

I think we should emphasize that simply running the script without installing it is probably much easier for the majority of the users.

The changes looks good. However I would change the install instructions as installing things this way is not really recommended. We could recommend using pip if they really want to install things outside of their package manager with `pip install .` (https://stackoverflow.com/a/1550235) I think we should emphasize that simply running the script without installing it is probably much easier for the majority of the users.
Nick Alberelli added 1 commit 2023-05-22 14:51:20 +02:00
- Clarify install is optional
 - Fix install method to match https://stackoverflow.com/a/1550235
Author
Member

The changes looks good.

However I would change the install instructions as installing things this way is not really recommended.
We could recommend using pip if they really want to install things outside of their package manager with pip install . (https://stackoverflow.com/a/1550235)

I think we should emphasize that simply running the script without installing it is probably much easier for the majority of the users.

@ZedDB I have gone ahead and updated the REAME with your suggestion, please let me know if there is anything else to adjust before merging 04cfd5ebd6

> The changes looks good. > > However I would change the install instructions as installing things this way is not really recommended. > We could recommend using pip if they really want to install things outside of their package manager with `pip install .` (https://stackoverflow.com/a/1550235) > > I think we should emphasize that simply running the script without installing it is probably much easier for the majority of the users. @ZedDB I have gone ahead and updated the REAME with your suggestion, please let me know if there is anything else to adjust before merging https://projects.blender.org/studio/blender-studio-pipeline/commit/04cfd5ebd685ed87905d9d67746c33fdcf6b8d93
Sebastian Parborg approved these changes 2023-05-22 16:38:05 +02:00
Sebastian Parborg left a comment
Member

LGTM

LGTM
Nick Alberelli merged commit 189be1e7ac into main 2023-05-22 16:50:42 +02:00
Nick Alberelli deleted branch fix/blender-crawl-improvements 2023-05-22 16:50:43 +02:00
Sign in to join this conversation.
No reviewers
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: studio/blender-studio-tools#53
No description provided.