studio/blender-studio-tools
13
32
Fork 19
Code Issues 21 Pull Requests 4 Projects Releases 1 Activity

Fix Shot_Builder fails to invoke with correct project root directory #8

Merged
Nick Alberelli merged 6 commits from :fix/shot-builder-path-error into master 2023-04-13 16:07:29 +02:00
Conversation 0 Commits 6 Files Changed 2 +19 -18
Nick Alberelli commented 2023-04-13 15:51:25 +02:00
Member
Copy Link

Closes: TinyNick/blender-studio-tools#30

Todo

  • Currently expecting /media/data/pets/pro we need to accept this instead /media/data/pets/
  • Add Error message for similar errors

Changes

  • ensure_loaded_production() function now expects correct project root directory
  • Meaningful error messages have been added to make the issue more clear in the future

Why?

Shot_Builder is dependant on a filepath that is hard-coded into the project. If Blender-Kitsu already knows the project id than this shouldn't be the case. I would like to address issues like this in my PR #6

Demo

demo.gif

Closes: https://projects.blender.org/TinyNick/blender-studio-tools/issues/30 # Todo - [x] Currently expecting `/media/data/pets/pro` we need to accept this instead `/media/data/pets/` - [x] Add Error message for similar errors # Changes - `ensure_loaded_production()` function now expects correct project root directory - Meaningful error messages have been added to make the issue more clear in the future # Why? Shot_Builder is dependant on a filepath that is hard-coded into the project. If Blender-Kitsu already knows the project id than this shouldn't be the case. I would like to address issues like this in my PR https://projects.blender.org/studio/blender-studio-tools/pulls/6 # Demo ![demo.gif](/attachments/aed7878b-944a-40f7-8ed5-1123b4c5e44a)
demo.gif
475 KiB
Nick Alberelli added 6 commits 2023-04-13 15:51:27 +02:00 
- Add new lines to error messages
Sebastian Parborg approved these changes 2023-04-13 16:03:29 +02:00
Nick Alberelli merged commit 5139fa77e9 into master 2023-04-13 16:07:29 +02:00
Nick Alberelli deleted branch fix/shot-builder-path-error 2023-04-13 16:07:29 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Sebastian Parborg
Labels
Clear labels   
Kind
Breaking
Breaking change that won't be backward compatible

  
Kind
Bug
Something is not working

  
Kind: Community

Issues opened by members of the community / outside the studio

  
Kind
Documentation
Documentation changes

  
Kind
Easy
Simple to complete

  
Kind
Enhancement
Improve existing functionality

  
Kind
Feature
New functionality

  
Kind
Proposal
A proposal or idea that requires feedback

  
Kind
Security
This is security issue

  
Kind
Studio Request
Requested by a user at the Blender-Studio

  
Kind
Testing
Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

No Label
Kind
Breaking
Kind
Bug
Kind: Community
Kind
Documentation
Kind
Easy
Kind
Enhancement
Kind
Feature
Kind
Proposal
Kind
Security
Kind
Studio Request
Kind
Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: studio/blender-studio-tools#8
No description provided.
Delete Branch ":fix/shot-builder-path-error"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?