studio/blender-studio
3
4
Fork 4
Code Issues 37 Pull Requests 2 Projects 1 Releases 5 Wiki Activity

Films: Add filter by media type #104430

Merged
Pablo Vazquez merged 1 commits from pablovazquez/blender-studio:film-search-filter-type into main 2024-08-16 10:37:04 +02:00
Conversation 0 Commits 1 Files Changed 3 +58 -7
Pablo Vazquez commented 2024-08-15 16:00:55 +02:00
Owner
Copy Link

Copy over the functionality of filtering by media type from the regular
global search, into film_search.js

Also minor adjustments:

  • Add media_type label to the details of each card. Ideally we could
    unify it with the way it is done inside the gallery. Like showing a
    Blender logo for blend files, timestamp for videos, etc. For now
    simply show the type in a label.
  • Remove "Sort By:" label from the sortby element. It's clear from
    context. We could add a "sort" icon using CSS in the future.
  • Make all inputs full size. "input-sm" looks weird and it's not needed.
  • Move "cancel/clear" button after search. It's not the primary function
    so it shouldn't be right next to the text field.

It's saved in the URL, so it can be shared and loads the filters appropriately.

Before After
before after
Copy over the functionality of filtering by media type from the regular global search, into film_search.js Also minor adjustments: * Add `media_type` label to the details of each card. Ideally we could unify it with the way it is done inside the gallery. Like showing a Blender logo for blend files, timestamp for videos, etc. For now simply show the type in a label. * Remove "Sort By:" label from the sortby element. It's clear from context. We could add a "sort" icon using CSS in the future. * Make all inputs full size. "input-sm" looks weird and it's not needed. * Move "cancel/clear" button after search. It's not the primary function so it shouldn't be right next to the text field. It's saved in the URL, so it can be shared and loads the filters appropriately. <video src="/attachments/afe205f8-27b9-4d54-bac1-9042f31f53bf" title="film_search_filter_by_media_type.mov" controls></video> |Before|After| |----|----| |![before](/attachments/27b82ce0-16f7-41b8-8e87-775937057e60)|![after](/attachments/ae7e3016-48ca-4d86-a7ea-ba321d599da2)|
image.png
337 KiB
image.png
336 KiB
film_search_filter_by_media_type.mov
9.9 MiB
👍 1
Pablo Vazquez added the
Type
Web Development
 label 2024-08-15 16:00:55 +02:00
Oleg-Komarov was assigned by Pablo Vazquez 2024-08-15 16:00:56 +02:00
Pablo Vazquez added 1 commit 2024-08-15 16:00:58 +02:00 
Copy over the functionality of filtering by media type from the regular
global search, into film_search.js

Also minor adjustments:
* Add `media_type` label to the details of each card. Ideally we could
  unify it with the way it is done inside the gallery. Like showing a
  Blender logo for blend files, timestamp for videos, etc. For now
  simply show the type in a label.
* Remove "Sort By:" label from the sortby element. It's clear from
  context. We could add a "sort" icon using CSS in the future.
* Make all inputs full size. "input-sm" looks weird and it's not needed.
* Move "cancel/clear" button after search. It's not the primary function
  so it shouldn't be right next to the text field.
Oleg-Komarov approved these changes 2024-08-15 22:47:13 +02:00
Pablo Vazquez merged commit c6747ccc56 into main 2024-08-16 10:37:04 +02:00
Pablo Vazquez deleted branch film-search-filter-type 2024-08-16 10:37:04 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Oleg-Komarov
Labels
Clear labels   
Priority
High

  
Priority
Low

  
Priority
Normal

  
Status
Archived

  
Status
Confirmed

  
Status
Duplicate

  
Status
Needs Information from User

  
Status
Needs Triage

  
Status
Resolved

  
Type
Bug

  
Type
Content

  
Type
Design

  
Type
Report

  
Type
To Do

  
Type
Web Development

No Label
Priority
High
Priority
Low
Priority
Normal
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Content
Type
Design
Type
Report
Type
To Do
Type
Web Development
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
Oleg-Komarov
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: studio/blender-studio#104430
No description provided.
Delete Branch "pablovazquez/blender-studio:film-search-filter-type"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?