studio/flamenco
studio/flamenco
11
29
Fork 38
Code Issues 66 Pull Requests 9 Releases Wiki Activity

Shaman: Symlinks are absolute #104328

New Issue
Closed
opened 2024-07-23 09:14:15 +02:00 by Sybren A. Stüvel · 0 comments
Sybren A. Stüvel commented 2024-07-23 09:14:15 +02:00
Owner
Copy Link

System Information
Operating System(s): Linux, probably also macOS and Windows

Flamenco Version
Is Broken: 3.5, main branch at 00848a3755b1f8646156f6fd142dd621a28a94ac
Worked OK: probably never

Short description of error
Shaman creates symlinks that target an absolute path:

pack-info.txt -> /render/_flamenco/flamenco3-storage/file-store/stored/dd/62c51a4dad4099556c1bcc6bd4fc55d6871361fa0d9843d51ec841fa463bd1/156.blob

This creates issues on platforms where this absolute path cannot be used. For example, on macOS you'd need synthetic firm links to work around the root directory being read-only.

Having Shaman create relative symlinks would likely work around this:

pack-info.txt -> ../../file-store/stored/dd/62c51a4dad4099556c1bcc6bd4fc55d6871361fa0d9843d51ec841fa463bd1/156.blob

Exact steps for others to reproduce the error

  1. Enable Shaman and start Flamenco Manager.
  2. Submit a job.
  3. Inspect the job storage symlinks.
**System Information** Operating System(s): Linux, probably also macOS and Windows **Flamenco Version** Is Broken: 3.5, main branch at `00848a3755b1f8646156f6fd142dd621a28a94ac` Worked OK: probably never **Short description of error** Shaman creates symlinks that target an absolute path: ``` pack-info.txt -> /render/_flamenco/flamenco3-storage/file-store/stored/dd/62c51a4dad4099556c1bcc6bd4fc55d6871361fa0d9843d51ec841fa463bd1/156.blob ``` This creates issues on platforms where this absolute path cannot be used. For example, on macOS you'd need [synthetic firm links](https://apple.stackexchange.com/a/388244) to work around the root directory being read-only. Having Shaman create relative symlinks would likely work around this: ``` pack-info.txt -> ../../file-store/stored/dd/62c51a4dad4099556c1bcc6bd4fc55d6871361fa0d9843d51ec841fa463bd1/156.blob ``` **Exact steps for others to reproduce the error** 1. Enable Shaman and start Flamenco Manager. 2. Submit a job. 3. Inspect the job storage symlinks.
Sybren A. Stüvel added the
Status
Confirmed
Type
Bug
Priority
Normal
Good First Issue
 labels 2024-07-23 09:14:21 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels   
Good First Issue
  
Priority
High

  
Priority
Low

  
Priority
Normal

  
Status
Archived

  
Status
Confirmed

  
Status
Needs Info from Developers

  
Status
Needs Information from User

  
Status
Needs Triage

  
Status
Resolved

  
Type
Bug

  
Type
Design

  
Type
Job Type
Custom Flamenco job type

  
Type
Known Issue

  
Type
Patch

  
Type
Report

  
Type
To Do

No Label
Good First Issue
Priority
High
Priority
Low
Priority
Normal
Status
Archived
Status
Confirmed
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Job Type
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: studio/flamenco#104328
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?