studio/flamenco
studio/flamenco
12
30
Fork 38
Code Issues 63 Pull Requests 5 Releases Wiki Activity

Shaman: use relative paths for symlinks #104332

Merged
Sybren A. Stüvel merged 1 commits from dr.sybren/flamenco:shaman-relative-symlinks into main 2024-09-05 12:12:50 +02:00
Conversation 1 Commits 1 Files Changed 3 +64 -23
Sybren A. Stüvel commented 2024-08-01 13:56:34 +02:00
Owner
Copy Link

Use relative paths for symlinks, so that the Shaman storage can be mounted
on different locations on the Worker without the symlinks breaking.

Fixes studio/flamenco#104328

I'm quite confident of this fix, but I want to test it more thoroughly before merging to main.

Use relative paths for symlinks, so that the Shaman storage can be mounted on different locations on the Worker without the symlinks breaking. Fixes studio/flamenco#104328 ------------ I'm quite confident of this fix, but I want to test it more thoroughly before merging to main.
👍 1
Sybren A. Stüvel added 1 commit 2024-08-01 13:56:40 +02:00 
Use relative paths for symlinks, so that the Shaman storage can be mounted
on different locations on the Worker without the symlinks breaking.
Sybren A. Stüvel added this to the v3.6 milestone 2024-08-26 18:25:24 +02:00
Francesco Siddi commented 2024-09-05 11:49:46 +02:00
Owner
Copy Link

Tested this yesterday, seems to work great on the following setup:

  • Samba share (Synology, Btrfs)
  • macOS connected via NFS
  • Windows connected via samba

This makes it truly possible to operate Flamenco Manager in a heterogenous OS environment. Could this be merged?

Tested this yesterday, seems to work great on the following setup: - Samba share (Synology, Btrfs) - macOS connected via NFS - Windows connected via samba This makes it truly possible to operate Flamenco Manager in a heterogenous OS environment. Could this be merged?
❤️ 1
Sybren A. Stüvel merged commit 423c5c29d7 into main 2024-09-05 12:12:50 +02:00
Sybren A. Stüvel deleted branch shaman-relative-symlinks 2024-09-05 12:12:52 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Good First Issue
  
Priority
High

  
Priority
Low

  
Priority
Normal

  
Status
Archived

  
Status
Confirmed

  
Status
Needs Info from Developers

  
Status
Needs Information from User

  
Status
Needs Triage

  
Status
Resolved

  
Type
Bug

  
Type
Design

  
Type
Job Type
Custom Flamenco job type

  
Type
Known Issue

  
Type
Patch

  
Type
Report

  
Type
To Do

No Label
Good First Issue
Priority
High
Priority
Low
Priority
Normal
Status
Archived
Status
Confirmed
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Job Type
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
Milestone
Clear milestone
No items
No Milestone
v3.6
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: studio/flamenco#104332
No description provided.
Delete Branch "dr.sybren/flamenco:shaman-relative-symlinks"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?