studio/flamenco
studio/flamenco
12
30
Fork 38
Code Issues 63 Pull Requests 4 Releases Wiki Activity

Manager: fixed copy/paste typo in CheckBlenderExePath() #104192

Merged
Sybren A. Stüvel merged 1 commits from MKRelax/flamenco:main into main 2023-03-06 12:55:54 +01:00
Conversation 2 Commits 1 Files Changed 1 +1 -1
MKRelax commented 2023-02-28 23:22:58 +01:00
Contributor
Copy Link

When browsing the source code I found that the toCheck variable in CheckBlenderExePath() was initialized to CheckSharedStoragePathJSONBody.
That should probably be CheckBlenderExePathJSONBody.
Both are of type PathCheckInput, so it's just for readability of the code, and for me to practice Git and pull requests, I haven't done this for a while :).

When browsing the source code I found that the toCheck variable in CheckBlenderExePath() was initialized to CheckSharedStoragePathJSONBody. That should probably be CheckBlenderExePathJSONBody. Both are of type PathCheckInput, so it's just for readability of the code, and for me to practice Git and pull requests, I haven't done this for a while :).
MKRelax force-pushed main from f65adace57 to 923d6dbb53 2023-02-28 23:47:15 +01:00 Compare
Sybren A. Stüvel commented 2023-03-03 12:32:35 +01:00
Owner
Copy Link

Looks good to me, thanks!

As more practice, remove the WIP: title so that I can accept & land the PR :)

Looks good to me, thanks! As more practice, remove the `WIP: ` title so that I can accept & land the PR :)
👍 1
MKRelax changed title from WIP: Manager: fixed copy/paste typo in CheckBlenderExePath() to Manager: fixed copy/paste typo in CheckBlenderExePath() 2023-03-03 14:49:44 +01:00
Sybren A. Stüvel approved these changes 2023-03-06 12:55:15 +01:00
Sybren A. Stüvel merged commit 7963ab5efd into main 2023-03-06 12:55:54 +01:00
Sybren A. Stüvel commented 2023-03-06 12:56:10 +01:00
Owner
Copy Link

Thanks for the patch!

Thanks for the patch!
Sign in to join this conversation.
Reviewers
No reviewers
Sybren A. Stüvel
Labels
Clear labels   
Good First Issue
  
Priority
High

  
Priority
Low

  
Priority
Normal

  
Status
Archived

  
Status
Confirmed

  
Status
Needs Info from Developers

  
Status
Needs Information from User

  
Status
Needs Triage

  
Status
Resolved

  
Type
Bug

  
Type
Design

  
Type
Job Type
Custom Flamenco job type

  
Type
Known Issue

  
Type
Patch

  
Type
Report

  
Type
To Do

No Label
Good First Issue
Priority
High
Priority
Low
Priority
Normal
Status
Archived
Status
Confirmed
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Job Type
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: studio/flamenco#104192
No description provided.
Delete Branch "MKRelax/flamenco:main"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?