studio/flamenco
studio
/
flamenco
12
27
Fork 34
Code Issues 61 Pull Requests 11 Releases Wiki Activity

web-api-upgrade #104222

Closed
Eveline Anderson wants to merge 27 commits from Evelinealy/flamenco:web-api-upgrade into main
pull from: Evelinealy/flamenco:web-api-upgrade
merge into: studio:main

When changing the target branch, be careful to rebase the branch in your fork to match. See documentation.
Conversation 2 Commits 27 Files Changed 80 +4301 -4111
Eveline Anderson commented 2023-06-22 23:22:00 +02:00
Collaborator
Copy Link

Category: Variable/File Renaming

I changed all the names of worker clusters, or clusters, to tags. There should be no mention of the word cluster anywhere in this file.

Category: Variable/File Renaming I changed all the names of worker clusters, or clusters, to tags. There should be no mention of the word cluster anywhere in this file.
Eveline Anderson added 27 commits 2023-06-22 23:22:02 +02:00
Eveline Anderson commented 2023-06-22 23:25:36 +02:00
Author
Collaborator
Copy Link

I apologize for all these unnecessary commits. I had to restart the renaming a couple of times due to some issues on my end and I was trying to test out some of the generated files.

I apologize for all these unnecessary commits. I had to restart the renaming a couple of times due to some issues on my end and I was trying to test out some of the generated files.
Sybren A. Stüvel requested changes 2023-06-23 11:51:47 +02:00
Sybren A. Stüvel left a comment
Owner
Copy Link

This is looking good! Indeed, lots of places where things had to be changed.

Be sure to run make generate after changing flamenco-openapi.yaml though, and don't let any auto-formatter touch those files before you commit them.

The same goes for many other changes, too. It would seem that your editor auto-formats the sources, but with different settings than mine. That means that this PR has lots of formatting changes that shouldn't be in there. Such changes makes it very hard to see the difference between the actual rename of clusters to tags, and unrelated formatting changes.

The changes to go.mod and go.sum also fall under this category. Fine to upgrade dependencies, but that should be done separately from this rename.

This is looking good! Indeed, lots of places where things had to be changed. Be sure to run `make generate` after changing `flamenco-openapi.yaml` though, and don't let any auto-formatter touch those files before you commit them. The same goes for many other changes, too. It would seem that your editor auto-formats the sources, but with different settings than mine. That means that this PR has lots of formatting changes that shouldn't be in there. Such changes makes it very hard to see the difference between the actual rename of clusters to tags, and unrelated formatting changes. The changes to `go.mod` and `go.sum` also fall under this category. Fine to upgrade dependencies, but that should be done separately from this rename.
CHANGELOG.md
@ -33,1 +29,3 @@
- https://pkg.go.dev/vuln/GO-2022-1031
- https://pkg.go.dev/vuln/GO-2023-1571
- https://pkg.go.dev/vuln/GO-2023-1572
Sybren A. Stüvel commented 2023-06-23 10:48:19 +02:00
Owner
Copy Link

Please remove unrelated changes. If you really want this file to be formatted differently, that's fine, but should be done in a separate PR.

Please remove unrelated changes. If you really want this file to be formatted differently, that's fine, but should be done in a separate PR.
internal/manager/persistence/test_support.go
@ -98,3 +98,3 @@
worker *Worker
cluster *WorkerCluster
tag *WorkerTag
Sybren A. Stüvel commented 2023-06-23 11:11:20 +02:00
Owner
Copy Link

Be sure to format the Go files with go fmt or turn on auto-formatting in your IDE.

Fortunately Go comes with a built-in formatter, which means that all IDEs will use the same autoformatting style. Unlike the "everybody does it differently" with HTML/JavaScript...

Be sure to format the Go files with `go fmt` or turn on auto-formatting in your IDE. Fortunately Go comes with a built-in formatter, which means that all IDEs will use the same autoformatting style. Unlike the "everybody does it differently" with HTML/JavaScript...
Sybren A. Stüvel commented 2023-06-30 14:38:18 +02:00
Owner
Copy Link

Closing this PR as it was superseeded by #104223

Closing this PR as it was superseeded by #104223

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Sybren A. Stüvel
Labels
Clear labels   
Good First Issue
  
Priority
High

  
Priority
Low

  
Priority
Normal

  
Status
Archived

  
Status
Confirmed

  
Status
Needs Info from Developers

  
Status
Needs Information from User

  
Status
Needs Triage

  
Status
Resolved

  
Type
Bug

  
Type
Design

  
Type
Job Type
Custom Flamenco job type

  
Type
Known Issue

  
Type
Patch

  
Type
Report

  
Type
To Do

No Label
Good First Issue
Priority
High
Priority
Low
Priority
Normal
Status
Archived
Status
Confirmed
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Job Type
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: studio/flamenco#104222
No description provided.
Delete Branch "Evelinealy/flamenco:web-api-upgrade"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?