enhance messages when blender is not found #104224

MichaelC · 2023-06-27T01:03:28+02:00

MichaelC commented

2023-06-27 01:03:28 +02:00

Goals

To help indicate that this is not a roadblock if Flamenco Manager is configured to send the Blender path when a Render Job Task is sent to the Worker.
The warning also includes a doc link to help configure Flamenco Manager blender variable.

Testing

Tested on linux flamenco worker executable based on latest main.
Tried running make tests but they fail on sleep-scheduler tests (eg: TestSetSchedule) in both main and this branch in my setup.

**Goals** 1. To help indicate that this is not a roadblock if Flamenco Manager is configured to send the Blender path when a Render Job Task is sent to the Worker. 2. The warning also includes a doc link to help configure Flamenco Manager blender variable. **Testing** 1. Tested on linux flamenco worker executable based on latest main. 2. Tried running `make tests` but they fail on sleep-scheduler tests (eg: TestSetSchedule) in both main and this branch in my setup.

MichaelC added 1 commit 2023-06-27 01:03:30 +02:00

enhance messages when blender is not found 0dac4df945

Sybren A. Stüvel commented

2023-06-28 09:58:12 +02:00

You're probably hitting #104219 -- there's a workaround documented there as well (basically: fake that you're in Amsterdam).

Sybren A. Stüvel requested review from Sybren A. Stüvel 2023-07-03 10:59:33 +02:00

Sybren A. Stüvel requested changes 2023-07-03 11:02:02 +02:00

cmd/flamenco-worker/find_exes.go Outdated

						
				@ -35,3 +35,3 @@

					switch {

					case errors.Is(err, fs.ErrNotExist), errors.Is(err, exec.ErrNotFound):

						log.Warn().Msg("Blender could not be found, Flamenco Manager will have to supply a full path")

Sybren A. Stüvel commented

2023-07-03 11:00:24 +02:00

I don't think this newline is necessary.

cmd/flamenco-worker/find_exes.go

						
				@ -38,2 +39,3 @@

					case err != nil:

						log.Warn().AnErr("cause", err).Msg("there was an issue finding Blender on this system, Flamenco Manager will have to supply a full path")

						log.Warn().AnErr("cause", err).Msg(`There was an error finding Blender on this system. Flamenco Manager will have to supply the full path to Blender when Tasks are sent to this Worker. For more help see https://flamenco.blender.org/usage/variables/blender/`)

Sybren A. Stüvel commented

2023-07-03 11:01:59 +02:00

The Flamenco Manager will have to supply the full path to Blender when Tasks are sent to this Worker. For more help see https://flamenco.blender.org/usage/variables/blender/ text can be extracted to a constant, so that it doesn't have to be repeated.

Also I don't think the backticks are necessary, regular double quotes should work equally well.

The `Flamenco Manager will have to supply the full path to Blender when Tasks are sent to this Worker. For more help see https://flamenco.blender.org/usage/variables/blender/` text can be extracted to a constant, so that it doesn't have to be repeated. Also I don't think the backticks are necessary, regular double quotes should work equally well.

MichaelC added 1 commit 2023-07-05 02:22:56 +02:00

PR fixes fd1935b20a

MichaelC added 1 commit 2023-07-05 02:25:39 +02:00

Merge remote-tracking branch 'origin/main' into wrn_blender_not_found_improvement aa766cf3bb

MichaelC added 2 commits 2023-07-05 02:30:19 +02:00

revert content 3997d781cd

Merge remote-tracking branch 'origin/main' into wrn_blender_not_found_improvement 2bce67b6a0

MichaelC added 1 commit 2023-07-05 02:36:33 +02:00

fix merge errors 5ca3e8f45f

MichaelC closed this pull request

2023-07-05 17:38:20 +02:00