studio/flamenco
studio/flamenco
11
29
Fork 38
Code Issues 63 Pull Requests 8 Releases Wiki Activity

Webapp: Clarification of Worker Maintenance section #104229

Merged
Sybren A. Stüvel merged 6 commits from michael-2/flamenco:app_worker_maintenance_caption into main 2023-08-23 15:23:52 +02:00
Conversation 0 Commits 6 Files Changed 1 +14 -11
MichaelC commented 2023-07-05 17:32:13 +02:00
Contributor
Copy Link
  • fix spelling of 'adviced' for 'advised'
  • fixed readability of sentence in error state.
- fix spelling of 'adviced' for 'advised' - fixed readability of sentence in error state.
MichaelC added 1 commit 2023-07-05 17:32:16 +02:00
Sybren A. Stüvel requested changes 2023-07-06 12:57:43 +02:00
Sybren A. Stüvel left a comment
Owner
Copy Link

This is the same PR as #104227.

This is the same PR as #104227.
web/app/src/components/workers/WorkerDetails.vue
@ -129,0 +122,4 @@
</template>
<template v-else>
<template v-if="workerData.status == 'error'">
in <span class="worker-status">error</span>
Sybren A. Stüvel commented 2023-07-06 12:57:26 +02:00
Owner
Copy Link

This would print "{name} is in error", but in #104227 it was suggested to show "{name} is in error state" in this case.

This would print "{name} is in error", but in #104227 it was suggested to show "{name} is in error state" in this case.
MichaelC commented 2023-07-13 23:29:19 +02:00
Author
Contributor
Copy Link

I kept going back and forth on including the word "state". I have updated this PR to include "{name} is in error state"

I kept going back and forth on including the word "state". I have updated this PR to include "{name} is in error state"
michael-2 marked this conversation as resolved
MichaelC added 2 commits 2023-07-13 23:28:13 +02:00
MichaelC requested review from Sybren A. Stüvel 2023-07-13 23:30:31 +02:00
Sybren A. Stüvel requested changes 2023-07-25 11:01:27 +02:00
web/app/src/components/workers/WorkerDetails.vue Outdated
@ -132,0 +125,4 @@
</template>
<template v-else>
<template v-if="workerData.status == 'error'">
in <span class="worker-status">error state.</span>
Sybren A. Stüvel commented 2023-07-25 11:01:24 +02:00
Owner
Copy Link

It is now going to show {{ name }} is error state., which means. Note the lack of "in" and the period-comma.

It is now going to show `{{ name }} is error state., which means`. Note the lack of "in" and the period-comma.
MichaelC added 2 commits 2023-08-05 04:59:17 +02:00
MichaelC added 1 commit 2023-08-05 05:01:49 +02:00
MichaelC requested review from Sybren A. Stüvel 2023-08-05 05:02:24 +02:00
Sybren A. Stüvel changed title from Flamenco Manager Console - Worker Maintenance section caption to Webapp: Clarification of Worker Maintenance section 2023-08-23 15:23:03 +02:00
Sybren A. Stüvel approved these changes 2023-08-23 15:23:37 +02:00
Sybren A. Stüvel left a comment
Owner
Copy Link

Thanks!

Thanks!
Sybren A. Stüvel merged commit 86cf30e44e into main 2023-08-23 15:23:52 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Sybren A. Stüvel
Labels
Clear labels   
Good First Issue
  
Priority
High

  
Priority
Low

  
Priority
Normal

  
Status
Archived

  
Status
Confirmed

  
Status
Needs Info from Developers

  
Status
Needs Information from User

  
Status
Needs Triage

  
Status
Resolved

  
Type
Bug

  
Type
Design

  
Type
Job Type
Custom Flamenco job type

  
Type
Known Issue

  
Type
Patch

  
Type
Report

  
Type
To Do

No Label
Good First Issue
Priority
High
Priority
Low
Priority
Normal
Status
Archived
Status
Confirmed
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Job Type
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: studio/flamenco#104229
No description provided.
Delete Branch "michael-2/flamenco:app_worker_maintenance_caption"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?