studio/flamenco
studio/flamenco
12
30
Fork 38
Code Issues 63 Pull Requests 5 Releases Wiki Activity

Webapp: Clarification of Worker Maintenance section #104229

Merged
Sybren A. Stüvel merged 6 commits from michael-2/flamenco:app_worker_maintenance_caption into main 2023-08-23 15:23:52 +02:00
Conversation 0 Commits 6 Files Changed 1 +1 -1
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 719073d27d - Show all commits

2
web/app/src/components/workers/WorkerDetails.vue
View File

@ -125,7 +125,7 @@
</template>
michael-2 marked this conversation as resolved
Sybren A. Stüvel commented 2023-07-06 12:57:26 +02:00
Review
Copy Link

This would print "{name} is in error", but in #104227 it was suggested to show "{name} is in error state" in this case.

This would print "{name} is in error", but in #104227 it was suggested to show "{name} is in error state" in this case.
MichaelC commented 2023-07-13 23:29:19 +02:00
Review
Copy Link

I kept going back and forth on including the word "state". I have updated this PR to include "{name} is in error state"

I kept going back and forth on including the word "state". I have updated this PR to include "{name} is in error state"
<template v-else>
<template v-if="workerData.status == 'error'">
in <span class="worker-status">error state</span>
in <span class="worker-status">error</span> state
Sybren A. Stüvel commented 2023-07-25 11:01:24 +02:00
Outdated
Review
Copy Link

It is now going to show {{ name }} is error state., which means. Note the lack of "in" and the period-comma.

It is now going to show `{{ name }} is error state., which means`. Note the lack of "in" and the period-comma.
</template>
<template v-else>
<span class="worker-status">{{ workerData.status }}</span>