studio/flamenco
studio/flamenco
12
30
Fork 38
Code Issues 64 Pull Requests 5 Releases Wiki Activity

Webapp: Clarification of Worker Maintenance section #104229

Merged
Sybren A. Stüvel merged 6 commits from michael-2/flamenco:app_worker_maintenance_caption into main 2023-08-23 15:23:52 +02:00
Conversation 0 Commits 6 Files Changed 1 +14 -11
1 changed files with 14 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit dc65d7101e - Show all commits

25
web/app/src/components/workers/WorkerDetails.vue
View File

@ -115,17 +115,20 @@
<section class="worker-maintenance"> <section class="worker-maintenance">
<h3 class="sub-title">Maintenance</h3> <h3 class="sub-title">Maintenance</h3>
<p>{{ workerData.name }} is <span class="worker-status">{{ workerData.status }}</span>, which means <p>
<template v-if="workerData.status == 'offline'">can be safely removed.</template> {{ workerData.name }} is
<template v-else>removing it now can cause the Worker to log errors. It <template v-if="workerData.status == 'offline'">
is adviced to shut down the Worker before removing it from the <span class="worker-status">offline</span>, which means it can be safely removed.
system.</template> </template>
</p> <template v-else>
<p><button @click="deleteWorker">Remove {{ workerData.name }}</button></p> <template v-if="workerData.status == 'error'">
<p class="hint"> in <span class="worker-status">error</span>
michael-2 marked this conversation as resolved
Sybren A. Stüvel commented 2023-07-06 12:57:26 +02:00
Review
Copy Link

This would print "{name} is in error", but in #104227 it was suggested to show "{name} is in error state" in this case.

This would print "{name} is in error", but in #104227 it was suggested to show "{name} is in error state" in this case.
MichaelC commented 2023-07-13 23:29:19 +02:00
Review
Copy Link

I kept going back and forth on including the word "state". I have updated this PR to include "{name} is in error state"

I kept going back and forth on including the word "state". I have updated this PR to include "{name} is in error state"
When a Worker is removed from the system, any active task still assigned </template>
to it will be requeued. Restarting the Worker after removing it from the <template v-else>
system will simply register it anew. <span class="worker-status">{{ workerData.status }}</span>
Sybren A. Stüvel commented 2023-07-25 11:01:24 +02:00
Outdated
Review
Copy Link

It is now going to show {{ name }} is error state., which means. Note the lack of "in" and the period-comma.

It is now going to show `{{ name }} is error state., which means`. Note the lack of "in" and the period-comma.
</template>, which means removing it now can cause it to log errors. It
is advised to shut down the Worker before removing it from the system.
</template>
</p> </p>
</section> </section>
</template> </template>