Flamenco Worker - Update WRN msg when Blender isn't found by Worker to help end user on next-steps #104230

Manually merged
Sybren A. Stüvel merged 2 commits from michael-2/flamenco:msg_blender_not_found into main 2023-07-10 15:09:44 +02:00
Contributor

Problem

End users tend to get stuck on the "WRN" and try to either re-install Blender or configure Flamenco Manager blender paths.

Enhancement to message is to still warn on this situation and help point the end user to some configuration documentation explaining how Flamenco Manager can pass the Blender path whenever a Task in a render Job is dispatched to the Worker.

Probably worth trying to add some more info or FAQ documentation on why Blender couldn't be found in another PR.

Problem End users tend to get stuck on the "WRN" and try to either re-install Blender or configure Flamenco Manager blender paths. Enhancement to message is to still warn on this situation and help point the end user to some configuration documentation explaining how Flamenco Manager can pass the Blender path whenever a Task in a render Job is dispatched to the Worker. Probably worth trying to add some more info or FAQ documentation on why Blender couldn't be found in another PR.
MichaelC added 1 commit 2023-07-05 17:43:50 +02:00
Sybren A. Stüvel requested changes 2023-07-06 12:51:06 +02:00
Sybren A. Stüvel left a comment
Owner

For reference: this PR has the same goal as #104224, and the discussions on that PR are also valid here.

For reference: this PR has the same goal as #104224, and the discussions on that PR are also valid here.
@ -36,2 +38,3 @@
case errors.Is(err, fs.ErrNotExist), errors.Is(err, exec.ErrNotFound):
log.Warn().Msg("Blender could not be found, Flamenco Manager will have to supply a full path")
log.Warn().Msg("The Worker could not find Blender on this system. " + helpMsg)

Remove "The Worker" from the string. Everything logged by the worker is from the worker's perspective.

Remove "The Worker" from the string. Everything logged by the worker is from the worker's perspective.
MichaelC added 1 commit 2023-07-06 15:04:37 +02:00
MichaelC requested review from Sybren A. Stüvel 2023-07-06 15:05:23 +02:00
Sybren A. Stüvel approved these changes 2023-07-10 15:09:40 +02:00
Sybren A. Stüvel left a comment
Owner

Thanks!

Thanks!
Sybren A. Stüvel manually merged commit 520102627d into main 2023-07-10 15:09:44 +02:00
Sign in to join this conversation.
No description provided.