studio/flamenco
studio/flamenco
12
30
Fork 38
Code Issues 62 Pull Requests 4 Releases Wiki Activity

Added documentation snippet on enabling Symlinks on SAMBA #104260

Manually merged
Sybren A. Stüvel merged 4 commits from Dylan-Blanque/flamenco:docs_changes_20231016 into main 2023-11-06 11:24:21 +01:00
Conversation 1 Commits 4 Files Changed 1 +35 -1
Dylan Gabriel Blanqué commented 2023-10-17 02:53:41 +02:00
Contributor
Copy Link

This commit adds documentation related to SAMBA usage with Shaman, and recommendations on enabling symlink and a couple of flags on the global /etc/samba/smb.conf file.

Tested with Linux/Windows Clients.

This commit adds documentation related to SAMBA usage with Shaman, and recommendations on enabling symlink and a couple of flags on the global `/etc/samba/smb.conf` file. Tested with Linux/Windows Clients.
Dylan Gabriel Blanqué added 2 commits 2023-10-17 02:53:43 +02:00
Sybren A. Stüvel commented 2023-10-17 11:25:56 +02:00
Owner
Copy Link

Please update the PR description, as that'll serve as (starting point for) the commit message. And people should be able to follow what commit does what, without having to read the changes themselves.

Most importantly, in Blender Chat you said you actually use this configuration and that it works well for you. That kind of information is important to have in the commit message, as it makes it possible for others to understand the value of the addition to the docs.

Please update the PR description, as that'll serve as (starting point for) the commit message. And people should be able to follow what commit does what, without having to read the changes themselves. Most importantly, in Blender Chat you said you actually use this configuration and that it works well for you. That kind of information is important to have in the commit message, as it makes it possible for others to understand the value of the addition to the docs.
👍 1
Sybren A. Stüvel requested review from Sybren A. Stüvel 2023-10-17 11:26:03 +02:00
Dylan Gabriel Blanqué added 2 commits 2023-10-18 03:12:37 +02:00 
This has been tested with Linux and Windows Clients.
Dylan Gabriel Blanqué changed title from Added documentation snippet on enabling Symlinks on SAMBA to Added documentation snippet on enabling Symlinks on SAMBA 2023-10-18 03:15:18 +02:00
Sybren A. Stüvel approved these changes 2023-11-03 15:49:22 +01:00
Sybren A. Stüvel left a comment
Owner
Copy Link

I've tested this at home this morning, and it works well! Thanks again!

I've tested this at home this morning, and it works well! Thanks again!
❤️ 1
Sybren A. Stüvel manually merged commit 36e90f0066 into main 2023-11-06 11:24:21 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
Sybren A. Stüvel
Labels
Clear labels   
Good First Issue
  
Priority
High

  
Priority
Low

  
Priority
Normal

  
Status
Archived

  
Status
Confirmed

  
Status
Needs Info from Developers

  
Status
Needs Information from User

  
Status
Needs Triage

  
Status
Resolved

  
Type
Bug

  
Type
Design

  
Type
Job Type
Custom Flamenco job type

  
Type
Known Issue

  
Type
Patch

  
Type
Report

  
Type
To Do

No Label
Good First Issue
Priority
High
Priority
Low
Priority
Normal
Status
Archived
Status
Confirmed
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Job Type
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: studio/flamenco#104260
No description provided.
Delete Branch "Dylan-Blanque/flamenco:docs_changes_20231016"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?