studio/flamenco
studio
/
flamenco
12
27
Fork 32
Code Issues 60 Pull Requests 7 Releases Wiki Activity

WIP: Add option to write metadata to output #104284

Draft
Ha-Anh-Vu wants to merge 1 commits from Ha-Anh-Vu/flamenco:issue100268 into main
pull from: Ha-Anh-Vu/flamenco:issue100268
merge into: studio:main

When changing the target branch, be careful to rebase the branch in your fork to match. See documentation.
Conversation 1 Commits 1 Files Changed 1 +11
Ha-Anh-Vu commented 2024-02-20 17:26:28 +01:00
First-time contributor
Copy Link

fix #100268

@dr.sybren What I have done:

  • Add an arg --write-metadata-to-output
  • If that arg exists in the command, write task ID to the output

Could you check if I have done them correctly? If yes, I'll continue to enable other metadata.

fix #100268 @dr.sybren What I have done: - Add an arg `--write-metadata-to-output` - If that arg exists in the command, write task ID to the output Could you check if I have done them correctly? If yes, I'll continue to enable other metadata.
Ha-Anh-Vu added 1 commit 2024-02-20 17:26:31 +01:00
Sybren A. Stüvel commented 2024-02-20 18:08:31 +01:00
Owner
Copy Link

I think you misunderstood the desired functionality. This is about Blender's metadata feature, and including information from Flamenco in there.

The use of a global variable to keep track of this option is also something to avoid.

I think you misunderstood the desired functionality. This is about [Blender's metadata feature](https://docs.blender.org/manual/en/latest/render/output/properties/metadata.html), and including information from Flamenco in there. The use of a global variable to keep track of this option is also something to avoid.
This pull request is marked as a work in progress.
This branch is out-of-date with the base branch
View command line instructions.

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u issue100268:Ha-Anh-Vu-issue100268
git checkout Ha-Anh-Vu-issue100268

Merge

Merge the changes and update on Gitea.
git checkout main
git merge --no-ff Ha-Anh-Vu-issue100268
git checkout main
git merge --ff-only Ha-Anh-Vu-issue100268
git checkout Ha-Anh-Vu-issue100268
git rebase main
git checkout main
git merge --no-ff Ha-Anh-Vu-issue100268
git checkout main
git merge --squash Ha-Anh-Vu-issue100268
git checkout main
git merge Ha-Anh-Vu-issue100268
git push origin main
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Good First Issue
  
Priority
High

  
Priority
Low

  
Priority
Normal

  
Status
Archived

  
Status
Confirmed

  
Status
Needs Info from Developers

  
Status
Needs Information from User

  
Status
Needs Triage

  
Status
Resolved

  
Type
Bug

  
Type
Design

  
Type
Known Issue

  
Type
Patch

  
Type
Report

  
Type
To Do

No Label
Good First Issue
Priority
High
Priority
Low
Priority
Normal
Status
Archived
Status
Confirmed
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: studio/flamenco#104284
No description provided.
Delete Branch "Ha-Anh-Vu/flamenco:issue100268"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?