Added scene-specific third party job type to website #104297

William Gardner · 2024-04-09T21:09:16+02:00

William Gardner commented

2024-04-09 21:09:16 +02:00

No description provided.

William Gardner added 1 commit 2024-04-09 21:09:20 +02:00

Website: added scene render third party script 8eca513ad9

Sybren A. Stüvel commented

2024-04-11 10:38:44 +02:00

No description provided.

Please write a description of what this PR does. This description is not just for me personally, but also for others who are interested in the project, or who go through the project history to get more info about decision processes.

> No description provided. Please write a description of what this PR does. This description is not just for me personally, but also for others who are interested in the project, or who go through the project history to get more info about decision processes.

Sybren A. Stüvel requested changes 2024-04-11 10:50:13 +02:00

Sybren A. Stüvel left a comment

Thanks for the PR. I've left some inline notes.

web/project-website/content/third-party-jobs/scene-render-script.md

						
				@ -0,0 +1,28 @@

				---

				title: Scene Render Script

Sybren A. Stüvel commented

2024-04-11 10:39:58 +02:00

The title is a bit too generic, as pretty much any script that renders any blend file can be called "scene render script".

web/project-website/content/third-party-jobs/scene-render-script.md

						
				@ -0,0 +5,4 @@

				*Job type documented and maintained by: [Counter LLC](https://madebycounter.com/)*

				*Source code available at: [github.com/madebycounter/flamenco-scene-render](https://github.com/madebycounter/flamenco-scene-render/)*

Sybren A. Stüvel commented

2024-04-11 10:43:07 +02:00

It's nice to have a link to your github repo here. I think it'll be better to do that in the form of diverting bug reports there, something like:

*Job type documented and maintained by [Counter LLC](https://madebycounter.com/). Please report any issues at [the Counter LLC Github project](https://github.com/madebycounter/flamenco-scene-render/issues).*

It's nice to have a link to your github repo here. I think it'll be better to do that in the form of diverting bug reports there, something like: ```markdown *Job type documented and maintained by [Counter LLC](https://madebycounter.com/). Please report any issues at [the Counter LLC Github project](https://github.com/madebycounter/flamenco-scene-render/issues).* ```

web/project-website/content/third-party-jobs/scene-render-script.md

						
				@ -0,0 +15,4 @@

				{{< /hint >}}

				This job type extends the built-in Simple Blender Render to allow for scene selection.

Sybren A. Stüvel commented

2024-04-11 10:43:59 +02:00

Please make the built-in Simple Blender Render a link to the actual built-in script.

Please make `the built-in Simple Blender Render` a link to the actual built-in script.

web/project-website/content/third-party-jobs/scene-render-script.md

						
				@ -0,0 +22,4 @@

				## Usage

				1. Download [scene_render.js](https://raw.githubusercontent.com/madebycounter/flamenco-scene-render/main/scene_render.js)

				2. Copy `scene_render.js` to the scripts folder in your Flamenco manager installation (or create it if it doesn't exist).

Sybren A. Stüvel commented

2024-04-11 10:44:41 +02:00

scripts should be in backticks here, as it refers to a literal directory name, and is not a general description.

`scripts` should be in backticks here, as it refers to a literal directory name, and is not a general description.

web/project-website/content/third-party-jobs/scene-render-script.md

						
				@ -0,0 +23,4 @@

Download [scene_render.js](https://raw.githubusercontent.com/madebycounter/flamenco-scene-render/main/scene_render.js)

Copy `scene_render.js` to the scripts folder in your Flamenco manager installation (or create it if it doesn't exist).

Refresh your job types in the Flamenco Blender plugin and select "Simple Scene Render"

Sybren A. Stüvel commented

2024-04-11 10:44:57 +02:00

Blender has no "plugins", but "add-ons".

web/project-website/content/third-party-jobs/scene-render-script.md

						
				@ -0,0 +24,4 @@

Download [scene_render.js](https://raw.githubusercontent.com/madebycounter/flamenco-scene-render/main/scene_render.js)

Copy `scene_render.js` to the scripts folder in your Flamenco manager installation (or create it if it doesn't exist).

Refresh your job types in the Flamenco Blender plugin and select "Simple Scene Render"

Adjust the scene value to meet needs (automatically set to the current scene).

Sybren A. Stüvel commented

2024-04-11 10:49:06 +02:00

Quote the word "scene" and capitalise it, to make it clearer that this is the actual name of the setting, and not a general description.

to meet needs

This is too vague, as you wouldn't know what those needs are until you know what the setting does. Does this give you a drop-down of the scenes in the current file? Do you need to enter the name yourself?

Quote the word "scene" and capitalise it, to make it clearer that this is the actual name of the setting, and not a general description. > to meet needs This is too vague, as you wouldn't know what those needs are until you know what the setting does. Does this give you a drop-down of the scenes in the current file? Do you need to enter the name yourself?