studio/flamenco
studio
/
flamenco
12
27
Fork 32
Code Issues 60 Pull Requests 7 Releases Wiki Activity

Added scene-specific third party job type to website #104297

Open
William Gardner wants to merge 1 commits from william-at-counter/flamenco:scene-render-script into main
pull from: william-at-counter/flamenco:scene-render-script
merge into: studio:main

When changing the target branch, be careful to rebase the branch in your fork to match. See documentation.
Conversation 1 Commits 1 Files Changed 1 +28
William Gardner commented 2024-04-09 21:09:16 +02:00
Contributor
Copy Link
No description provided.
William Gardner added 1 commit 2024-04-09 21:09:20 +02:00
Sybren A. Stüvel commented 2024-04-11 10:38:44 +02:00
Owner
Copy Link

No description provided.

Please write a description of what this PR does. This description is not just for me personally, but also for others who are interested in the project, or who go through the project history to get more info about decision processes.

> No description provided. Please write a description of what this PR does. This description is not just for me personally, but also for others who are interested in the project, or who go through the project history to get more info about decision processes.
Sybren A. Stüvel requested changes 2024-04-11 10:50:13 +02:00
Sybren A. Stüvel left a comment
Owner
Copy Link

Thanks for the PR. I've left some inline notes.

Thanks for the PR. I've left some inline notes.
web/project-website/content/third-party-jobs/scene-render-script.md
@ -0,0 +1,28 @@
---
title: Scene Render Script
Sybren A. Stüvel commented 2024-04-11 10:39:58 +02:00
Owner
Copy Link

The title is a bit too generic, as pretty much any script that renders any blend file can be called "scene render script".

The title is a bit too generic, as pretty much any script that renders any blend file can be called "scene render script".
web/project-website/content/third-party-jobs/scene-render-script.md
@ -0,0 +5,4 @@
*Job type documented and maintained by: [Counter LLC](https://madebycounter.com/)*
*Source code available at: [github.com/madebycounter/flamenco-scene-render](https://github.com/madebycounter/flamenco-scene-render/)*
Sybren A. Stüvel commented 2024-04-11 10:43:07 +02:00
Owner
Copy Link

It's nice to have a link to your github repo here. I think it'll be better to do that in the form of diverting bug reports there, something like:

*Job type documented and maintained by [Counter LLC](https://madebycounter.com/). Please report any issues at [the Counter LLC Github project](https://github.com/madebycounter/flamenco-scene-render/issues).*
It's nice to have a link to your github repo here. I think it'll be better to do that in the form of diverting bug reports there, something like: ```markdown *Job type documented and maintained by [Counter LLC](https://madebycounter.com/). Please report any issues at [the Counter LLC Github project](https://github.com/madebycounter/flamenco-scene-render/issues).* ```
web/project-website/content/third-party-jobs/scene-render-script.md
@ -0,0 +15,4 @@
{{< /hint >}}
This job type extends the built-in Simple Blender Render to allow for scene selection.
Sybren A. Stüvel commented 2024-04-11 10:43:59 +02:00
Owner
Copy Link

Please make the built-in Simple Blender Render a link to the actual built-in script.

Please make `the built-in Simple Blender Render` a link to the actual built-in script.
web/project-website/content/third-party-jobs/scene-render-script.md
@ -0,0 +22,4 @@
## Usage
1. Download [scene_render.js](https://raw.githubusercontent.com/madebycounter/flamenco-scene-render/main/scene_render.js)
2. Copy `scene_render.js` to the scripts folder in your Flamenco manager installation (or create it if it doesn't exist).
Sybren A. Stüvel commented 2024-04-11 10:44:41 +02:00
Owner
Copy Link

scripts should be in backticks here, as it refers to a literal directory name, and is not a general description.

`scripts` should be in backticks here, as it refers to a literal directory name, and is not a general description.
web/project-website/content/third-party-jobs/scene-render-script.md
@ -0,0 +23,4 @@
1. Download [scene_render.js](https://raw.githubusercontent.com/madebycounter/flamenco-scene-render/main/scene_render.js)
2. Copy `scene_render.js` to the scripts folder in your Flamenco manager installation (or create it if it doesn't exist).
3. Refresh your job types in the Flamenco Blender plugin and select "Simple Scene Render"
Sybren A. Stüvel commented 2024-04-11 10:44:57 +02:00
Owner
Copy Link

Blender has no "plugins", but "add-ons".

Blender has no "plugins", but "add-ons".
web/project-website/content/third-party-jobs/scene-render-script.md
@ -0,0 +24,4 @@
1. Download [scene_render.js](https://raw.githubusercontent.com/madebycounter/flamenco-scene-render/main/scene_render.js)
2. Copy `scene_render.js` to the scripts folder in your Flamenco manager installation (or create it if it doesn't exist).
3. Refresh your job types in the Flamenco Blender plugin and select "Simple Scene Render"
4. Adjust the scene value to meet needs (automatically set to the current scene).
Sybren A. Stüvel commented 2024-04-11 10:49:06 +02:00
Owner
Copy Link

Quote the word "scene" and capitalise it, to make it clearer that this is the actual name of the setting, and not a general description.

to meet needs

This is too vague, as you wouldn't know what those needs are until you know what the setting does. Does this give you a drop-down of the scenes in the current file? Do you need to enter the name yourself?

Quote the word "scene" and capitalise it, to make it clearer that this is the actual name of the setting, and not a general description. > to meet needs This is too vague, as you wouldn't know what those needs are until you know what the setting does. Does this give you a drop-down of the scenes in the current file? Do you need to enter the name yourself?
This pull request can be merged automatically.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
View command line instructions.

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u scene-render-script:william-at-counter-scene-render-script
git checkout william-at-counter-scene-render-script

Merge

Merge the changes and update on Gitea.
git checkout main
git merge --no-ff william-at-counter-scene-render-script
git checkout main
git merge --ff-only william-at-counter-scene-render-script
git checkout william-at-counter-scene-render-script
git rebase main
git checkout main
git merge --no-ff william-at-counter-scene-render-script
git checkout main
git merge --squash william-at-counter-scene-render-script
git checkout main
git merge william-at-counter-scene-render-script
git push origin main
Sign in to join this conversation.
Reviewers
No reviewers
Sybren A. Stüvel
Labels
Clear labels   
Good First Issue
  
Priority
High

  
Priority
Low

  
Priority
Normal

  
Status
Archived

  
Status
Confirmed

  
Status
Needs Info from Developers

  
Status
Needs Information from User

  
Status
Needs Triage

  
Status
Resolved

  
Type
Bug

  
Type
Design

  
Type
Known Issue

  
Type
Patch

  
Type
Report

  
Type
To Do

No Label
Good First Issue
Priority
High
Priority
Low
Priority
Normal
Status
Archived
Status
Confirmed
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: studio/flamenco#104297
No description provided.
Delete Branch "william-at-counter/flamenco:scene-render-script"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?