Add-on: Add checkbox to submit jobs in paused
status
#104323
No reviewers
Labels
No Label
Good First Issue
Priority
High
Priority
Low
Priority
Normal
Status
Archived
Status
Confirmed
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Job Type
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: studio/flamenco#104323
Loading…
Reference in New Issue
Block a user
No description provided.
Delete Branch "David-Zhang-10/flamenco:submit-as-paused-addon"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Overview
This pull request implements Issue #99439 Allow jobs to be submitted in paused status and builds upon PR #104313 Support pausing jobs and PR #104318 WIP: Allow jobs to be submitted in paused status.
Deliverables
paused
status before submission to Flamenco Manager.initial_status
field in SubmittedJob a5954e43f7paused
status e59b2c526bWIP: Addon frontend for jobs to be submitted in `paused` statusto Addon frontend for jobs to be submitted in `paused` status46260a4a76
to05587d7fa2
@ -156,6 +156,12 @@ def register() -> None:
max=100,
)
bpy.types.Scene.flamenco_job_initial_status = bpy.props.BoolProperty(
There's a discrepancy here between the property name (says this should be a status) and its definition (says it's whether the job should be paused or not). Choose one, and use it consistently.
Since this property is used for the GUI as well, and we discussed offering a checkbox 'submit paused', using a
BoolProperty
is the right choice, and the name should change.@ -158,1 +158,4 @@
bpy.types.Scene.flamenco_job_initial_status = bpy.props.BoolProperty(
name="Flamenco Job Initial Status",
description="Initial status of the render job; True sets the job to `paused`, and False sets the job to `queued`",
This description is for users of Blender, not for developers. Replace the Python terminology (
True
andFalse
) with what they can see: checked & unchecked.👍 for describing both 'checked' & 'unchecked' cases, often enough people only describe one and leave you to guess what the other meant. My favourite example here is good old DOOM: it had a checkbox "8-bit textures" -- no idea whether un-checking meant 4-bit or 16-bit textures.
flamenco_job_submit_as_paused
42dca591bb@ -42,6 +42,7 @@ class FLAMENCO_PT_job_submission(bpy.types.Panel):
col = layout.column(align=True)
col.prop(context.scene, "flamenco_job_name", text="Job Name")
col.prop(context.scene, "flamenco_job_priority", text="Priority")
col.prop(context.scene, "flamenco_job_initial_status", text="Submit as Paused")
Make sure you test before committing & pushing ;-) (and yes, I've been here myself as well)
flamenco_job_submit_as_paused
in gui 3f19327886Addon frontend for jobs to be submitted in `paused` statusto Add-on: Add checkbox to submit jobs in `paused` statusAccepted!
As for the commit message, that shouldn't use much MarkDown, as it's typically rendered as plain text. Also it should be line-wrapped at max 72-75 characters. Something like this would work:
Please use the 'Create squash commit' method of landing the PR.
911dfff0c3
to3f19327886
3f19327886
tocc59f0b79a