studio/flamenco
studio/flamenco
12
30
Fork 38
Code Issues 63 Pull Requests 5 Releases Wiki Activity

Distributed rendering of single images #104327

Merged
David Zhang merged 22 commits from David-Zhang-10/flamenco:single-image-render into main 2024-09-03 06:47:49 +02:00
Conversation 2 Commits 22 Files Changed 2 +374
David Zhang commented 2024-07-22 03:52:32 +02:00
Collaborator
Copy Link

Overview

This pull request introduces a tile-based distributed rendering solution for single images, which would benefit artists working on complex scenes by reducing rendering times and improving image quality, without the need for extensive technical adjustments.

Steps

  • A new custom JOB_TYPE for single images
  • Rendering image in separate pieces in multilayer EXR, with overscan for adaptive sampling and with tile_size controllable by the users
  • Merging separate pieces into a whole image
  • Compositing on the image as a whole
  • Deal with denoising
**Overview** This pull request introduces a tile-based distributed rendering solution for single images, which would benefit artists working on complex scenes by reducing rendering times and improving image quality, without the need for extensive technical adjustments. **Steps** - A new custom `JOB_TYPE` for single images - Rendering image in separate pieces in multilayer EXR, with overscan for adaptive sampling and with `tile_size` controllable by the users - Merging separate pieces into a whole image - Compositing on the image as a whole - Deal with denoising
David Zhang added 1 commit 2024-07-22 03:52:37 +02:00
David Zhang added 1 commit 2024-07-22 05:35:13 +02:00
Sybren A. Stüvel reviewed 2024-07-23 09:39:23 +02:00
Sybren A. Stüvel left a comment
Owner
Copy Link

Low priority (highest one is to get things working ;-)) but I don't want to forget about this: the job type should record the current frame number, and explicitly render that frame.

When someone is working directly on the shared storage, there is no copy of the blend file for each render job. That means that they could be sending multiple jobs, rendering different frames from the same file. Using whatever was saved as the current frame then isn't enough to make that work.

Low priority (highest one is to get things working ;-)) but I don't want to forget about this: the job type should record the current frame number, and explicitly render that frame. When someone is working directly on the shared storage, there is no copy of the blend file for each render job. That means that they could be sending multiple jobs, rendering different frames from the same file. Using whatever was saved as the current frame then isn't enough to make that work.
David Zhang added 2 commits 2024-07-25 06:44:57 +02:00
David Zhang added 1 commit 2024-07-26 05:28:27 +02:00
David Zhang added 1 commit 2024-07-26 05:42:06 +02:00
David Zhang added 1 commit 2024-07-28 22:54:25 +02:00
David Zhang added 1 commit 2024-07-29 05:49:36 +02:00
David Zhang added 1 commit 2024-08-05 04:14:03 +02:00
David Zhang added 2 commits 2024-08-10 21:14:41 +02:00
David Zhang added 1 commit 2024-08-10 21:53:37 +02:00
David Zhang added 1 commit 2024-08-26 03:55:11 +02:00
David Zhang added 1 commit 2024-08-26 03:55:35 +02:00
Sybren A. Stüvel added this to the v3.6 milestone 2024-08-26 18:25:49 +02:00
David Zhang added 1 commit 2024-08-27 06:04:38 +02:00
David Zhang added 1 commit 2024-08-27 06:05:23 +02:00
David Zhang added 1 commit 2024-08-29 05:07:14 +02:00
David Zhang added 1 commit 2024-08-29 06:19:09 +02:00
Sybren A. Stüvel commented 2024-08-29 12:52:03 +02:00
Owner
Copy Link

I've tried the job type, but for me it doesn't quite work well yet:

merged.jpg

I've attached the file I used for rendering this: flamenco-bcon23-demo.blend

The job looks like:

{
  "metadata": {},
  "name": "cube-one-frame",
  "priority": 50,
  "settings": {
    "add_path_components": 0,
    "blendfile": "{jobs}/cube-one-frame-l7yf/flamenco-bcon23-demo.flamenco.blend",
    "format": "JPEG",
    "frame": 38,
    "image_file_extension": ".jpg",
    "render_output_path": "{shared_storage_mapping}/flamenco/renders/cube-one-frame/2024-08-29_124331/######",
    "render_output_root": "{shared_storage_mapping}/flamenco/renders/",
    "resolution_x": 2048,
    "resolution_y": 858,
    "tile_size_x": 512,
    "tile_size_y": 512
  },
  "storage": {
    "shaman_checkout_id": "cube-one-frame-l7yf"
  },
  "submitter_platform": "",
  "type": "single-image-render",
  "worker_tag": "ec60583f-f112-4e87-acab-79c79f3ba77f",
  "activity": "Changed to status \"completed\": all tasks completed",
  "created": "2024-08-29T10:43:31.11506402Z",
  "id": "d25ae08e-75ec-40c5-80a5-6a64818f4506",
  "status": "completed",
  "updated": "2024-08-29T10:43:54.294028483Z"
}

This is the output in the render directory:

.
├── ######
│   ├── 0-0-512-512.exr
│   ├── 0-512-512-858.exr
│   ├── 1024-0-1536-512.exr
│   ├── 1024-512-1536-858.exr
│   ├── 1536-0-2048-512.exr
│   ├── 1536-512-2048-858.exr
│   ├── 512-0-1024-512.exr
│   └── 512-512-1024-858.exr
└── merged.jpg

Those #-marks shouldn't be there, as those are typically an indicator that tells Blender where to put the frame number. Since Blender is not rendering an animation, that doesn't make sense to keep. Better to just replace it with a word like tiles.

The frame setting can be hidden in the submission interface, using visible: "web". And then moved down to the "Automatically evaluated settings".

I've tried the job type, but for me it doesn't quite work well yet: ![merged.jpg](/attachments/b9732e8b-ea84-4a11-b4e5-ba23203b4843) I've attached the file I used for rendering this: [flamenco-bcon23-demo.blend](/attachments/aedc4f21-80cc-4e99-b88a-4bcb55838658) The job looks like: ```json { "metadata": {}, "name": "cube-one-frame", "priority": 50, "settings": { "add_path_components": 0, "blendfile": "{jobs}/cube-one-frame-l7yf/flamenco-bcon23-demo.flamenco.blend", "format": "JPEG", "frame": 38, "image_file_extension": ".jpg", "render_output_path": "{shared_storage_mapping}/flamenco/renders/cube-one-frame/2024-08-29_124331/######", "render_output_root": "{shared_storage_mapping}/flamenco/renders/", "resolution_x": 2048, "resolution_y": 858, "tile_size_x": 512, "tile_size_y": 512 }, "storage": { "shaman_checkout_id": "cube-one-frame-l7yf" }, "submitter_platform": "", "type": "single-image-render", "worker_tag": "ec60583f-f112-4e87-acab-79c79f3ba77f", "activity": "Changed to status \"completed\": all tasks completed", "created": "2024-08-29T10:43:31.11506402Z", "id": "d25ae08e-75ec-40c5-80a5-6a64818f4506", "status": "completed", "updated": "2024-08-29T10:43:54.294028483Z" } ``` ---------- This is the output in the render directory: ``` . ├── ###### │   ├── 0-0-512-512.exr │   ├── 0-512-512-858.exr │   ├── 1024-0-1536-512.exr │   ├── 1024-512-1536-858.exr │   ├── 1536-0-2048-512.exr │   ├── 1536-512-2048-858.exr │   ├── 512-0-1024-512.exr │   └── 512-512-1024-858.exr └── merged.jpg ``` Those `#`-marks shouldn't be there, as those are typically an indicator that tells Blender where to put the frame number. Since Blender is not rendering an animation, that doesn't make sense to keep. Better to just replace it with a word like `tiles`. ------- The `frame` setting can be hidden in the submission interface, using `visible: "web"`. And then moved down to the "Automatically evaluated settings".
merged.jpg
35 KiB
flamenco-bcon23-demo.blend
522 KiB
David Zhang changed title from WIP: Distributed rendering of single images to Distributed rendering of single images 2024-08-30 03:02:14 +02:00
Sybren A. Stüvel commented 2024-08-30 11:36:15 +02:00
Owner
Copy Link

Now it's working, nice!

There does seem to be a math rounding issue somewhere though. This is what I get with:

  • the same test file as above
  • resolution scale = 100%
  • tile size 256 x 327 pixels

merged.jpg

Now it's working, nice! There does seem to be a math rounding issue somewhere though. This is what I get with: - the same test file as above - resolution scale = 100% - tile size 256 x 327 pixels ![merged.jpg](/attachments/7ac68b5d-40b5-4159-9df7-602cc3488eb1)
merged.jpg
86 KiB
David Zhang force-pushed single-image-render from 68a20578e7 to 2843993de4 2024-09-02 13:19:48 +02:00 Compare
David Zhang added 1 commit 2024-09-02 17:11:11 +02:00
Sybren A. Stüvel requested review from Sybren A. Stüvel 2024-09-02 17:35:24 +02:00
Sybren A. Stüvel approved these changes 2024-09-02 17:41:26 +02:00
Sybren A. Stüvel left a comment
Owner
Copy Link

It seems to work! There's a bunch of improvements to make (like the division issue shown above), but let's land this before the GSoC is over, and look at those later.

It seems to work! There's a bunch of improvements to make (like the division issue shown above), but let's land this before the GSoC is over, and look at those later.
David Zhang merged commit 60872c89f9 into main 2024-09-03 06:47:49 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Sybren A. Stüvel
Labels
Clear labels   
Good First Issue
  
Priority
High

  
Priority
Low

  
Priority
Normal

  
Status
Archived

  
Status
Confirmed

  
Status
Needs Info from Developers

  
Status
Needs Information from User

  
Status
Needs Triage

  
Status
Resolved

  
Type
Bug

  
Type
Design

  
Type
Job Type
Custom Flamenco job type

  
Type
Known Issue

  
Type
Patch

  
Type
Report

  
Type
To Do

No Label
Good First Issue
Priority
High
Priority
Low
Priority
Normal
Status
Archived
Status
Confirmed
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Job Type
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
Milestone
Clear milestone
No items
No Milestone
v3.6
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: studio/flamenco#104327
No description provided.
Delete Branch "David-Zhang-10/flamenco:single-image-render"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?