studio/svn-manager
0
1
Fork 1
Code Issues Pull Requests Projects Releases Wiki Activity

Fix building on macOS #1

Merged
Francesco Siddi merged 1 commits from Sergey/svn-manager:fix_macos_compile into main 2023-05-13 18:12:07 +02:00
Conversation 0 Commits 1 Files Changed 1 +7 -2
Sergey Sharybin commented 2023-05-13 18:07:20 +02:00
Contributor
Copy Link

The Makefile was hard-coded to some GNU/Linux specific commands and
arguments:

  • cp -u does not exist on macOS (and possible BSD either).

    Likely, the rsync is already used in other steps, so we can use it
    in place of co -u as well.

  • On macOS there is no sma256sum command.

    Not by default, anyway. While it is probably available via installing
    core utils via brew, this is quite big package which could cause other
    issues, so it is not really no-brainer to install.

    This is solved by detecting availability of sha256sum command and
    using shasum -a 256 if the former is not available.

The Makefile was hard-coded to some GNU/Linux specific commands and arguments: - `cp -u` does not exist on macOS (and possible BSD either). Likely, the rsync is already used in other steps, so we can use it in place of `co -u` as well. - On macOS there is no sma256sum command. Not by default, anyway. While it is probably available via installing core utils via brew, this is quite big package which could cause other issues, so it is not really no-brainer to install. This is solved by detecting availability of sha256sum command and using `shasum -a 256` if the former is not available.
Sergey Sharybin added 1 commit 2023-05-13 18:07:21 +02:00 
The Makefile was hard-coded to some GNU/Linux specific commands and
arguments:

- `cp -u` does not exist on macOS (and possible BSD either).

  Likely, the rsync is already used in other steps, so we can use it
  in place of `co -u` as well.

- On macOS there is no sma256sum command.

  Not by default, anyway. While it is probably available via installing
  core utils via brew, this is quite big package which could cause other
  issues, so it is not really no-brainer to install.

  This is solved by detecting availability of sha256sum command and
  using `shasum -a 256` if the former is not available.
Sergey Sharybin requested review from Francesco Siddi 2023-05-13 18:07:27 +02:00
Francesco Siddi merged commit fa0a8c0301 into main 2023-05-13 18:12:07 +02:00
Francesco Siddi deleted branch fix_macos_compile 2023-05-13 18:12:07 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Francesco Siddi
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: studio/svn-manager#1
No description provided.
Delete Branch "Sergey/svn-manager:fix_macos_compile"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?