Wannes Malfait wannes.malfait
0 Followers · 0 Following
  • Joined on 2019-09-15
Repositories
2
 Projects Public Activity Starred Repositories
Wannes Malfait commented on pull request blender/blender#118565 2024-02-21 17:04:55 +01:00
Geometry Nodes: Add Align Rotation to Vector node

Not sure, but I feel like it should be possible to achieve this without having to convert the quaternions to rotation matrices and back? That could also be left for a future update of course

Wannes Malfait commented on pull request blender/blender#116729 2024-01-03 16:53:53 +01:00
Refactoring: Geometry Nodes: Rewrite Ico Sphere mesh primitive

Here is my idea for calculating normals:

  • For the vertex normals: these are just the same as the position (if you have not yet scaled by the radius). (The normal of a point on the unit sphere is…
Wannes Malfait commented on pull request blender/blender#116729 2024-01-03 16:34:27 +01:00
Refactoring: Geometry Nodes: Rewrite Ico Sphere mesh primitive

I know this is just WIP, but I was interested to see how you constructed the icosphere.

Wannes Malfait commented on pull request blender/blender#116729 2024-01-03 16:34:26 +01:00
Refactoring: Geometry Nodes: Rewrite Ico Sphere mesh primitive

I think it is possible to speed this up a little bit:

Wannes Malfait commented on pull request blender/blender#116729 2024-01-03 16:34:26 +01:00
Refactoring: Geometry Nodes: Rewrite Ico Sphere mesh primitive

If a and b are normalized, then the cross product is automatically normalized.

Wannes Malfait commented on pull request blender/blender#116729 2024-01-03 16:34:25 +01:00
Refactoring: Geometry Nodes: Rewrite Ico Sphere mesh primitive

I would suggest only scaling by the radius after all the points (also the subdivided) have been calculated. This way you avoid having to do expensive normalisations later.

Wannes Malfait commented on pull request blender/blender#112794 2023-11-28 09:50:54 +01:00
Mesh: add index-independent test for mesh equality

I got these 2 warnings after merging main into a local branch

image

Somehow slipped under the radar it seems. Fixed in 1e84a02

Wannes Malfait deleted branch mesh_isomorphism from wannes.malfait/blender 2023-11-27 18:10:40 +01:00
Wannes Malfait pushed to mesh_isomorphism at wannes.malfait/blender 2023-11-21 11:10:37 +01:00
93104d3386 Change namespace to compare_meshes
Wannes Malfait commented on pull request blender/blender#112794 2023-11-20 15:02:26 +01:00
Mesh: add index-independent test for mesh equality

Sorry for the delay! That sounds great to me. And yeah, I guess we'll have to update test results for edge indices.

No problem, have been busy with other stuff as well.

I merged main…

Wannes Malfait pushed to mesh_isomorphism at wannes.malfait/blender 2023-11-20 14:59:44 +01:00
e0970b3ce1 Remove BKE_mesh_cmp
65325558a1 Merge branch 'main' into mesh_isomorphism
c9ba4f694b Cleanup: Make format
27fdfb6538 Vulkan: Memory Statistics
b63e31df57 Fix #115170: Sculpt mode crash
Compare 809 commits »
Wannes Malfait commented on pull request blender/blender#112794 2023-10-19 16:51:34 +02:00
Mesh: add index-independent test for mesh equality

I added the changes I talked about. The function can now detect if the meshes are just isomorphic or exactly equal.

Still have to remove the BKE_mesh_cmp function. (Wanted your approval for…

Wannes Malfait pushed to mesh_isomorphism at wannes.malfait/blender 2023-10-19 16:45:49 +02:00
23a8125fb8 Test for mesh equality
0d898f568c Merge branch 'main' into mesh_isomorphism
687e58bb77 Cleanup: Simplify public API of unique name functions
fba7671205 Cleanup: Const correctness, unused variable warning in GP draw code
5db502a122 Fix: Build error after bounding box refactor
Compare 150 commits »
Wannes Malfait commented on pull request blender/blender#112794 2023-10-17 11:15:38 +02:00
Mesh: add index-independent test for mesh equality

Doesn't this meshes_unisomorphic test also check the same things that BKE_mesh_cmp checked? I had thought of this as a superset of the original comparison tests. It would be great to get rid…

Wannes Malfait pushed to mesh_isomorphism at wannes.malfait/blender 2023-10-17 10:36:38 +02:00
dd018c76c9 Use function for additional info when test fails
5d1bf2ebda Revert "get rid of BKE_mesh_cmp"
19cd0b104d rename to meshes_unisomorphic
c52b3af51d return std::nullopt instead of {}
65791d6d5b Use is_same_any_v
Compare 79 commits »
Wannes Malfait commented on pull request blender/blender#112794 2023-10-17 09:37:59 +02:00
Mesh: add index-independent test for mesh equality

I think you are right. I will change it so that the normal comparison is run, but if the test fails, then a check is done to see if they are isomorphic.

Wannes Malfait commented on pull request blender/blender#112794 2023-10-17 09:30:20 +02:00
Mesh: add index-independent test for mesh equality

I really wanted to use something like Result<(), MeshMismatch> in rust, but ended up with this instead. I completely agree with you, and will change the name to meshes_unisomorphic which fits…

Wannes Malfait pushed to mesh_isomorphism at wannes.malfait/blender 2023-10-15 16:25:24 +02:00
396a3af413 Merge branch 'main' into mesh_isomorphism
ba89723abc Cleanup: EEVEE-Next: Volume AABB
14fa963910 Cleanup: move node declaration code out of header
46dedaf960 Cleanup: use C++ style casts in for the animation player
a3243cf5c3 PlayAnim: errors loading images are now shown in the UI
Compare 13 commits »
Wannes Malfait pushed to mesh_isomorphism at wannes.malfait/blender 2023-10-15 16:20:59 +02:00
273e477034 Sort float vectors per component
Wannes Malfait commented on pull request blender/blender#112794 2023-10-14 23:14:26 +02:00
Mesh: add index-independent test for mesh equality

I completely replaced BKE_mesh_cmp now. I ended up keeping the threshold parameter, since there are some tests that set it explicitly. All the current tests still pass with the new comparison…