Weizhen Huang weizhen
  • Joined on 2022-10-03
Weizhen Huang commented on pull request blender/blender#105862 2023-03-20 15:55:51 +01:00
Cycles: build Light Tree in parallel

Eventually we can also parallelize the loops in nodes with many prims.

I tried to parallelize that too, but I saw almost no performance improvement. After this pull request is merged, I'll…

Weizhen Huang commented on pull request blender/blender#105862 2023-03-20 15:51:39 +01:00
Cycles: build Light Tree in parallel

It's also used for recursive_build<left>(current_node, start, middle, prims, bit_trail, depth + 1);, I think it looks better than recursive_build(0, current_node, start, middle, prims, bit_trail, depth + 1);

Weizhen Huang pushed to parallel_light_tree at weizhen/blender 2023-03-20 14:43:50 +01:00
2539258099 Cycles: build Light Tree in parallel
7484a1504d Cleanup: rename function
dfe7b839bc Cycles: only apply function #ensure_valid_reflection to glossy materials
70f3382c45 Refactor: simplify computations in function #ensure_valid_reflection
4784ee852c Merge branch 'blender-v3.5-release'
Compare 7 commits »
Weizhen Huang deleted branch no_normal_trick_for_diffuse from weizhen/blender 2023-03-20 14:42:46 +01:00
Weizhen Huang closed pull request blender/blender#105776 2023-03-20 14:42:14 +01:00
Cycles: only apply function #ensure_valid_reflection to glossy materials
Weizhen Huang commented on pull request blender/blender#105776 2023-03-20 14:42:13 +01:00
Cycles: only apply function #ensure_valid_reflection to glossy materials

Manually merged as 7484a1504d, dfe7b839bc, 70f3382c45

Weizhen Huang pushed to main at blender/blender 2023-03-20 14:36:17 +01:00
7484a1504d Cleanup: rename function
dfe7b839bc Cycles: only apply function #ensure_valid_reflection to glossy materials
70f3382c45 Refactor: simplify computations in function #ensure_valid_reflection
Compare 3 commits »
Weizhen Huang commented on pull request blender/blender#105862 2023-03-20 12:30:19 +01:00
Cycles: build Light Tree in parallel

Build again with MIN_PRIMS_PER_THREAD set to INT_MAX to test the parallel build.

@blender-bot build

Weizhen Huang pushed to parallel_light_tree at weizhen/blender 2023-03-20 12:28:57 +01:00
1b9d56ce9c Cycles: build Light Tree in parallel
Weizhen Huang commented on pull request blender/blender#105862 2023-03-20 11:51:56 +01:00
Cycles: build Light Tree in parallel
Weizhen Huang pushed to parallel_light_tree at weizhen/blender 2023-03-20 11:42:37 +01:00
66b46eee66 Cycles: build Light Tree in parallel
Weizhen Huang pushed to parallel_light_tree at weizhen/blender 2023-03-20 11:39:42 +01:00
8bd9a5bf0a Cycles: build Light Tree in parallel
5584c1cb53 IO: add PLY export test coverage for loose edges and loose vertices
4c70d9e11a Merge branch 'blender-v3.5-release'
de49d18af5 Fix: Invalid custom data read during legacy mesh format conversion
7cda559d7c Cleanup: format, spelling, struct member comment
Compare 38 commits »
Weizhen Huang created pull request blender/blender#105862 2023-03-17 20:08:39 +01:00
WIP: Cycles: build Light Tree in parallel
Weizhen Huang pushed to parallel_light_tree at weizhen/blender 2023-03-17 20:04:20 +01:00
26d66945c6 Cycles: build Light Tree in parallel
728694b4e4 Cleanup: use array instead of vector for LightTreeBucket with fixed size
a1a11b08d8 Cleanup: added a bunch of const qualifiers in Light Tree
74070a1c2c Merge branch 'blender-v3.5-release'
ddec556ef3 Fix make_update running on a freshly cloned Blender fork
Compare 10 commits »
Weizhen Huang created branch parallel_light_tree in weizhen/blender 2023-03-17 20:04:20 +01:00
Weizhen Huang pushed to main at blender/blender 2023-03-17 20:01:44 +01:00
728694b4e4 Cleanup: use array instead of vector for LightTreeBucket with fixed size
a1a11b08d8 Cleanup: added a bunch of const qualifiers in Light Tree
Compare 2 commits »
Weizhen Huang pushed to main at blender/blender 2023-03-17 15:28:47 +01:00
d9273d8578 Fix Cycles growing BoundBox with empty BoundBox modifies the original BoundBox
Weizhen Huang pushed to no_normal_trick_for_diffuse at weizhen/blender 2023-03-16 11:29:39 +01:00
4a1377c056 Cleanup: remove unused function for osl
Weizhen Huang commented on pull request blender/blender#105776 2023-03-15 20:44:29 +01:00
Cycles: only apply function #ensure_valid_reflection to glossy materials

Commited changes, the behavior should be the same before, except for CLOSURE_BSDF_GLOSSY_TOON_ID, as I don't really know what ATTR_FALLTHROUGH is doing.

Weizhen Huang pushed to no_normal_trick_for_diffuse at weizhen/blender 2023-03-15 20:38:34 +01:00
b71ab424c4 Refactor: call #ensure_valid_specular_reflection in separate cases