What is this doc folder? It makes sense to put it in a folder named scripts, but this doc still feels weird.
This is minor and can be done outside of this PR, but the ellipse tables are not bsdf tables. Probably we should rename it to just lookup table or something.
Seems that this large block of comment holds for all the following functions, which was not obvious at first sight. I would suggest to make it a code section https://developer.blender.org/docs/handbook/guidelines/c_cpp/#comment-sections
Would be more clear to call the function spherical_ellipse_solid_angle.
There are some quite weird artifacts? The sample quality near grazing angles is improved, but there are other regions with worse sample quality, which was unexpected. Especially the lines in the…
g == 0
A threshold of 1e-2f might seem too big, but the Draine CDF at `
This clarification sound fine to me. For the wording, I guess the first statement is true whether or not the option is disabled, so we don't need to say "disabled motion blur". I could suggest…
This change itself is fine, but I wonder are you trying to prevent or solve a problem? We didn't hit the limit in practice, so I was kind of waiting for a scene to fail, so that we can test the change to see whether preventing the split or increasing the limit is better.
I believe depth < 32 should be part of the function should_split().