Weizhen Huang weizhen
18 Followers · 0 Following
  • Joined on 2022-10-03
Repositories
2
 Projects Public Activity Starred Repositories
Weizhen Huang commented on pull request blender/blender#107747 2023-07-17 09:10:40 +02:00
Fix #103977: Cycles handling ray visibility inconsistent for forward and nee

I wonder, shouldn't the function surface_shader_bsdf_eval_pdfs() just below it follow the same logic and be corrected too?

Weizhen Huang pushed to main at blender/blender 2023-07-14 12:23:16 +02:00
a86506b741 Cleanup: sort enum KernelFeatureFlag in order
Weizhen Huang pushed to main at blender/blender 2023-07-13 15:45:06 +02:00
4724147479 Fix #109945: Division by zero in brick texture
Weizhen Huang closed issue blender/blender#109945 2023-07-13 15:45:05 +02:00
Regression: Brick Texture Renders Black with certain inputs
Weizhen Huang commented on issue blender/blender#109945 2023-07-13 15:07:54 +02:00
Regression: Brick Texture Renders Black with certain inputs

Hey! Sorry, I should have split the commits. I was expecting smoothstepf() to handle the special cases so that the branches in brick.h are not needed, especially division by zero should not be…

Weizhen Huang pushed to remove_passing_color at weizhen/blender 2023-07-12 17:25:15 +02:00
e4610fb000 Cleanup: Cycles: remove redundant argument Input("Color")
861931101c Fix #109994: Layer unlinks from the list when drop location is same
1c0ffa1e18 Fix mistake in recent change to liboverride cleanup of invalid operations.
f1fbe9a691 Cleanup: Remove redundant selection center calculation
3d86417777 Fix build error without unity build
Compare 10 commits »
Weizhen Huang created branch remove_passing_color in weizhen/blender 2023-07-12 17:25:15 +02:00
Weizhen Huang pushed to main at blender/blender 2023-07-12 12:36:39 +02:00
0b3efc9d8c Cleanup: Cycles: remove SHARP distribution internally
Weizhen Huang deleted branch remove_sharp_distribution from weizhen/blender 2023-07-12 12:36:39 +02:00
Weizhen Huang merged pull request blender/blender#109902 2023-07-12 12:36:38 +02:00
Cleanup: Cycles: remove `SHARP` distribution internally
Weizhen Huang pushed to remove_sharp_distribution at weizhen/blender 2023-07-12 12:32:10 +02:00
056502f5a5 Merge branch 'main' into remove_sharp_distribution
1b37bb8c27 Add back osl reflection and refraction closures
008513fd8b Reduce duplication of comparing roughness with thresh
84c8c331b4 Fix: Complier error
157f1dfc81 Cleanup: make format
Compare 118 commits »
Weizhen Huang approved blender/blender#109951 2023-07-12 11:21:01 +02:00
Cycles: Merge OSL Clearcoat closure into microfacet()
Weizhen Huang approved blender/blender#109950 2023-07-12 11:18:23 +02:00
Cycles: Remove Transmission Roughness from Principled BSDF

Looks really good! I have a small side note.

Weizhen Huang commented on pull request blender/blender#109950 2023-07-12 11:18:00 +02:00
Cycles: Remove Transmission Roughness from Principled BSDF

I'm not sure if there is some consensus here regarding the naming, but it feels a bit weird to call this the transmission component, as if it's only handling the transmission part, where as it's actually a combination of reflection and transmission (refraction), looks more like a glass component to me.

Weizhen Huang pushed to remove_sharp_distribution at weizhen/blender 2023-07-10 17:02:39 +02:00
b4cddda82e Cleanup: rename BSDF_ROUGHNESS_THRESH to BSDF_ROUGHNESS_SQ_THRESH
Weizhen Huang deleted branch sun_light_texture from weizhen/blender 2023-07-10 12:20:55 +02:00
Weizhen Huang merged pull request blender/blender#109842 2023-07-10 12:20:54 +02:00
Cycles: add texture to sun light
Weizhen Huang pushed to main at blender/blender 2023-07-10 12:20:54 +02:00
ab12d2836b Cycles: add texture to sun light
Weizhen Huang created pull request blender/blender#109902 2023-07-10 12:17:31 +02:00
Cleanup: Cycles: remove SHARP distribution internally
Weizhen Huang pushed to remove_sharp_distribution at weizhen/blender 2023-07-10 12:09:36 +02:00
d172609e18 Cleanup: Cycles: remove SHARP distribution internally