Add Cycles render tests for texture nodes #6
No reviewers
Labels
No Label
No Milestone
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: blender/blender-test-data#6
Loading…
Reference in New Issue
Block a user
No description provided.
Delete Branch "Alaska:add-texture-tests"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Ref blender/blender#123012
I would suggest to improve the object names to represent the features they are testing. For example, in
white_noise_xxx.blend
, you seem to be testing different dimensions of the noise texture, then you can name the objects toCube 4D
, etc.BTW, when you were making the tests, did you browse through the (closed) bug reports and see if there is anything worth adding? I'm asking because I plan to check the bug reports, but maybe you have already done that.
I'll work on this today.
I didn't look through the bug list. But I'll add a test for blender/blender#119797 today (It's the only texture node bug I can remember in recent history).
I've added names to basically every object to help describe what it's testing. Along with that:
119797
to the background ofmusgrave_multifractal_36.blend
(This issue was present in the musgrave node, and appeared in the noise texture node once they merged.white_noise_*.blend
.I've been generating test images on Windows with a x86 CPU in Blender 4.3 with builds from the build bot, and I've been comparing it to OptiX in that same build. Some tests are currently failing on OptiX (see attached image).
I've looked into bug reports from the last year (The oldest report I looked at was from Janurary 20th, 2023) to see if I can find other tests to add.
/render/reports/
or to/render/texture/
Weizhen Huang referenced this pull request from blender/blender2024-07-16 13:56:07 +02:00
I would expect that property from a hash function. We can insert a snap node before white noise, just as in the manual.
I created a pattern with white noise just for fun.
I would prefer
/render/texture
.render/reports/
is when we don't know how to catergorize the test and it's not clear at all.This link is wrong.
A few more points:
render/light
?I've fixed it. Thanks for spotting.
I will fix that and add some tests for the reports I mentioned above.
I made most of the Voronoi texture tests in Blender 3.6 which didn't have lacunarity or detail. And when they're loaded in newer versions of Blender, their detail is set to 0.
So I added some extra tests created in Blender 4.2 (
voronoi_*_fractal
) that does test lacunarity with a detail greater than 0.It does test a new case, IES on a mesh light, but I'm not sure how useful that is.
Note: In my testing, the bahviour of a IES texture on a mesh light changed between Blender 3.6 and 4.3. So if the behaviour on a mesh light is important, then we should test it. But we can probably just add that to
render/light
It's a nice pattern.
Ok, I haven't used it myself so not sure. We can leave it for now and see what other people think. If it's needed I would prefer to put it in
render/light
.The issue in 109253 only occured with OSL on. I haven't enabled OSL in the file I added the test to, so the bug report isn't currently tested. But that should be resolved with blender/blender!124601. Let me know if you would like this test to be seperated out to a different file with OSL enabled.
I haven't added the mesh IES test to the
/render/light/
suite. Would you like that to happen as part of this pull request? Or prefer that be updated seperately when iterating on/updating other tests?I also believe Cycles supports the loading of three different IES types. We should probably update the IES tests to test all three. I'll make a note on blender/blender#123012
WIP: Add Cycles render tests for texture nodesto Add Cycles render tests for texture nodesNote to self: Retest and potentially update test file for Garbor due to:
ce89d7949c
075bdbcd63
Edit: Done
I am closing this PR in favour of #16
All the test files and images are the same (And I verified they still pass in latest main). But by having the branch be in
blender/blender-test-data
, it makes it easier to test with the build bot.Pull request closed